Unverified Commit c1fc988f authored by Niklas Mischkulnig's avatar Niklas Mischkulnig Committed by GitHub

Turbopack: remove unused code (#88497)

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the PR.
- Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to understand the PR)
- When linking to a Slack thread, you might want to share details of the conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->
parent 60b5df66
use core::panic;
use std::{
collections::{BinaryHeap, VecDeque, hash_map::Entry},
collections::{BinaryHeap, VecDeque},
future::Future,
};
use anyhow::{Context, Result, bail};
use auto_hash_map::AutoSet;
use bincode::{Decode, Encode};
use petgraph::{
Direction,
......@@ -27,7 +26,7 @@ use turbo_tasks_fs::FileSystemPath;
use crate::{
chunk::{AsyncModuleInfo, ChunkingContext, ChunkingType},
issue::{ImportTrace, ImportTracer, ImportTraces, Issue},
issue::{ImportTracer, ImportTraces, Issue},
module::Module,
module_graph::{
async_module_info::{AsyncModulesInfo, compute_async_module_info},
......@@ -521,104 +520,6 @@ impl SingleModuleGraph {
}
Ok(())
}
/// For each issue computes a (possibly empty) list of traces from the file that produced the
/// issue to roots in this module graph.
/// There are potentially multiple traces because a given file may get assigned to multiple
/// modules depend on how it is used in the application. Consider a simple utility that is used
/// by SSR pages, client side code, and the edge runtime. This may lead to there being 3
/// traces.
/// The returned map is guaranteed to have an entry for every issue.
pub async fn compute_import_traces_for_issues(
&self,
issues: &AutoSet<ResolvedVc<Box<dyn Issue>>>,
) -> Result<FxHashMap<ResolvedVc<Box<dyn Issue>>, Vec<ImportTrace>>> {
let issue_paths = issues
.iter()
.map(|issue| issue.file_path().owned())
.try_join()
.await?;
let mut file_path_to_traces: FxHashMap<FileSystemPath, Vec<ImportTrace>> =
FxHashMap::with_capacity_and_hasher(issue_paths.len(), Default::default());
// initialize an empty vec for each path we care about
for issue in &issue_paths {
file_path_to_traces.entry(issue.clone()).or_default();
}
{
let modules =
self.modules
.iter()
.map(|(module, &index)| async move {
Ok((module.ident().path().owned().await?, index))
})
.try_join()
.await?;
// Reverse the graph so we can find paths to roots
let reversed_graph = Reversed(&self.graph.0);
for (path, module_idx) in modules {
if let Entry::Occupied(mut entry) = file_path_to_traces.entry(path) {
// compute the path from this index to a root of the graph.
let Some((_, path)) = petgraph::algo::astar(
&reversed_graph,
module_idx,
|n| reversed_graph.neighbors(n).next().is_none(),
// Edge weights
|e| match e.weight().chunking_type {
// Prefer following normal imports/requires when we can
ChunkingType::Parallel { .. } => 0,
_ => 1,
},
// `astar` can be accelerated with a distance estimation heuristic, as long
// as our estimate is never > the actual distance.
// However we don't have a mechanism, so just
// estimate 0 which essentially makes this behave like
// dijktra's shortest path algorithm. `petgraph` has an implementation of
// dijkstra's but it doesn't report paths, just distances.
// NOTE: dijkstra's with integer weights can be accelerated with incredibly
// efficient priority queue structures (basically with only 0 and 1 as
// weights you can use a `VecDeque`!). However,
// this is unlikely to be a performance concern.
// Furthermore, if computing paths _does_ become a performance concern, the
// solution would be a hand written implementation of dijkstras so we can
// hoist redundant work out of this loop.
|_| 0,
) else {
unreachable!("there must be a path to a root");
};
// Represent the path as a sequence of AssetIdents
// TODO: consider hinting at various transitions (e.g. was this an
// import/require/dynamic-import?)
let path = path
.into_iter()
.map(async |n| {
Ok(self
.graph
.node_weight(n)
.unwrap()
.module()
.ident()
.await?
.clone())
})
.try_join()
.await?;
entry.get_mut().push(path);
}
}
}
let mut issue_to_traces: FxHashMap<ResolvedVc<Box<dyn Issue>>, Vec<ImportTrace>> =
FxHashMap::with_capacity_and_hasher(issues.len(), Default::default());
// Map filepaths back to issues
// We can do this by zipping the issue_paths with the issues since they are in the same
// order.
for (path, issue) in issue_paths.iter().zip(issues) {
if let Some(traces) = file_path_to_traces.get(path) {
issue_to_traces.insert(*issue, traces.clone());
}
}
Ok(issue_to_traces)
}
}
#[turbo_tasks::value]
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment