Unverified Commit c220f26f authored by Jiachi Liu's avatar Jiachi Liu Committed by GitHub

refactor: remove unused variable in externals handling (#76599)

### What

`_optOutBundlingPackages` was not used as there's already a optOutBundlingPackagesRegex, removing it from the `handleExternals`
parent 10bf03e2
...@@ -48,7 +48,6 @@ export async function resolveExternal( ...@@ -48,7 +48,6 @@ export async function resolveExternal(
context: string, context: string,
request: string, request: string,
isEsmRequested: boolean, isEsmRequested: boolean,
_optOutBundlingPackages: string[],
getResolve: ( getResolve: (
options: ResolveOptions options: ResolveOptions
) => ( ) => (
...@@ -133,13 +132,11 @@ export async function resolveExternal( ...@@ -133,13 +132,11 @@ export async function resolveExternal(
export function makeExternalHandler({ export function makeExternalHandler({
config, config,
optOutBundlingPackages,
optOutBundlingPackageRegex, optOutBundlingPackageRegex,
transpiledPackages, transpiledPackages,
dir, dir,
}: { }: {
config: NextConfigComplete config: NextConfigComplete
optOutBundlingPackages: string[]
optOutBundlingPackageRegex: RegExp optOutBundlingPackageRegex: RegExp
transpiledPackages: string[] transpiledPackages: string[]
dir: string dir: string
...@@ -266,7 +263,6 @@ export function makeExternalHandler({ ...@@ -266,7 +263,6 @@ export function makeExternalHandler({
context, context,
request, request,
isEsmRequested, isEsmRequested,
optOutBundlingPackages,
getResolve, getResolve,
isLocal ? resolveNextExternal : undefined isLocal ? resolveNextExternal : undefined
) )
...@@ -334,7 +330,6 @@ export function makeExternalHandler({ ...@@ -334,7 +330,6 @@ export function makeExternalHandler({
context, context,
pkg + '/package.json', pkg + '/package.json',
isEsmRequested, isEsmRequested,
optOutBundlingPackages,
getResolve, getResolve,
isLocal ? resolveNextExternal : undefined isLocal ? resolveNextExternal : undefined
) )
......
...@@ -863,7 +863,6 @@ export default async function getBaseWebpackConfig( ...@@ -863,7 +863,6 @@ export default async function getBaseWebpackConfig(
const handleExternals = makeExternalHandler({ const handleExternals = makeExternalHandler({
config, config,
optOutBundlingPackages,
optOutBundlingPackageRegex, optOutBundlingPackageRegex,
transpiledPackages: finalTranspilePackages, transpiledPackages: finalTranspilePackages,
dir, dir,
...@@ -1927,7 +1926,6 @@ export default async function getBaseWebpackConfig( ...@@ -1927,7 +1926,6 @@ export default async function getBaseWebpackConfig(
esmExternals: config.experimental.esmExternals, esmExternals: config.experimental.esmExternals,
outputFileTracingRoot: config.outputFileTracingRoot, outputFileTracingRoot: config.outputFileTracingRoot,
appDirEnabled: hasAppDir, appDirEnabled: hasAppDir,
optOutBundlingPackages,
traceIgnores: [], traceIgnores: [],
compilerType, compilerType,
} }
......
...@@ -131,7 +131,6 @@ export class TraceEntryPointsPlugin implements webpack.WebpackPluginInstance { ...@@ -131,7 +131,6 @@ export class TraceEntryPointsPlugin implements webpack.WebpackPluginInstance {
private rootDir: string private rootDir: string
private appDir: string | undefined private appDir: string | undefined
private pagesDir: string | undefined private pagesDir: string | undefined
private optOutBundlingPackages: string[]
private appDirEnabled?: boolean private appDirEnabled?: boolean
private tracingRoot: string private tracingRoot: string
private entryTraces: Map<string, Map<string, { bundled: boolean }>> private entryTraces: Map<string, Map<string, { bundled: boolean }>>
...@@ -144,7 +143,6 @@ export class TraceEntryPointsPlugin implements webpack.WebpackPluginInstance { ...@@ -144,7 +143,6 @@ export class TraceEntryPointsPlugin implements webpack.WebpackPluginInstance {
appDir, appDir,
pagesDir, pagesDir,
compilerType, compilerType,
optOutBundlingPackages,
appDirEnabled, appDirEnabled,
traceIgnores, traceIgnores,
esmExternals, esmExternals,
...@@ -154,7 +152,6 @@ export class TraceEntryPointsPlugin implements webpack.WebpackPluginInstance { ...@@ -154,7 +152,6 @@ export class TraceEntryPointsPlugin implements webpack.WebpackPluginInstance {
compilerType: CompilerNameValues compilerType: CompilerNameValues
appDir: string | undefined appDir: string | undefined
pagesDir: string | undefined pagesDir: string | undefined
optOutBundlingPackages: string[]
appDirEnabled?: boolean appDirEnabled?: boolean
traceIgnores?: string[] traceIgnores?: string[]
outputFileTracingRoot?: string outputFileTracingRoot?: string
...@@ -168,7 +165,6 @@ export class TraceEntryPointsPlugin implements webpack.WebpackPluginInstance { ...@@ -168,7 +165,6 @@ export class TraceEntryPointsPlugin implements webpack.WebpackPluginInstance {
this.appDirEnabled = appDirEnabled this.appDirEnabled = appDirEnabled
this.traceIgnores = traceIgnores || [] this.traceIgnores = traceIgnores || []
this.tracingRoot = outputFileTracingRoot || rootDir this.tracingRoot = outputFileTracingRoot || rootDir
this.optOutBundlingPackages = optOutBundlingPackages
this.compilerType = compilerType this.compilerType = compilerType
} }
...@@ -786,7 +782,6 @@ export class TraceEntryPointsPlugin implements webpack.WebpackPluginInstance { ...@@ -786,7 +782,6 @@ export class TraceEntryPointsPlugin implements webpack.WebpackPluginInstance {
context, context,
request, request,
isEsmRequested, isEsmRequested,
this.optOutBundlingPackages,
(options) => (_: string, resRequest: string) => { (options) => (_: string, resRequest: string) => {
return getResolve(options)(parent, resRequest, job) return getResolve(options)(parent, resRequest, job)
}, },
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment