Unverified Commit c45481be authored by Jimmy Lai's avatar Jimmy Lai Committed by GitHub

build: remove warning when building with a middleware present (#45518)

fixes the feedback in https://github.com/vercel/next.js/discussions/41745#discussioncomment-4842682

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md)

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md)

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm build && pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
parent 8ad018fb
...@@ -512,38 +512,40 @@ export default async function exportApp( ...@@ -512,38 +512,40 @@ export default async function exportApp(
} }
let hasMiddleware = false let hasMiddleware = false
try { if (!options.buildExport) {
const middlewareManifest = require(join( try {
distDir, const middlewareManifest = require(join(
SERVER_DIRECTORY, distDir,
MIDDLEWARE_MANIFEST SERVER_DIRECTORY,
)) as MiddlewareManifest MIDDLEWARE_MANIFEST
)) as MiddlewareManifest
hasMiddleware = Object.keys(middlewareManifest.middleware).length > 0 hasMiddleware = Object.keys(middlewareManifest.middleware).length > 0
} catch (_) {} } catch (_) {}
// Warn if the user defines a path for an API page // Warn if the user defines a path for an API page
if (hasApiRoutes || hasMiddleware) { if (hasApiRoutes || hasMiddleware) {
if (!options.silent) { if (!options.silent) {
Log.warn( Log.warn(
chalk.yellow(
`Statically exporting a Next.js application via \`next export\` disables API routes and middleware.`
) +
`\n` +
chalk.yellow(
`This command is meant for static-only hosts, and is` +
' ' +
chalk.bold(`not necessary to make your application static.`)
) +
`\n` +
chalk.yellow( chalk.yellow(
`Pages in your application without server-side data dependencies will be automatically statically exported by \`next build\`, including pages powered by \`getStaticProps\`.` `Statically exporting a Next.js application via \`next export\` disables API routes and middleware.`
) + ) +
`\n` + `\n` +
chalk.yellow( chalk.yellow(
`Learn more: https://nextjs.org/docs/messages/api-routes-static-export` `This command is meant for static-only hosts, and is` +
) ' ' +
) chalk.bold(`not necessary to make your application static.`)
) +
`\n` +
chalk.yellow(
`Pages in your application without server-side data dependencies will be automatically statically exported by \`next build\`, including pages powered by \`getStaticProps\`.`
) +
`\n` +
chalk.yellow(
`Learn more: https://nextjs.org/docs/messages/api-routes-static-export`
)
)
}
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment