Unverified Commit c53ac3e1 authored by Donny/강동윤's avatar Donny/강동윤 Committed by GitHub

build: Update `swc_core` to `v16.0.0` (#76414)

### What?

Update `swc_core` to `v16.0.0`. This is a Wasm-breaking change, and changelog is at https://github.com/swc-project/swc/compare/swc_core%40v14.0.1...swc_core%40v16.0.0

### Why?

To apply various fixes.
parent be051841
This diff is collapsed.
......@@ -299,21 +299,21 @@ turbopack-trace-utils = { path = "turbopack/crates/turbopack-trace-utils" }
turbopack-wasm = { path = "turbopack/crates/turbopack-wasm" }
# SWC crates
swc_core = { version = "14.0.1", features = [
swc_core = { version = "16.0.0", features = [
"ecma_loader_lru",
"ecma_loader_parking_lot",
] }
testing = { version = "7.0.0" }
testing = { version = "8.0.0" }
# Keep consistent with preset_env_base through swc_core
browserslist-rs = { version = "0.17.0" }
miette = { version = "5.10.0", features = ["fancy"] }
mdxjs = "0.3"
modularize_imports = { version = "0.77.0" }
styled_components = { version = "0.105.0" }
styled_jsx = { version = "0.81.0" }
swc_emotion = { version = "0.81.0" }
swc_relay = { version = "0.51.0" }
modularize_imports = { version = "0.79.0" }
styled_components = { version = "0.107.0" }
styled_jsx = { version = "0.83.0" }
swc_emotion = { version = "0.83.0" }
swc_relay = { version = "0.53.0" }
# General Deps
chromiumoxide = { version = "0.5.4", features = [
......@@ -435,4 +435,4 @@ wasmer-cache = { git = "https://github.com/kdy1/wasmer", branch = "build-deps" }
wasmer-compiler-cranelift = { git = "https://github.com/kdy1/wasmer", branch = "build-deps" }
wasmer-wasix = { git = "https://github.com/kdy1/wasmer", branch = "build-deps" }
mdxjs={git="https://github.com/kdy1/mdxjs-rs.git",branch = "swc-core-14"}
mdxjs = { git="https://github.com/kdy1/mdxjs-rs.git", branch = "swc-core-15" }
......@@ -32,8 +32,8 @@ lazy_static = { workspace = true }
thiserror = { workspace = true }
tracing = { workspace = true }
rustc-hash = { workspace = true }
react_remove_properties = "0.31.0"
remove_console = "0.32.0"
react_remove_properties = "0.33.0"
remove_console = "0.34.0"
auto-hash-map = { workspace = true }
......
use anyhow::Result;
use async_trait::async_trait;
use next_custom_transforms::transforms::fonts::*;
use swc_core::ecma::{ast::Program, atoms::JsWord, visit::VisitMutWith};
use swc_core::ecma::{ast::Program, atoms::Atom, visit::VisitMutWith};
use turbo_tasks::ResolvedVc;
use turbopack::module_options::{ModuleRule, ModuleRuleEffect};
use turbopack_ecmascript::{CustomTransformer, EcmascriptInputTransform, TransformContext};
......@@ -33,7 +33,7 @@ pub fn get_next_font_transform_rule(enable_mdx_rs: bool) -> ModuleRule {
#[derive(Debug)]
struct NextJsFont {
font_loaders: Vec<JsWord>,
font_loaders: Vec<Atom>,
}
#[async_trait]
......
......@@ -60,8 +60,8 @@ swc_relay = { workspace = true }
turbopack-ecmascript-plugins = { workspace = true, optional = true }
turbo-rcstr = { workspace = true }
react_remove_properties = "0.31.0"
remove_console = "0.32.0"
react_remove_properties = "0.33.0"
remove_console = "0.34.0"
preset_env_base = "2.0.1"
[dev-dependencies]
......
......@@ -3,7 +3,7 @@ use swc_core::ecma::{
Ident, IdentName, JSXAttr, JSXAttrName, JSXAttrOrSpread, JSXElementName, JSXOpeningElement,
Pass,
},
atoms::JsWord,
atoms::Atom,
visit::{fold_pass, Fold},
};
......@@ -37,7 +37,7 @@ impl Fold for AmpAttributePatcher {
if sym as &str == "className" {
*i = JSXAttrOrSpread::JSXAttr(JSXAttr {
name: JSXAttrName::Ident(IdentName {
sym: JsWord::from("class"),
sym: Atom::from("class"),
span: *s,
}),
span: *span,
......
......@@ -2,13 +2,13 @@ use swc_core::{
common::errors::HANDLER,
ecma::{
ast::*,
atoms::JsWord,
atoms::Atom,
visit::{noop_visit_type, Visit},
},
};
pub struct FontFunctionsCollector<'a> {
pub font_loaders: &'a [JsWord],
pub font_loaders: &'a [Atom],
pub state: &'a mut super::State,
}
......
......@@ -3,7 +3,7 @@ use swc_core::{
common::{errors::HANDLER, Spanned, DUMMY_SP},
ecma::{
ast::*,
atoms::JsWord,
atoms::Atom,
visit::{noop_visit_type, Visit},
},
};
......@@ -66,7 +66,7 @@ impl FontImportsGenerator<'_> {
return Some(ImportDecl {
src: Box::new(Str {
value: JsWord::from(format!(
value: Atom::from(format!(
"{}/target.css?{}",
font_function.loader, query_json
)),
......
......@@ -4,7 +4,7 @@ use swc_core::{
common::{BytePos, Spanned},
ecma::{
ast::{Id, ModuleItem, Pass},
atoms::JsWord,
atoms::Atom,
visit::{noop_visit_mut_type, visit_mut_pass, VisitMut, VisitWith},
},
};
......@@ -16,8 +16,8 @@ mod font_imports_generator;
#[derive(Clone, Debug, Deserialize)]
#[serde(deny_unknown_fields, rename_all = "camelCase")]
pub struct Config {
pub font_loaders: Vec<JsWord>,
pub relative_file_path_from_root: JsWord,
pub font_loaders: Vec<Atom>,
pub relative_file_path_from_root: Atom,
}
pub fn next_font_loaders(config: Config) -> impl Pass + VisitMut {
......@@ -31,8 +31,8 @@ pub fn next_font_loaders(config: Config) -> impl Pass + VisitMut {
#[derive(Debug)]
pub struct FontFunction {
loader: JsWord,
function_name: Option<JsWord>,
loader: Atom,
function_name: Option<Atom>,
}
#[derive(Debug, Default)]
pub struct State {
......
use rustc_hash::{FxHashMap, FxHashSet};
use swc_core::{
atoms::JsWord,
atoms::Atom,
ecma::{
ast::{
Expr, Id, ImportDecl, ImportNamedSpecifier, ImportSpecifier, MemberExpr, MemberProp,
......@@ -13,16 +13,16 @@ use swc_core::{
#[derive(Debug, Default)]
pub(crate) struct ImportMap {
/// Map from module name to (module path, exported symbol)
imports: FxHashMap<Id, (JsWord, JsWord)>,
imports: FxHashMap<Id, (Atom, Atom)>,
namespace_imports: FxHashMap<Id, JsWord>,
namespace_imports: FxHashMap<Id, Atom>,
imported_modules: FxHashSet<JsWord>,
imported_modules: FxHashSet<Atom>,
}
#[allow(unused)]
impl ImportMap {
pub fn is_module_imported(&mut self, module: &JsWord) -> bool {
pub fn is_module_imported(&mut self, module: &Atom) -> bool {
self.imported_modules.contains(module)
}
......@@ -96,7 +96,7 @@ impl Visit for Analyzer<'_> {
}
}
fn orig_name(n: &ModuleExportName) -> JsWord {
fn orig_name(n: &ModuleExportName) -> Atom {
match n {
ModuleExportName::Ident(v) => v.sym.clone(),
ModuleExportName::Str(v) => v.value.clone(),
......
......@@ -3,7 +3,7 @@ use swc_core::{
common::Mark,
ecma::{
ast::*,
atoms::{js_word, JsWord},
atoms::{atom, Atom},
transforms::optimization::simplify::dce::{dce, Config as DCEConfig},
visit::{fold_pass, Fold, FoldWith, VisitMutWith},
},
......@@ -11,7 +11,7 @@ use swc_core::{
#[derive(Clone, Debug, Deserialize)]
pub struct Config {
pub ignore: Vec<JsWord>,
pub ignore: Vec<Atom>,
}
pub fn shake_exports(config: Config) -> impl Pass {
......@@ -23,7 +23,7 @@ pub fn shake_exports(config: Config) -> impl Pass {
#[derive(Debug, Default)]
struct ExportShaker {
ignore: Vec<JsWord>,
ignore: Vec<Atom>,
remove_export: bool,
}
......@@ -108,14 +108,14 @@ impl Fold for ExportShaker {
}
fn fold_export_default_decl(&mut self, decl: ExportDefaultDecl) -> ExportDefaultDecl {
if !self.ignore.contains(&js_word!("default")) {
if !self.ignore.contains(&atom!("default")) {
self.remove_export = true
}
decl
}
fn fold_export_default_expr(&mut self, expr: ExportDefaultExpr) -> ExportDefaultExpr {
if !self.ignore.contains(&js_word!("default")) {
if !self.ignore.contains(&atom!("default")) {
self.remove_export = true
}
expr
......
......@@ -2,7 +2,7 @@ use anyhow::Result;
use async_trait::async_trait;
use swc_core::{
common::comments::NoopComments,
ecma::{ast::Program, atoms::JsWord},
ecma::{ast::Program, atoms::Atom},
};
use turbo_tasks::{ValueDefault, Vc};
use turbopack_ecmascript::{CustomTransformer, TransformContext};
......@@ -71,7 +71,7 @@ impl StyledComponentsTransformer {
if !top_level_import_paths.is_empty() {
options.top_level_import_paths = top_level_import_paths
.iter()
.map(|s| JsWord::from(s.clone()))
.map(|s| Atom::from(s.clone()))
.collect();
}
let meaningless_file_names = &config.meaningless_file_names;
......
use std::mem::take;
use swc_core::ecma::atoms::js_word;
use swc_core::ecma::atoms::atom;
use super::{ConstantNumber, ConstantValue, JsValue, LogicalOperator, LogicalProperty, ObjectPart};
use crate::analyzer::JsValueUrlKind;
......@@ -303,7 +303,7 @@ pub fn replace_builtin(value: &mut JsValue) -> bool {
}
}
if potential_values.is_empty() {
*value = JsValue::FreeVar(js_word!("undefined"));
*value = JsValue::FreeVar(atom!("undefined"));
} else {
*value = potential_values_to_alternatives(
potential_values,
......
......@@ -9,7 +9,7 @@ use swc_core::{
common::{comments::Comments, pass::AstNodePath, Mark, Span, Spanned, SyntaxContext, GLOBALS},
ecma::{
ast::*,
atoms::js_word,
atoms::atom,
utils::contains_ident_ref,
visit::{fields::*, *},
},
......@@ -658,7 +658,7 @@ impl EvalContext {
}
let args = args.iter().map(|arg| self.eval(&arg.expr)).collect();
let callee = Box::new(JsValue::FreeVar(js_word!("import")));
let callee = Box::new(JsValue::FreeVar(atom!("import")));
JsValue::call(callee, args)
}
......@@ -673,7 +673,7 @@ impl EvalContext {
.iter()
.map(|e| match e {
Some(e) => self.eval(&e.expr),
_ => JsValue::FreeVar(js_word!("undefined")),
_ => JsValue::FreeVar(atom!("undefined")),
})
.collect();
JsValue::array(arr)
......@@ -1127,7 +1127,7 @@ impl Analyzer<'_> {
match callee {
Callee::Import(_) => {
self.add_effect(Effect::Call {
func: Box::new(JsValue::FreeVar(js_word!("import"))),
func: Box::new(JsValue::FreeVar(atom!("import"))),
args,
ast_path: as_parent_path(ast_path),
span,
......@@ -1213,7 +1213,7 @@ impl Analyzer<'_> {
let values = self.cur_fn_return_values.take().unwrap();
Box::new(match values.len() {
0 => JsValue::FreeVar(js_word!("undefined")),
0 => JsValue::FreeVar(atom!("undefined")),
1 => values.into_iter().next().unwrap(),
_ => JsValue::alternatives(values),
})
......@@ -1793,7 +1793,7 @@ impl VisitAstPath for Analyzer<'_> {
.arg
.as_deref()
.map(|e| self.eval_context.eval(e))
.unwrap_or(JsValue::FreeVar(js_word!("undefined")));
.unwrap_or(JsValue::FreeVar(atom!("undefined")));
values.push(return_value);
}
......
......@@ -6,7 +6,7 @@ use swc_core::{
common::{comments::Comments, source_map::SmallPos, BytePos, Span, Spanned},
ecma::{
ast::*,
atoms::{js_word, JsWord},
atoms::{atom, Atom},
visit::{Visit, VisitWith},
},
};
......@@ -26,19 +26,19 @@ use crate::{
pub struct ImportAnnotations {
// TODO store this in more structured way
#[turbo_tasks(trace_ignore)]
map: BTreeMap<JsWord, JsWord>,
map: BTreeMap<Atom, Atom>,
}
/// Enables a specified transition for the annotated import
static ANNOTATION_TRANSITION: Lazy<JsWord> =
static ANNOTATION_TRANSITION: Lazy<Atom> =
Lazy::new(|| crate::annotations::ANNOTATION_TRANSITION.into());
/// Changes the chunking type for the annotated import
static ANNOTATION_CHUNKING_TYPE: Lazy<JsWord> =
static ANNOTATION_CHUNKING_TYPE: Lazy<Atom> =
Lazy::new(|| crate::annotations::ANNOTATION_CHUNKING_TYPE.into());
/// Changes the type of the resolved module (only "json" is supported currently)
static ATTRIBUTE_MODULE_TYPE: Lazy<JsWord> = Lazy::new(|| "type".into());
static ATTRIBUTE_MODULE_TYPE: Lazy<Atom> = Lazy::new(|| "type".into());
impl ImportAnnotations {
pub fn parse(with: Option<&ObjectLit>) -> ImportAnnotations {
......@@ -113,7 +113,7 @@ impl ImportAnnotations {
self.get(&ATTRIBUTE_MODULE_TYPE)
}
pub fn get(&self, key: &JsWord) -> Option<&str> {
pub fn get(&self, key: &Atom) -> Option<&str> {
self.map.get(key).map(|w| w.as_str())
}
}
......@@ -136,8 +136,8 @@ impl Display for ImportAnnotations {
#[derive(Debug)]
pub(crate) enum Reexport {
Star,
Namespace { exported: JsWord },
Named { imported: JsWord, exported: JsWord },
Namespace { exported: Atom },
Named { imported: Atom, exported: Atom },
}
/// The storage for all kinds of imports.
......@@ -147,7 +147,7 @@ pub(crate) enum Reexport {
#[derive(Default, Debug)]
pub(crate) struct ImportMap {
/// Map from identifier to (index in references, exported symbol)
imports: FxIndexMap<Id, (usize, JsWord)>,
imports: FxIndexMap<Id, (usize, Atom)>,
/// Map from identifier to index in references
namespace_imports: FxIndexMap<Id, usize>,
......@@ -177,7 +177,7 @@ pub(crate) struct ImportMap {
/// The module specifiers of star imports that are accessed dynamically and should be imported
/// as a whole.
full_star_imports: FxHashSet<JsWord>,
full_star_imports: FxHashSet<Atom>,
}
/// Represents a collection of [webpack-style "magic comments"][magic] that override import
......@@ -226,7 +226,7 @@ impl Default for &ImportAttributes {
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
pub(crate) enum ImportedSymbol {
ModuleEvaluation,
Symbol(JsWord),
Symbol(Atom),
Exports,
Part(u32),
PartEvaluation(u32),
......@@ -234,7 +234,7 @@ pub(crate) enum ImportedSymbol {
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
pub(crate) struct ImportMapReference {
pub module_path: JsWord,
pub module_path: Atom,
pub imported_symbol: ImportedSymbol,
pub annotations: ImportAnnotations,
pub issue_source: Option<IssueSource>,
......@@ -353,8 +353,8 @@ impl ImportMap {
struct StarImportAnalyzer<'a> {
/// The local identifiers of the star imports
candidates: FxIndexMap<Id, JsWord>,
full_star_imports: &'a mut FxHashSet<JsWord>,
candidates: FxIndexMap<Id, Atom>,
full_star_imports: &'a mut FxHashSet<Atom>,
}
impl Visit for StarImportAnalyzer<'_> {
......@@ -420,7 +420,7 @@ impl Analyzer<'_> {
fn ensure_reference(
&mut self,
span: Span,
module_path: JsWord,
module_path: Atom,
imported_symbol: ImportedSymbol,
annotations: ImportAnnotations,
) -> Option<usize> {
......@@ -444,7 +444,7 @@ impl Analyzer<'_> {
}
}
fn to_word(name: &ModuleExportName) -> JsWord {
fn to_word(name: &ModuleExportName) -> Atom {
match name {
ModuleExportName::Ident(ident) => ident.sym.clone(),
ModuleExportName::Str(str) => str.value.clone(),
......@@ -580,7 +580,7 @@ impl Visit for Analyzer<'_> {
self.data.reexports.push((
i,
Reexport::Named {
imported: js_word!("default"),
imported: atom!("default"),
exported: d.exported.sym.clone(),
},
));
......@@ -718,7 +718,7 @@ fn parse_ignore_directive(comments: &dyn Comments, value: Option<&ExprOrSpread>)
.next()
}
pub(crate) fn orig_name(n: &ModuleExportName) -> JsWord {
pub(crate) fn orig_name(n: &ModuleExportName) -> Atom {
match n {
ModuleExportName::Ident(v) => v.sym.clone(),
ModuleExportName::Str(v) => v.value.clone(),
......@@ -743,7 +743,7 @@ fn get_import_symbol_from_import(specifier: &ImportSpecifier) -> ImportedSymbol
Some(imported) => orig_name(imported),
_ => local.sym.clone(),
}),
ImportSpecifier::Default(..) => ImportedSymbol::Symbol(js_word!("default")),
ImportSpecifier::Default(..) => ImportedSymbol::Symbol(atom!("default")),
ImportSpecifier::Namespace(..) => ImportedSymbol::Exports,
}
}
......@@ -753,7 +753,7 @@ fn get_import_symbol_from_export(specifier: &ExportSpecifier) -> ImportedSymbol
ExportSpecifier::Named(ExportNamedSpecifier { orig, .. }) => {
ImportedSymbol::Symbol(orig_name(orig))
}
ExportSpecifier::Default(..) => ImportedSymbol::Symbol(js_word!("default")),
ExportSpecifier::Default(..) => ImportedSymbol::Symbol(atom!("default")),
ExportSpecifier::Namespace(..) => ImportedSymbol::Exports,
}
}
......@@ -22,7 +22,7 @@ use swc_core::{
common::Mark,
ecma::{
ast::{Id, Ident, Lit},
atoms::{Atom, JsWord},
atoms::Atom,
},
};
use turbo_rcstr::RcStr;
......@@ -275,7 +275,7 @@ impl Display for ConstantValue {
#[derive(Debug, Clone, Hash, PartialEq, Eq)]
pub struct ModuleValue {
pub module: JsWord,
pub module: Atom,
pub annotations: ImportAnnotations,
}
......@@ -500,9 +500,9 @@ pub enum JsValue {
/// A reference to an function argument.
/// (func_ident, arg_index)
Argument(u32, usize),
// TODO no predefined kinds, only JsWord
// TODO no predefined kinds, only Atom
/// A reference to a free variable.
FreeVar(JsWord),
FreeVar(Atom),
/// This is a reference to a imported module.
Module(ModuleValue),
}
......@@ -3799,9 +3799,9 @@ pub enum WellKnownFunctionKind {
RequireContextRequireKeys(RequireContextValue),
RequireContextRequireResolve(RequireContextValue),
Define,
FsReadMethod(JsWord),
FsReadMethod(Atom),
PathToFileUrl,
ChildProcessSpawnMethod(JsWord),
ChildProcessSpawnMethod(Atom),
ChildProcessFork,
OsArch,
OsPlatform,
......
......@@ -32,7 +32,7 @@ use regex::Regex;
use rustc_hash::{FxHashMap, FxHashSet};
use serde::{Deserialize, Serialize};
use swc_core::{
atoms::JsWord,
atoms::Atom,
common::{
comments::{CommentKind, Comments},
errors::{DiagnosticId, Handler, HANDLER},
......@@ -3176,7 +3176,7 @@ impl VisitAstPath for ModuleReferencesVisitor<'_> {
if export.src.is_none() {
for spec in export.specifiers.iter() {
fn to_string(name: &ModuleExportName) -> &JsWord {
fn to_string(name: &ModuleExportName) -> &Atom {
name.atom()
}
match spec {
......@@ -3445,7 +3445,7 @@ impl From<Vec<AstParentKind>> for AstPath {
}
}
pub static TURBOPACK_HELPER: Lazy<JsWord> = Lazy::new(|| "__turbopack-helper__".into());
pub static TURBOPACK_HELPER: Lazy<Atom> = Lazy::new(|| "__turbopack-helper__".into());
pub fn is_turbopack_helper_import(import: &ImportDecl) -> bool {
let annotations = ImportAnnotations::parse(import.with.as_deref());
......
......@@ -19,7 +19,7 @@ use swc_core::{
Lit, Module, ModuleDecl, ModuleExportName, ModuleItem, NamedExport, ObjectLit, Prop,
PropName, PropOrSpread, Stmt, Str, VarDecl, VarDeclKind, VarDeclarator,
},
atoms::JsWord,
atoms::Atom,
utils::{find_pat_ids, private_ident, quote_ident, ExprCtx, ExprExt},
},
};
......@@ -46,7 +46,7 @@ pub(crate) enum ItemId {
pub(crate) enum ItemIdGroupKind {
ModuleEvaluation,
/// `(local, export_name)``
Export(Id, JsWord),
Export(Id, Atom),
}
#[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Ord, Hash)]
......@@ -109,7 +109,7 @@ pub(crate) struct ItemData {
pub content: ModuleItem,
pub export: Option<JsWord>,
pub export: Option<Atom>,
/// This value denotes the module specifier of the [ImportDecl] that declares this
/// [ItemId].
......@@ -1642,7 +1642,7 @@ pub(crate) fn find_turbopack_part_id_in_asserts(asserts: &ObjectLit) -> Option<P
}
/// givin a number, return a base54 encoded string
/// `usize -> [a-zA-Z$_][a-zA-Z$_0-9]*`
pub(crate) fn encode_base54(init: &mut usize, skip_reserved: bool) -> JsWord {
pub(crate) fn encode_base54(init: &mut usize, skip_reserved: bool) -> Atom {
static BASE54_CHARS: &[u8; 64] =
b"abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789$_";
......@@ -1674,8 +1674,8 @@ pub(crate) fn encode_base54(init: &mut usize, skip_reserved: bool) -> JsWord {
let s = unsafe {
// Safety: We are only using ascii characters
// Safety: The stack memory for ret is alive while creating JsWord
JsWord::from(std::str::from_utf8_unchecked(&ret))
// Safety: The stack memory for ret is alive while creating Atom
Atom::from(std::str::from_utf8_unchecked(&ret))
};
if skip_reserved
......
......@@ -2,7 +2,7 @@ use anyhow::Error;
use rustc_hash::FxHashSet;
use swc_core::ecma::{
ast::{Module, ModuleDecl, ModuleItem},
atoms::JsWord,
atoms::Atom,
};
use super::{graph::find_turbopack_part_id_in_asserts, PartId};
......@@ -22,7 +22,7 @@ where
{
loader: L,
done: FxHashSet<(JsWord, u32)>,
done: FxHashSet<(Atom, u32)>,
}
impl<L> Merger<L>
......
......@@ -6,7 +6,7 @@ use swc_core::{
common::{comments::SingleThreadedComments, util::take::Take, Mark, SourceMap, SyntaxContext},
ecma::{
ast::{EsVersion, Id, Module},
atoms::JsWord,
atoms::Atom,
codegen::text_writer::JsWriter,
parser::{parse_file_as_module, EsSyntax},
visit::VisitMutWith,
......@@ -176,7 +176,7 @@ fn run(input: PathBuf) {
)
.unwrap();
let uri_of_module: JsWord = "entry.js".into();
let uri_of_module: Atom = "entry.js".into();
let mut describe =
|is_debug: bool, title: &str, entries: Vec<ItemIdGroupKind>, skip_parts: bool| {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment