Commit c79d2676 authored by Arunoda Susiripala's avatar Arunoda Susiripala Committed by Guillermo Rauch

Disable common chunks plugin in dev. (#1311)

With the on-demand-entires, this makes no sense.
parent e1babdfe
......@@ -85,6 +85,10 @@ export default async function createCompiler (dir, { dev = false, quiet = false,
name: 'commons',
filename: 'commons.js',
minChunks (module, count) {
// In the dev we use on-deman-entries.
// So, it makes no sense to use commonChunks with that.
if (dev) return false
// NOTE: it depends on the fact that the entry funtion is always called
// before applying CommonsChunkPlugin
return count >= minChunks
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment