Unverified Commit c7d6ab7f authored by Steven's avatar Steven Committed by GitHub

fix: `warnOnce()` lru (#73742)

We regressed in https://github.com/vercel/next.js/pull/73483 since the
LRU calculates the value based on the value, not the key (and we were
not setting the value).
parent c824c183
...@@ -77,12 +77,11 @@ export function trace(...message: any[]) { ...@@ -77,12 +77,11 @@ export function trace(...message: any[]) {
prefixedLog('trace', ...message) prefixedLog('trace', ...message)
} }
const warnOnceCache = new LRUCache<string>(10_000, (message) => message.length) const warnOnceCache = new LRUCache<string>(10_000, (value) => value.length)
export function warnOnce(...message: any[]) { export function warnOnce(...message: any[]) {
const key = message.join(' ') const key = message.join(' ')
if (!warnOnceCache.has(key)) { if (!warnOnceCache.has(key)) {
warnOnceCache.set(key) warnOnceCache.set(key, key)
warn(...message) warn(...message)
} }
} }
import { warnOnce } from 'next/dist/build/output/log'
describe('build/output/log', () => {
it('warnOnce', () => {
const original = console.warn
try {
const messages = []
console.warn = (m: any) => messages.push(m)
warnOnce('test')
expect(messages.length).toEqual(1)
warnOnce('test again')
expect(messages.length).toEqual(2)
warnOnce('test', 'more')
expect(messages.length).toEqual(3)
warnOnce('test')
expect(messages.length).toEqual(3)
warnOnce('test again')
expect(messages.length).toEqual(3)
warnOnce('test', 'more')
expect(messages.length).toEqual(3)
warnOnce('test', 'should', 'add', 'another')
expect(messages.length).toEqual(4)
} finally {
console.warn = original
}
})
})
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment