Unverified Commit c8924e36 authored by Benjamin Woodruff ‮'s avatar Benjamin Woodruff Committed by GitHub

Upgrade Corepack to 0.34.7 (#99959)

Needs a version bump for pnpm 12. We obviously can't apply the pnpm
lockfile to the corepack install, but pinning the version here should be
sufficient as corepack is zero-dependency (and makes a big deal about
that). We're using 0.34.7 because newer versions drop Node 20 support.
parent 25f37045
#!/bin/bash #!/bin/bash
set -euxo pipefail set -euxo pipefail
# pnpm 11+ needs corepack 0.34.5+, newer than what some Node.js images bundle.
# Pin 0.34.7 because corepack 0.35+ drops Node.js 20 support.
npm install -g corepack@0.34.7
corepack enable pnpm corepack enable pnpm
...@@ -23,6 +23,7 @@ concurrency: ...@@ -23,6 +23,7 @@ concurrency:
cancel-in-progress: true cancel-in-progress: true
env: env:
COREPACK_VERSION: 0.34.7
NAPI_CLI_VERSION: 3.7.2 NAPI_CLI_VERSION: 3.7.2
TURBO_VERSION: 2.11.7 TURBO_VERSION: 2.11.7
# --env-mode loose is a breaking change required with turbo 2.x since Strict mode is now the default # --env-mode loose is a breaking change required with turbo 2.x since Strict mode is now the default
...@@ -64,7 +65,7 @@ jobs: ...@@ -64,7 +65,7 @@ jobs:
package-manager-cache: false package-manager-cache: false
- name: Setup corepack - name: Setup corepack
run: | run: |
npm i -g corepack@0.31 npm i -g "corepack@${COREPACK_VERSION}"
corepack enable corepack enable
- name: Determine deploy target - name: Determine deploy target
# 'force-preview' performs a full preview build but only if acknowledged i.e. workflow_dispatch # 'force-preview' performs a full preview build but only if acknowledged i.e. workflow_dispatch
...@@ -160,7 +161,7 @@ jobs: ...@@ -160,7 +161,7 @@ jobs:
package-manager-cache: false package-manager-cache: false
- name: Setup corepack - name: Setup corepack
run: | run: |
npm i -g corepack@0.31 npm i -g "corepack@${COREPACK_VERSION}"
corepack enable corepack enable
- id: get-store-path - id: get-store-path
...@@ -293,7 +294,7 @@ jobs: ...@@ -293,7 +294,7 @@ jobs:
- name: Prepare corepack - name: Prepare corepack
if: ${{ matrix.os != 'windows' }} if: ${{ matrix.os != 'windows' }}
run: npm i -g corepack@0.31 run: npm i -g "corepack@${COREPACK_VERSION}"
- name: Setup corepack - name: Setup corepack
run: corepack enable run: corepack enable
...@@ -586,7 +587,7 @@ jobs: ...@@ -586,7 +587,7 @@ jobs:
package-manager-cache: false package-manager-cache: false
- name: Setup corepack - name: Setup corepack
run: | run: |
npm i -g corepack@0.31 npm i -g "corepack@${COREPACK_VERSION}"
corepack enable corepack enable
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
...@@ -641,7 +642,7 @@ jobs: ...@@ -641,7 +642,7 @@ jobs:
package-manager-cache: false package-manager-cache: false
- name: Setup corepack - name: Setup corepack
run: | run: |
npm i -g corepack@0.31 npm i -g "corepack@${COREPACK_VERSION}"
corepack enable corepack enable
# https://github.com/actions/virtual-environments/issues/1187 # https://github.com/actions/virtual-environments/issues/1187
......
...@@ -17,6 +17,7 @@ concurrency: ...@@ -17,6 +17,7 @@ concurrency:
# of that workflow. Environment variables are not automatically passed to # of that workflow. Environment variables are not automatically passed to
# reusable workflows. # reusable workflows.
env: env:
COREPACK_VERSION: 0.34.7
NODE_MAINTENANCE_VERSION: 20 NODE_MAINTENANCE_VERSION: 20
NODE_LTS_VERSION: 22 NODE_LTS_VERSION: 22
...@@ -187,7 +188,7 @@ jobs: ...@@ -187,7 +188,7 @@ jobs:
- name: Setup pnpm - name: Setup pnpm
run: | run: |
npm i -g corepack@0.31 npm i -g "corepack@${COREPACK_VERSION}"
corepack enable corepack enable
- name: Checkout - name: Checkout
...@@ -277,7 +278,7 @@ jobs: ...@@ -277,7 +278,7 @@ jobs:
package-manager-cache: false package-manager-cache: false
- name: Setup corepack - name: Setup corepack
run: | run: |
npm i -g corepack@0.31 npm i -g "corepack@${COREPACK_VERSION}"
corepack enable corepack enable
- name: 'Run link checker' - name: 'Run link checker'
run: node ./.github/actions/validate-docs-links/dist/index.js run: node ./.github/actions/validate-docs-links/dist/index.js
......
...@@ -266,12 +266,34 @@ jobs: ...@@ -266,12 +266,34 @@ jobs:
env: env:
NODE_VERSION: ${{ inputs.nodeVersion || env.NODE_LTS_VERSION }} NODE_VERSION: ${{ inputs.nodeVersion || env.NODE_LTS_VERSION }}
# Windows runner images include global Yarn, whose executable conflicts
# with the Yarn shim installed by Corepack (npm fails with EEXIST).
- name: Uninstall preinstalled Yarn
if: ${{ runner.os == 'Windows' }}
run: npm uninstall -g yarn
# The Corepack bundled with older Node.js releases predates pnpm 11+
# support (requires 0.34.5+). Pin 0.34.7 because 0.35+ drops Node.js 20 support.
- name: Setup corepack
run: |
npm i -g corepack@0.34.7
# fnm's bundled Corepack can precede npm's global prefix on Windows.
# Use the installed CLI to replace the shims beside the active Node.js.
corepack_cli="$(npm root -g)/corepack/dist/corepack.js"
node "$corepack_cli" enable --install-directory "$(dirname "$(which node)")"
if [[ "$RUNNER_OS" == "Windows" ]]; then
echo "$(npm prefix -g)" >> "$GITHUB_PATH"
fi
# Debug used Node.js version in a separate step to ensure the Node.js # Debug used Node.js version in a separate step to ensure the Node.js
# version is set for the entire job # version is set for the entire job
- name: Verify Node.js version - name: Verify Node.js version
run: | run: |
which node which node
node --version node --version
which corepack
corepack --version
which pnpm
pnpm --version pnpm --version
- run: corepack prepare --activate yarn@1.22.19 && npm i -g "@napi-rs/cli@${NAPI_CLI_VERSION}" - run: corepack prepare --activate yarn@1.22.19 && npm i -g "@napi-rs/cli@${NAPI_CLI_VERSION}"
......
...@@ -70,7 +70,9 @@ jobs: ...@@ -70,7 +70,9 @@ jobs:
package-manager-cache: false package-manager-cache: false
- name: Enable corepack - name: Enable corepack
run: corepack enable run: |
npm i -g corepack@0.34.7
corepack enable
- name: Setup pnpm - name: Setup pnpm
run: corepack prepare run: corepack prepare
......
...@@ -7,6 +7,9 @@ on: ...@@ -7,6 +7,9 @@ on:
- cron: '0 7 * * *' - cron: '0 7 * * *'
workflow_dispatch: workflow_dispatch:
env:
COREPACK_VERSION: 0.34.7
jobs: jobs:
update_dev_manifest: update_dev_manifest:
name: Update and upload Rspack development test manifest name: Update and upload Rspack development test manifest
...@@ -49,7 +52,7 @@ jobs: ...@@ -49,7 +52,7 @@ jobs:
- name: Setup corepack - name: Setup corepack
run: | run: |
npm i -g corepack@0.31 npm i -g "corepack@${COREPACK_VERSION}"
corepack enable corepack enable
- name: Install dependencies - name: Install dependencies
...@@ -112,7 +115,7 @@ jobs: ...@@ -112,7 +115,7 @@ jobs:
- name: Setup corepack - name: Setup corepack
run: | run: |
npm i -g corepack@0.31 npm i -g "corepack@${COREPACK_VERSION}"
corepack enable corepack enable
- name: Install dependencies - name: Install dependencies
......
...@@ -79,7 +79,7 @@ jobs: ...@@ -79,7 +79,7 @@ jobs:
- name: Setup corepack - name: Setup corepack
if: steps.precheck.outputs.should_evaluate == 'true' if: steps.precheck.outputs.should_evaluate == 'true'
run: | run: |
npm i -g corepack@0.31 npm i -g corepack@0.34.7
corepack enable corepack enable
- name: Install dependencies - name: Install dependencies
......
...@@ -80,7 +80,7 @@ jobs: ...@@ -80,7 +80,7 @@ jobs:
- name: Setup pnpm - name: Setup pnpm
run: | run: |
npm i -g corepack@0.31 npm i -g corepack@0.34.7
corepack enable corepack enable
- id: nextPackageInfo - id: nextPackageInfo
......
...@@ -116,7 +116,7 @@ jobs: ...@@ -116,7 +116,7 @@ jobs:
- name: Setup corepack - name: Setup corepack
if: steps.new-commits.outputs.has_new_commits == 'true' if: steps.new-commits.outputs.has_new_commits == 'true'
run: | run: |
npm i -g corepack@0.31 npm i -g corepack@0.34.7
corepack enable corepack enable
pnpm --version pnpm --version
......
...@@ -18,6 +18,7 @@ concurrency: ...@@ -18,6 +18,7 @@ concurrency:
cancel-in-progress: ${{ github.event_name == 'pull_request' }} cancel-in-progress: ${{ github.event_name == 'pull_request' }}
env: env:
COREPACK_VERSION: 0.34.7
CI: 1 CI: 1
RUST_LOG: 'off' RUST_LOG: 'off'
TURBO_TEAM: ${{ vars.TURBO_TEAM }} TURBO_TEAM: ${{ vars.TURBO_TEAM }}
...@@ -57,7 +58,7 @@ jobs: ...@@ -57,7 +58,7 @@ jobs:
- name: Install pnpm dependencies - name: Install pnpm dependencies
working-directory: turbopack/benchmark-apps working-directory: turbopack/benchmark-apps
run: | run: |
npm i -g corepack@0.31 npm i -g "corepack@${COREPACK_VERSION}"
corepack enable corepack enable
pnpm install --loglevel error pnpm install --loglevel error
...@@ -99,7 +100,7 @@ jobs: ...@@ -99,7 +100,7 @@ jobs:
- name: Install pnpm dependencies - name: Install pnpm dependencies
working-directory: turbopack/benchmark-apps working-directory: turbopack/benchmark-apps
run: | run: |
npm i -g corepack@0.31 npm i -g "corepack@${COREPACK_VERSION}"
corepack enable corepack enable
pnpm install --loglevel error pnpm install --loglevel error
......
...@@ -48,7 +48,7 @@ jobs: ...@@ -48,7 +48,7 @@ jobs:
- name: Setup corepack - name: Setup corepack
run: | run: |
npm i -g corepack@0.31 npm i -g corepack@0.34.7
corepack enable corepack enable
- name: Install dependencies - name: Install dependencies
......
...@@ -61,7 +61,7 @@ jobs: ...@@ -61,7 +61,7 @@ jobs:
- name: Setup corepack - name: Setup corepack
run: | run: |
npm i -g corepack@0.31 npm i -g corepack@0.34.7
corepack enable corepack enable
- name: Install dependencies - name: Install dependencies
......
...@@ -19,6 +19,11 @@ _You'll need a working node.js environment with pnpm._ ...@@ -19,6 +19,11 @@ _You'll need a working node.js environment with pnpm._
npm install -g pnpm@latest npm install -g pnpm@latest
``` ```
Corepack needs to be version 0.34.5 or newer to run pnpm 11+. Check with
`corepack --version`. Older versions are still bundled with some Node.js
releases and fail with `Cannot find module '.../bin/pnpm.cjs'`; upgrade with
`npm install -g corepack@latest`.
`pnpm` [respects the `packageManager` field in `package.json` by `pnpm` [respects the `packageManager` field in `package.json` by
default](https://pnpm.io/settings#managepackagemanagerversions), even when default](https://pnpm.io/settings#managepackagemanagerversions), even when
installed without Corepack. This ensures that pnpm behaves the same locally as installed without Corepack. This ensures that pnpm behaves the same locally as
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment