Don’t use native built-ins for additional bundler (#76577)
This opts us out of using the native built-in plugins for Rspack for now. The existing swc plugin we use for webpack does additional work beyond just swc transformation, including validating RSC components to make sure they don’t use React APIs unavailable in that context. In total, the native plugins result in a less than 20% performance gain which, while significant, isn’t necessary as we focus on correctness for now. If we decide the maintenance cost of maintaining multiple plugins in parity is worth the performance gain in the future, we can selectively re-enable some or all of these plugins. Test Plan: `pnpm test-dev-rspack test/development/acceptance/server-component-compiler-errors-in-pages.test.ts` no longer fails by missing the invalid React api messages.
Showing
| ... | @@ -77,7 +77,7 @@ | ... | @@ -77,7 +77,7 @@ |
| "storybook": "turbo run storybook", | "storybook": "turbo run storybook", | ||
| "build-storybook": "turbo run build-storybook", | "build-storybook": "turbo run build-storybook", | ||
| "test-storybook": "turbo run test-storybook", | "test-storybook": "turbo run test-storybook", | ||
| "with-rspack": "cross-env NEXT_RSPACK=1 NEXT_TEST_USE_RSPACK=1 BUILTIN_FLIGHT_CLIENT_ENTRY_PLUGIN=1 BUILTIN_APP_LOADER=1 BUILTIN_SWC_LOADER=1" | "with-rspack": "cross-env NEXT_RSPACK=1 NEXT_TEST_USE_RSPACK=1" | ||
| }, | }, | ||
| "devDependencies": { | "devDependencies": { | ||
| "@actions/core": "1.10.1", | "@actions/core": "1.10.1", | ||
| ... | ... |
Please
register
or
sign in
to comment