Unverified Commit ccad4853 authored by Niklas Mischkulnig's avatar Niklas Mischkulnig Committed by GitHub

Turbopack: improve cell order lint rule for TraitRef::cell (#90756)

parent 26244f58
...@@ -13,6 +13,7 @@ rule: ...@@ -13,6 +13,7 @@ rule:
- pattern: ResolvedVc::cell($_X) - pattern: ResolvedVc::cell($_X)
- pattern: Vc::cell($_X) - pattern: Vc::cell($_X)
- pattern: ReadRef::cell($_X) - pattern: ReadRef::cell($_X)
- pattern: TraitRef::cell($_X)
- inside: - inside:
stopBy: end stopBy: end
all: all:
......
...@@ -31,8 +31,9 @@ impl Version for EcmascriptDevChunkListVersion { ...@@ -31,8 +31,9 @@ impl Version for EcmascriptDevChunkListVersion {
let mut by_path = self let mut by_path = self
.by_path .by_path
.iter() .iter()
.map(|(path, version)| (path, TraitRef::cell(version.clone())))
.map(|(path, version)| async move { .map(|(path, version)| async move {
let id = TraitRef::cell(version.clone()).id().owned().await?; let id = version.id().owned().await?;
Ok((path, id)) Ok((path, id))
}) })
.try_join() .try_join()
...@@ -44,9 +45,7 @@ impl Version for EcmascriptDevChunkListVersion { ...@@ -44,9 +45,7 @@ impl Version for EcmascriptDevChunkListVersion {
let mut by_merger = self let mut by_merger = self
.by_merger .by_merger
.iter() .iter()
.map(|(_merger, version)| async move { .map(|(_merger, version)| TraitRef::cell(version.clone()).id().owned())
TraitRef::cell(version.clone()).id().owned().await
})
.try_join() .try_join()
.await?; .await?;
by_merger.sort(); by_merger.sort();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment