Unverified Commit d0be1d2c authored by Hendrik Liebau's avatar Hendrik Liebau Committed by GitHub

Show numerical values for configured experimental features (#74692)

Based on #74691 we can now also show numerical values for configured experimental features:

<img width="393" alt="numbers" src="https://github.com/user-attachments/assets/77309353-1319-4806-89e2-0ba1841e341a" />
parent b27c722a
...@@ -1270,6 +1270,7 @@ export default async function loadConfig( ...@@ -1270,6 +1270,7 @@ export default async function loadConfig(
export type ConfiguredExperimentalFeature = export type ConfiguredExperimentalFeature =
| { name: keyof ExperimentalConfig; type: 'boolean'; value: boolean } | { name: keyof ExperimentalConfig; type: 'boolean'; value: boolean }
| { name: keyof ExperimentalConfig; type: 'number'; value: number }
| { name: keyof ExperimentalConfig; type: 'other' } | { name: keyof ExperimentalConfig; type: 'other' }
export function getConfiguredExperimentalFeatures( export function getConfiguredExperimentalFeatures(
...@@ -1296,7 +1297,9 @@ export function getConfiguredExperimentalFeatures( ...@@ -1296,7 +1297,9 @@ export function getConfiguredExperimentalFeatures(
configuredExperimentalFeatures.push( configuredExperimentalFeatures.push(
typeof value === 'boolean' typeof value === 'boolean'
? { name, type: 'boolean', value } ? { name, type: 'boolean', value }
: { name, type: 'other' } : typeof value === 'number'
? { name, type: 'number', value }
: { name, type: 'other' }
) )
} }
} }
......
...@@ -47,7 +47,9 @@ export function logStartInfo({ ...@@ -47,7 +47,9 @@ export function logStartInfo({
: bold('⨯') : bold('⨯')
: '·' : '·'
Log.bootstrap(` ${symbol} ${exp.name}`) const suffix = exp.type === 'number' ? `: ${exp.value}` : ''
Log.bootstrap(` ${symbol} ${exp.name}${suffix}`)
} }
/* indicate if there are more than the maximum shown no. flags */ /* indicate if there are more than the maximum shown no. flags */
if (experimentalFeatures.length > maxExperimentalFeatures) { if (experimentalFeatures.length > maxExperimentalFeatures) {
......
module.exports = {
experimental: {
staticGenerationRetryCount: 2,
staticGenerationMaxConcurrency: 4,
},
}
...@@ -129,6 +129,20 @@ describe('Config Experimental Warning', () => { ...@@ -129,6 +129,20 @@ describe('Config Experimental Warning', () => {
expect(stdout).toMatch(' ⨯ prerenderEarlyExit') expect(stdout).toMatch(' ⨯ prerenderEarlyExit')
}) })
it('should show the configured value for numerical features', async () => {
configFile.write(`
module.exports = {
experimental: {
cpus: 2
}
}
`)
const stdout = await collectStdoutFromDev(appDir)
expect(stdout).toMatch(experimentalHeader)
expect(stdout).toMatch(' · cpus: 2')
})
it('should show warning with config from object with experimental and multiple keys', async () => { it('should show warning with config from object with experimental and multiple keys', async () => {
configFile.write(` configFile.write(`
module.exports = { module.exports = {
...@@ -184,7 +198,7 @@ describe('Config Experimental Warning', () => { ...@@ -184,7 +198,7 @@ describe('Config Experimental Warning', () => {
`) `)
const stdout = await collectStdoutFromBuild(appDir) const stdout = await collectStdoutFromBuild(appDir)
expect(stdout).toMatch(experimentalHeader) expect(stdout).toMatch(experimentalHeader)
expect(stdout).toMatch(' · cpus') expect(stdout).toMatch(' · cpus: 2')
expect(stdout).toMatch(' ✓ workerThreads') expect(stdout).toMatch(' ✓ workerThreads')
expect(stdout).toMatch(' ✓ scrollRestoration') expect(stdout).toMatch(' ✓ scrollRestoration')
expect(stdout).toMatch(' ⨯ prerenderEarlyExit') expect(stdout).toMatch(' ⨯ prerenderEarlyExit')
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment