Unverified Commit d381d581 authored by Shu Ding's avatar Shu Ding Committed by GitHub

Fix types of cookies() (#50052)

As explained in the comments, the `cookies()` API is a mix of request and response cookies. For `.get()` methods, we want to return the request cookie if it exists. For mutative methods like `.set()`, we return the response cookie type instead.
fix #50049
fix NEXT-1211
parent 26ea9c63
...@@ -21,11 +21,18 @@ export class ReadonlyRequestCookiesError extends Error { ...@@ -21,11 +21,18 @@ export class ReadonlyRequestCookiesError extends Error {
} }
} }
export type ReadonlyRequestCookies = Omit<RequestCookies, 'clear' | 'delete'> // The `cookies()` API is a mix of request and response cookies. For `.get()` methods,
// we want to return the request cookie if it exists. For mutative methods like `.set()`,
// we want to return the response cookie.
export type ReadonlyRequestCookies = Omit<
RequestCookies,
'set' | 'clear' | 'delete'
> &
Pick<ResponseCookies, 'set' | 'delete'>
export class RequestCookiesAdapter { export class RequestCookiesAdapter {
public static seal(cookies: RequestCookies): ReadonlyRequestCookies { public static seal(cookies: RequestCookies): ReadonlyRequestCookies {
return new Proxy(cookies, { return new Proxy(cookies as any, {
get(target, prop, receiver) { get(target, prop, receiver) {
switch (prop) { switch (prop) {
case 'clear': case 'clear':
......
...@@ -3,6 +3,14 @@ ...@@ -3,6 +3,14 @@
import { headers, cookies } from 'next/headers' import { headers, cookies } from 'next/headers'
import { redirect } from 'next/navigation' import { redirect } from 'next/navigation'
export async function setCookieWithMaxAge() {
cookies().set({
name: 'foo',
value: 'bar',
maxAge: 1000,
})
}
export async function getCookie(name) { export async function getCookie(name) {
return cookies().get(name) return cookies().get(name)
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment