Unverified Commit d78bb6fe authored by Tobias Koppers's avatar Tobias Koppers Committed by GitHub

upgrade to typescript 4.4.3 (#29112)

Co-authored-by: 's avatarkodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
parent cefd9cf2
......@@ -138,7 +138,7 @@
"tailwindcss": "1.1.3",
"taskr": "1.1.0",
"tree-kill": "1.2.2",
"typescript": "4.3.4",
"typescript": "4.4.3",
"wait-port": "0.2.2",
"web-streams-polyfill": "2.1.1",
"webpack-bundle-analyzer": "4.3.0",
......
......@@ -44,7 +44,7 @@ export async function createApp({
try {
repoUrl = new URL(example)
} catch (error) {
} catch (error: any) {
if (error.code !== 'ERR_INVALID_URL') {
console.error(error)
process.exit(1)
......@@ -158,7 +158,16 @@ export async function createApp({
})
}
} catch (reason) {
throw new DownloadError(reason)
function isErrorLike(err: unknown): err is { message: string } {
return (
typeof err === 'object' &&
err !== null &&
typeof (err as { message?: unknown }).message === 'string'
)
}
throw new DownloadError(
isErrorLike(reason) ? reason.message : reason + ''
)
}
// Copy our default `.gitignore` if the application did not provide one
const ignorePath = path.join(root, '.gitignore')
......
......@@ -43,7 +43,6 @@
"prompts": "2.1.0",
"rimraf": "3.0.0",
"tar": "4.4.10",
"typescript": "4.3.4",
"update-check": "1.5.4",
"validate-npm-package-name": "3.0.0"
},
......
......@@ -106,7 +106,7 @@ export function loadEnvConfig(
path: envFile,
contents,
})
} catch (err) {
} catch (err: any) {
if (err.code !== 'ENOENT') {
log.error(`Failed to load env from ${envFile}`, err)
}
......
......@@ -90,6 +90,7 @@ import { writeBuildId } from './write-build-id'
import { normalizeLocalePath } from '../shared/lib/i18n/normalize-locale-path'
import { isWebpack5 } from 'next/dist/compiled/webpack/webpack'
import { NextConfigComplete } from '../server/config-shared'
import isError from '../lib/is-error'
export type SsgRoute = {
initialRevalidateSeconds: number | false
......@@ -463,7 +464,7 @@ export default async function build(
await promises.mkdir(distDir, { recursive: true })
return true
} catch (err) {
if (err.code === 'EPERM') {
if (isError(err) && err.code === 'EPERM') {
return false
}
throw err
......@@ -927,7 +928,8 @@ export default async function build(
)
}
} catch (err) {
if (err.message !== 'INVALID_DEFAULT_EXPORT') throw err
if (isError(err) && err.message !== 'INVALID_DEFAULT_EXPORT')
throw err
invalidPages.add(page)
}
}
......
......@@ -34,6 +34,7 @@ import { loadComponents } from '../server/load-components'
import { trace } from '../trace'
import { setHttpAgentOptions } from '../server/config'
import { NextConfigComplete } from '../server/config-shared'
import isError from '../lib/is-error'
const fileGzipStats: { [k: string]: Promise<number> | undefined } = {}
const fsStatGzip = (file: string) => {
......@@ -942,7 +943,7 @@ export async function isPageStatic(
traceExcludes: config.unstable_excludeFiles || [],
}
} catch (err) {
if (err.code === 'MODULE_NOT_FOUND') return {}
if (isError(err) && err.code === 'MODULE_NOT_FOUND') return {}
throw err
}
})
......
......@@ -48,6 +48,7 @@ import { WellKnownErrorsPlugin } from './webpack/plugins/wellknown-errors-plugin
import { regexLikeCss } from './webpack/config/blocks/css'
import { CopyFilePlugin } from './webpack/plugins/copy-file-plugin'
import type { Span } from '../trace'
import isError from '../lib/is-error'
type ExcludesFalse = <T>(x: T | false) => x is T
......@@ -74,9 +75,15 @@ function parseJsonFile(filePath: string) {
try {
return JSON5.parse(contents)
} catch (err) {
if (!isError(err)) throw err
const codeFrame = codeFrameColumns(
String(contents),
{ start: { line: err.lineNumber, column: err.columnNumber } },
{
start: {
line: (err as Error & { lineNumber?: number }).lineNumber || 0,
column: (err as Error & { columnNumber?: number }).columnNumber || 0,
},
},
{ message: err.message, highlightCode: true }
)
throw new Error(`Failed to parse "${filePath}":\n${codeFrame}`)
......
......@@ -12,6 +12,7 @@ import { getRedirectStatus } from '../../../../lib/load-custom-routes'
import getRouteNoAssetPath from '../../../../shared/lib/router/utils/get-route-from-asset-path'
import { PERMANENT_REDIRECT_STATUS } from '../../../../shared/lib/constants'
import RenderResult from '../../../../server/render-result'
import isError from '../../../../lib/is-error'
export function getPageHandler(ctx: ServerlessHandlerCtx) {
const {
......@@ -406,7 +407,7 @@ export function getPageHandler(ctx: ServerlessHandlerCtx) {
parsedUrl = parseUrl(req.url!, true)
}
if (err.code === 'ENOENT') {
if (isError(err) && err.code === 'ENOENT') {
res.statusCode = 404
} else if (err instanceof DecodeError) {
res.statusCode = 400
......
......@@ -8,6 +8,7 @@ import {
import { TRACE_OUTPUT_VERSION } from '../../../shared/lib/constants'
import { spans } from './profiling-plugin'
import { Span } from '../../../trace'
import isError from '../../../lib/is-error'
const PLUGIN_NAME = 'TraceEntryPointsPlugin'
const TRACE_IGNORES = [
......@@ -163,7 +164,10 @@ export class TraceEntryPointsPlugin implements webpack.Plugin {
try {
return compilation.inputFileSystem.readFileSync(path)
} catch (e) {
if (e.code === 'ENOENT' || e.code === 'EISDIR') {
if (
isError(e) &&
(e.code === 'ENOENT' || e.code === 'EISDIR')
) {
return null
}
throw e
......@@ -176,13 +180,14 @@ export class TraceEntryPointsPlugin implements webpack.Plugin {
return compilation.inputFileSystem.readlinkSync(path)
} catch (e) {
if (
e.code !== 'EINVAL' &&
e.code !== 'ENOENT' &&
e.code !== 'UNKNOWN'
isError(e) &&
(e.code === 'EINVAL' ||
e.code === 'ENOENT' ||
e.code === 'UNKNOWN')
) {
throw e
return null
}
return null
throw e
}
// })
}
......@@ -191,7 +196,7 @@ export class TraceEntryPointsPlugin implements webpack.Plugin {
try {
return compilation.inputFileSystem.statSync(path)
} catch (e) {
if (e.code === 'ENOENT') {
if (isError(e) && e.code === 'ENOENT') {
return null
}
throw e
......
......@@ -2,6 +2,7 @@ import { webpack } from 'next/dist/compiled/webpack/webpack'
import { isWebpack5 } from 'next/dist/compiled/webpack/webpack'
import { realpathSync } from 'fs'
import path from 'path'
import isError from '../../../lib/is-error'
const originModules = [
require.resolve('../../../server/require'),
......@@ -12,7 +13,7 @@ function deleteCache(filePath: string) {
try {
filePath = realpathSync(filePath)
} catch (e) {
if (e.code !== 'ENOENT') throw e
if (isError(e) && e.code !== 'ENOENT') throw e
}
const module = require.cache[filePath]
if (module) {
......
......@@ -6,7 +6,7 @@ const chalk = new Chalk.constructor({ enabled: true })
export function getBabelError(
fileName: string,
err: Error & {
code?: 'BABEL_PARSE_ERROR'
code?: string | number
loc?: { line: number; column: number }
}
): SimpleWebpackError | false {
......
......@@ -6,6 +6,7 @@ import { getCssError } from './parseCss'
import { getScssError } from './parseScss'
import { getNotFoundError } from './parseNotFoundError'
import { SimpleWebpackError } from './simpleWebpackError'
import isError from '../../../../lib/is-error'
function getFileData(
compilation: webpack.compilation.Compilation,
......@@ -50,7 +51,7 @@ export async function getModuleBuildError(
(input?.name === 'ModuleBuildError' ||
input?.name === 'ModuleNotFoundError') &&
Boolean(input.module) &&
input.error instanceof Error
isError(input.error)
)
) {
return false
......
......@@ -6,6 +6,7 @@ import * as Log from '../build/output/log'
import { cliCommand } from '../bin/next'
import build from '../build'
import { printAndExit } from '../server/lib/utils'
import isError from '../lib/is-error'
const nextBuild: cliCommand = (argv) => {
const validArgs: arg.Spec = {
......@@ -23,7 +24,7 @@ const nextBuild: cliCommand = (argv) => {
try {
args = arg(validArgs, { argv })
} catch (error) {
if (error.code === 'ARG_UNKNOWN_OPTION') {
if (isError(error) && error.code === 'ARG_UNKNOWN_OPTION') {
return printAndExit(error.message, 1)
}
throw error
......
......@@ -7,6 +7,7 @@ import { printAndExit } from '../server/lib/utils'
import * as Log from '../build/output/log'
import { startedDevelopmentServer } from '../build/output'
import { cliCommand } from '../bin/next'
import isError from '../lib/is-error'
const nextDev: cliCommand = (argv) => {
const validArgs: arg.Spec = {
......@@ -24,7 +25,7 @@ const nextDev: cliCommand = (argv) => {
try {
args = arg(validArgs, { argv })
} catch (error) {
if (error.code === 'ARG_UNKNOWN_OPTION') {
if (isError(error) && error.code === 'ARG_UNKNOWN_OPTION') {
return printAndExit(error.message, 1)
}
throw error
......
......@@ -6,6 +6,7 @@ import exportApp from '../export'
import { printAndExit } from '../server/lib/utils'
import { cliCommand } from '../bin/next'
import { trace } from '../trace'
import isError from '../lib/is-error'
const nextExport: cliCommand = (argv) => {
const nextExportCliSpan = trace('next-export-cli')
......@@ -25,7 +26,7 @@ const nextExport: cliCommand = (argv) => {
try {
args = arg(validArgs, { argv })
} catch (error) {
if (error.code === 'ARG_UNKNOWN_OPTION') {
if (isError(error) && error.code === 'ARG_UNKNOWN_OPTION') {
return printAndExit(error.message, 1)
}
throw error
......
......@@ -13,6 +13,7 @@ import loadConfig from '../server/config'
import { PHASE_PRODUCTION_BUILD } from '../shared/lib/constants'
import { eventLintCheckCompleted } from '../telemetry/events'
import { CompileError } from '../lib/compile-error'
import isError from '../lib/is-error'
const eslintOptions = (args: arg.Spec, defaultCacheLocation: string) => ({
overrideConfigFile: args['--config'] || null,
......@@ -77,7 +78,7 @@ const nextLint: cliCommand = async (argv) => {
try {
args = arg({ ...validArgs, ...validEslintArgs }, { argv })
} catch (error) {
if (error.code === 'ARG_UNKNOWN_OPTION') {
if (isError(error) && error.code === 'ARG_UNKNOWN_OPTION') {
return printAndExit(error.message, 1)
}
throw error
......
......@@ -6,6 +6,7 @@ import startServer from '../server/lib/start-server'
import { printAndExit } from '../server/lib/utils'
import { cliCommand } from '../bin/next'
import * as Log from '../build/output/log'
import isError from '../lib/is-error'
const nextStart: cliCommand = (argv) => {
const validArgs: arg.Spec = {
......@@ -23,7 +24,7 @@ const nextStart: cliCommand = (argv) => {
try {
args = arg(validArgs, { argv })
} catch (error) {
if (error.code === 'ARG_UNKNOWN_OPTION') {
if (isError(error) && error.code === 'ARG_UNKNOWN_OPTION') {
return printAndExit(error.message, 1)
}
throw error
......
......@@ -4,6 +4,7 @@ import arg from 'next/dist/compiled/arg/index.js'
import { printAndExit } from '../server/lib/utils'
import { cliCommand } from '../bin/next'
import { Telemetry } from '../telemetry/storage'
import isError from '../lib/is-error'
const nextTelemetry: cliCommand = (argv) => {
const validArgs: arg.Spec = {
......@@ -18,7 +19,7 @@ const nextTelemetry: cliCommand = (argv) => {
try {
args = arg(validArgs, { argv })
} catch (error) {
if (error.code === 'ARG_UNKNOWN_OPTION') {
if (isError(error) && error.code === 'ARG_UNKNOWN_OPTION') {
return printAndExit(error.message, 1)
}
throw error
......
......@@ -26,6 +26,7 @@ import PageLoader, { StyleSheetTuple } from './page-loader'
import measureWebVitals from './performance-relayer'
import { RouteAnnouncer } from './route-announcer'
import { createRouter, makePublicRouterInstance } from './router'
import isError from '../lib/is-error'
/// <reference types="react-dom/experimental" />
......@@ -326,7 +327,7 @@ export async function initNext(opts: { webpackHMR?: any } = {}) {
}
} catch (error) {
// This catches errors like throwing in the top level of a module
initialErr = error
initialErr = isError(error) ? error : new Error(error + '')
}
if (process.env.NODE_ENV === 'development') {
......@@ -343,7 +344,7 @@ export async function initNext(opts: { webpackHMR?: any } = {}) {
// not overridden when we re-throw it below.
throw new Error(initialErr!.message)
} catch (e) {
error = e
error = e as Error
}
error.name = initialErr!.name
......@@ -417,9 +418,10 @@ export async function render(renderingProps: RenderRouteInfo): Promise<void> {
try {
await doRender(renderingProps)
} catch (renderErr) {
} catch (err) {
const renderErr = err instanceof Error ? err : new Error(err + '')
// bubble up cancelation errors
if (renderErr.cancelled) {
if ((renderErr as Error & { cancelled?: boolean }).cancelled) {
throw renderErr
}
......
type RequestIdleCallbackHandle = any
type RequestIdleCallbackOptions = {
timeout: number
}
type RequestIdleCallbackDeadline = {
readonly didTimeout: boolean
timeRemaining: () => number
}
declare global {
interface Window {
requestIdleCallback: (
callback: (deadline: RequestIdleCallbackDeadline) => void,
opts?: RequestIdleCallbackOptions
) => RequestIdleCallbackHandle
cancelIdleCallback: (id: RequestIdleCallbackHandle) => void
}
}
export const requestIdleCallback =
(typeof self !== 'undefined' &&
self.requestIdleCallback &&
self.requestIdleCallback.bind(window)) ||
function (
cb: (deadline: RequestIdleCallbackDeadline) => void
): NodeJS.Timeout {
function (cb: IdleRequestCallback): number {
let start = Date.now()
return setTimeout(function () {
cb({
......@@ -32,13 +11,13 @@ export const requestIdleCallback =
return Math.max(0, 50 - (Date.now() - start))
},
})
}, 1)
}, 1) as unknown as number
}
export const cancelIdleCallback =
(typeof self !== 'undefined' &&
self.cancelIdleCallback &&
self.cancelIdleCallback.bind(window)) ||
function (id: RequestIdleCallbackHandle) {
function (id: number) {
return clearTimeout(id)
}
......@@ -3,6 +3,7 @@ import React from 'react'
import Router from '../shared/lib/router/router'
import type { NextRouter } from '../shared/lib/router/router'
import { RouterContext } from '../shared/lib/router-context'
import isError from '../lib/is-error'
type ClassArguments<T> = T extends new (...args: infer U) => any ? U : any
......@@ -107,7 +108,9 @@ routerEvents.forEach((event) => {
_singletonRouter[eventField](...args)
} catch (err) {
console.error(`Error when running the Router event: ${eventField}`)
console.error(`${err.message}\n${err.stack}`)
console.error(
isError(err) ? `${err.message}\n${err.stack}` : err + ''
)
}
}
})
......
......@@ -21,6 +21,7 @@ import { isInAmpMode } from '../shared/lib/amp'
import { NextConfigComplete } from '../server/config-shared'
import { setHttpAgentOptions } from '../server/config'
import RenderResult from '../server/render-result'
import isError from '../lib/is-error'
const envConfig = require('../shared/lib/runtime-config')
......@@ -500,7 +501,7 @@ export default async function exportPage({
} catch (error) {
console.error(
`\nError occurred prerendering page "${path}". Read more: https://nextjs.org/docs/messages/prerender-error\n` +
error.stack
(isError(error) ? error.stack : error)
)
results.error = true
}
......
......@@ -18,6 +18,7 @@ import { isYarn } from '../is-yarn'
import * as Log from '../../build/output/log'
import { EventLintCheckCompleted } from '../../telemetry/events/build'
import isError from '../is-error'
type Config = {
plugins: string[]
......@@ -90,7 +91,7 @@ async function lint(
`ESLint must be installed${
lintDuringBuild ? ' in order to run during builds:' : ':'
} ${chalk.bold.cyan(
isYarn(baseDir)
(await isYarn(baseDir))
? 'yarn add --dev eslint'
: 'npm install --save-dev eslint'
)}`
......@@ -211,11 +212,13 @@ async function lint(
} catch (err) {
if (lintDuringBuild) {
Log.error(
`ESLint: ${err.message ? err.message.replace(/\n/g, ' ') : err}`
`ESLint: ${
isError(err) && err.message ? err.message.replace(/\n/g, ' ') : err
}`
)
return null
} else {
throw new Error(err)
throw new Error(err + '')
}
}
}
......
import { constants, promises } from 'fs'
import isError from './is-error'
export async function fileExists(
fileName: string,
......@@ -16,7 +17,10 @@ export async function fileExists(
}
return true
} catch (err) {
if (err.code === 'ENOENT' || err.code === 'ENAMETOOLONG') {
if (
isError(err) &&
(err.code === 'ENOENT' || err.code === 'ENAMETOOLONG')
) {
return false
}
throw err
......
// We allow some additional attached properties for Errors
interface NextError extends Error {
type?: string
page?: string
code?: string | number
cancelled?: boolean
}
export default function isError(err: unknown): err is NextError {
return (
typeof err === 'object' && err !== null && 'name' in err && 'message' in err
)
}
......@@ -7,6 +7,7 @@ import {
PERMANENT_REDIRECT_STATUS,
TEMPORARY_REDIRECT_STATUS,
} from '../shared/lib/constants'
import isError from './is-error'
export type RouteHas =
| {
......@@ -156,9 +157,9 @@ function tryParsePath(route: string, handleUrl?: boolean): ParseAttemptResult {
result.regexStr = regex.source
} catch (err) {
// If there is an error show our error link but still show original error or a formatted one if we can
const errMatches = err.message.match(/at (\d{0,})/)
let errMatches
if (errMatches) {
if (isError(err) && (errMatches = err.message.match(/at (\d{0,})/))) {
const position = parseInt(errMatches[1], 10)
console.error(
`\nError parsing \`${route}\` ` +
......
import path from 'path'
import { promises, constants, Dirent, Stats } from 'fs'
import { Sema } from 'next/dist/compiled/async-sema'
import isError from './is-error'
const COPYFILE_EXCL = constants.COPYFILE_EXCL
......@@ -49,7 +50,7 @@ export async function recursiveCopy(
await promises.mkdir(target)
} catch (err) {
// do not throw `folder already exists` errors
if (err.code !== 'EEXIST') {
if (isError(err) && err.code !== 'EEXIST') {
throw err
}
}
......
import { Dirent, promises } from 'fs'
import { join } from 'path'
import { promisify } from 'util'
import isError from './is-error'
const sleep = promisify(setTimeout)
......@@ -8,18 +9,19 @@ const unlinkFile = async (p: string, t = 1): Promise<void> => {
try {
await promises.unlink(p)
} catch (e) {
const code = isError(e) && e.code
if (
(e.code === 'EBUSY' ||
e.code === 'ENOTEMPTY' ||
e.code === 'EPERM' ||
e.code === 'EMFILE') &&
(code === 'EBUSY' ||
code === 'ENOTEMPTY' ||
code === 'EPERM' ||
code === 'EMFILE') &&
t < 3
) {
await sleep(t * 100)
return unlinkFile(p, t++)
}
if (e.code === 'ENOENT') {
if (code === 'ENOENT') {
return
}
......@@ -43,7 +45,7 @@ export async function recursiveDelete(
try {
result = await promises.readdir(dir, { withFileTypes: true })
} catch (e) {
if (e.code === 'ENOENT') {
if (isError(e) && e.code === 'ENOENT') {
return
}
throw e
......
......@@ -3,6 +3,7 @@ import os from 'os'
import path from 'path'
import { FatalError } from '../fatal-error'
import isError from '../is-error'
export async function getTypeScriptConfiguration(
ts: typeof import('typescript'),
......@@ -54,8 +55,8 @@ export async function getTypeScriptConfiguration(
return result
} catch (err) {
if (err?.name === 'SyntaxError') {
const reason = '\n' + (err?.message ?? '')
if (isError(err) && err.name === 'SyntaxError') {
const reason = '\n' + (err.message ?? '')
throw new FatalError(
chalk.red.bold(
'Could not parse',
......
......@@ -5,7 +5,7 @@ import { MissingDependency } from '../has-necessary-dependencies'
import { FatalError } from '../fatal-error'
import { isYarn } from '../is-yarn'
export function missingDepsError(
export async function missingDepsError(
dir: string,
missingPackages: MissingDependency[]
) {
......@@ -28,7 +28,7 @@ export function missingDepsError(
chalk.bold(`Please install ${chalk.bold(packagesHuman)} by running:`) +
'\n\n' +
`\t${chalk.bold.cyan(
(isYarn(dir) ? 'yarn add --dev' : 'npm install --save-dev') +
((await isYarn(dir)) ? 'yarn add --dev' : 'npm install --save-dev') +
' ' +
packagesCli
)}` +
......
......@@ -6,6 +6,7 @@ import { ESLINT_DEFAULT_DIRS } from './constants'
import { Telemetry } from '../telemetry/storage'
import { eventLintCheckCompleted } from '../telemetry/events'
import { CompileError } from './compile-error'
import isError from './is-error'
export async function verifyAndLint(
dir: string,
......@@ -62,13 +63,15 @@ export async function verifyAndLint(
lintWorkers.end()
} catch (err) {
if (err.type === 'CompileError' || err instanceof CompileError) {
console.error(chalk.red('\nFailed to compile.'))
console.error(err.message)
process.exit(1)
} else if (err.type === 'FatalError') {
console.error(err.message)
process.exit(1)
if (isError(err)) {
if (err.type === 'CompileError' || err instanceof CompileError) {
console.error(chalk.red('\nFailed to compile.'))
console.error(err.message)
process.exit(1)
} else if (err.type === 'FatalError') {
console.error(err.message)
process.exit(1)
}
}
throw err
}
......
......@@ -44,7 +44,7 @@ export async function verifyTypeScriptSetup(
)
if (deps.missing?.length > 0) {
missingDepsError(dir, deps.missing)
await missingDepsError(dir, deps.missing)
}
// Load TypeScript after we're sure it exists:
......
......@@ -247,7 +247,6 @@
"taskr": "1.1.0",
"terser": "5.7.1",
"text-table": "0.2.0",
"typescript": "4.3.4",
"unistore": "3.4.1",
"web-vitals": "2.1.0",
"webpack": "4.44.1",
......
......@@ -14,6 +14,7 @@ import { BuildManifest, getPageFiles } from '../server/get-page-files'
import { cleanAmpPath } from '../server/utils'
import { htmlEscapeJsonString } from '../server/htmlescape'
import Script, { ScriptProps } from '../client/script'
import isError from '../lib/is-error'
export { DocumentContext, DocumentInitialProps, DocumentProps }
......@@ -756,7 +757,7 @@ export class NextScript extends Component<OriginProps> {
const data = JSON.stringify(__NEXT_DATA__)
return htmlEscapeJsonString(data)
} catch (err) {
if (err.message.indexOf('circular structure')) {
if (isError(err) && err.message.indexOf('circular structure')) {
throw new Error(
`Circular structure in "getInitialProps" result of page "${__NEXT_DATA__.page}". https://nextjs.org/docs/messages/circular-structure`
)
......
......@@ -9,6 +9,7 @@ import { decryptWithSecret, encryptWithSecret } from './crypto-utils'
import { interopDefault } from './load-components'
import { sendEtagResponse } from './send-payload'
import generateETag from 'etag'
import isError from '../lib/is-error'
export type NextApiRequestCookies = { [key: string]: string }
export type NextApiRequestQuery = { [key: string]: string | string[] }
......@@ -120,7 +121,7 @@ export async function apiResolver(
sendError(apiRes, err.statusCode, err.message)
} else {
if (dev) {
if (err) {
if (isError(err)) {
err.page = page
}
throw err
......@@ -157,7 +158,7 @@ export async function parseBody(
try {
buffer = await getRawBody(req, { encoding, limit })
} catch (e) {
if (e.type === 'entity.too.large') {
if (isError(e) && e.type === 'entity.too.large') {
throw new ApiError(413, `Body exceeded ${limit} limit`)
} else {
throw new ApiError(400, 'Invalid body')
......
......@@ -28,6 +28,7 @@ import { NextConfigComplete } from '../config-shared'
import { CustomRoutes } from '../../lib/load-custom-routes'
import { DecodeError } from '../../shared/lib/utils'
import { Span, trace } from '../../trace'
import isError from '../../lib/is-error'
export async function renderScriptError(
res: ServerResponse,
......@@ -227,7 +228,10 @@ export default class HotReloader {
try {
await this.ensurePage(page)
} catch (error) {
await renderScriptError(pageBundleRes, error)
await renderScriptError(
pageBundleRes,
isError(error) ? error : new Error(error + '')
)
return { finished: true }
}
......
......@@ -54,6 +54,7 @@ import {
getSourceById,
} from '@next/react-dev-overlay/lib/middleware'
import * as Log from '../../build/output/log'
import isError from '../../lib/is-error'
// Load ReactDevOverlay only when needed
let ReactDevOverlayImpl: React.FunctionComponent
......@@ -449,12 +450,13 @@ export default class DevServer extends Server {
}
try {
return await super.run(req, res, parsedUrl)
} catch (err) {
} catch (error) {
res.statusCode = 500
const err = isError(error) ? error : error ? new Error(error + '') : null
try {
this.logErrorWithOriginalStack(err).catch(() => {})
return await this.renderError(err, req, res, pathname!, {
__NEXT_PAGE: err?.page || pathname,
__NEXT_PAGE: (isError(err) && err.page) || pathname || '',
})
} catch (internalErr) {
console.error(internalErr)
......@@ -464,15 +466,14 @@ export default class DevServer extends Server {
}
private async logErrorWithOriginalStack(
possibleError?: any,
err?: unknown,
type?: 'unhandledRejection' | 'uncaughtException'
) {
let usedOriginalStack = false
if (possibleError?.name && possibleError?.stack && possibleError?.message) {
const err: Error & { stack: string } = possibleError
if (isError(err) && err.name && err.stack && err.message) {
try {
const frames = parseStack(err.stack)
const frames = parseStack(err.stack!)
const frame = frames[0]
if (frame.lineNumber && frame?.file) {
......@@ -521,9 +522,9 @@ export default class DevServer extends Server {
if (!usedOriginalStack) {
if (type) {
Log.error(`${type}:`, possibleError)
Log.error(`${type}:`, err + '')
} else {
Log.error(possibleError)
Log.error(err + '')
}
}
}
......
......@@ -97,6 +97,7 @@ import ResponseCache, {
} from './response-cache'
import { NextConfigComplete } from './config-shared'
import { parseNextUrl } from '../shared/lib/router/utils/parse-next-url'
import isError from '../lib/is-error'
const getCustomRouteMatcher = pathMatch(true)
......@@ -490,7 +491,7 @@ export default class Server {
if (this.minimalMode || this.renderOpts.dev) {
throw err
}
this.logError(err)
this.logError(isError(err) ? err : new Error(err + ''))
res.statusCode = 500
res.end('Internal Server Error')
}
......@@ -1099,7 +1100,7 @@ export default class Server {
try {
builtPagePath = await this.getPagePath(page)
} catch (err) {
if (err.code === 'ENOENT') {
if (isError(err) && err.code === 'ENOENT') {
return false
}
throw err
......@@ -1412,7 +1413,7 @@ export default class Server {
},
}
} catch (err) {
if (err.code !== 'ENOENT') throw err
if (isError(err) && err.code !== 'ENOENT') throw err
}
}
return null
......@@ -1938,7 +1939,8 @@ export default class Server {
}
}
}
} catch (err) {
} catch (error) {
const err = isError(error) ? error : error ? new Error(error + '') : null
if (err instanceof NoFallbackError && bubbleNoFallback) {
throw err
}
......@@ -1951,17 +1953,15 @@ export default class Server {
const isWrappedError = err instanceof WrappedBuildError
const response = await this.renderErrorToResponse(
ctx,
isWrappedError ? err.innerError : err
isWrappedError ? (err as WrappedBuildError).innerError : err
)
if (!isWrappedError) {
if (this.minimalMode || this.renderOpts.dev) {
if (err) {
err.page = page
}
if (isError(err)) err.page = page
throw err
}
this.logError(err)
this.logError(err || new Error(error + ''))
}
return response
}
......@@ -2080,10 +2080,15 @@ export default class Server {
}
throw maybeFallbackError
}
} catch (renderToHtmlError) {
} catch (error) {
const renderToHtmlError = isError(error)
? error
: error
? new Error(error + '')
: null
const isWrappedError = renderToHtmlError instanceof WrappedBuildError
if (!isWrappedError) {
this.logError(renderToHtmlError)
this.logError(renderToHtmlError || new Error(error + ''))
}
res.statusCode = 500
const fallbackComponents = await this.getFallbackErrorComponents()
......@@ -2173,7 +2178,9 @@ export default class Server {
try {
await serveStatic(req, res, path)
} catch (err) {
} catch (error) {
if (!isError(error)) throw error
const err = error as Error & { code?: string; statusCode?: number }
if (err.code === 'ENOENT' || err.statusCode === 404) {
this.render404(req, res, parsedUrl)
} else if (err.statusCode === 412) {
......
......@@ -66,6 +66,7 @@ import {
} from '../lib/load-custom-routes'
import { DomainLocale } from './config'
import RenderResult, { NodeWritablePiper } from './render-result'
import isError from '../lib/is-error'
function noRouter() {
const message =
......@@ -585,10 +586,10 @@ export async function renderToHTML(
locale: renderOpts.locale,
defaultLocale: renderOpts.defaultLocale,
})
} catch (staticPropsError) {
} catch (staticPropsError: any) {
// remove not found error code to prevent triggering legacy
// 404 rendering
if (staticPropsError.code === 'ENOENT') {
if (staticPropsError && staticPropsError.code === 'ENOENT') {
delete staticPropsError.code
}
throw staticPropsError
......@@ -775,10 +776,13 @@ export async function renderToHTML(
defaultLocale: renderOpts.defaultLocale,
})
canAccessRes = false
} catch (serverSidePropsError) {
} catch (serverSidePropsError: any) {
// remove not found error code to prevent triggering legacy
// 404 rendering
if (serverSidePropsError.code === 'ENOENT') {
if (
isError(serverSidePropsError) &&
serverSidePropsError.code === 'ENOENT'
) {
delete serverSidePropsError.code
}
throw serverSidePropsError
......
......@@ -107,7 +107,7 @@ export default class ResponseCache {
)
}
} catch (err) {
rejecter(err)
rejecter(err as Error)
} finally {
if (key) {
this.pendingResponses.delete(key)
......
......@@ -124,7 +124,7 @@ export default class Router {
const memoizedPageChecker = async (p: string): Promise<boolean> => {
p = normalizeLocalePath(p, this.locales).pathname
if (pageChecks[p]) {
if (pageChecks[p] !== undefined) {
return pageChecks[p]
}
const result = this.pageChecker(p)
......
......@@ -13,6 +13,7 @@ import {
markAssetError,
} from '../../../client/route-loader'
import { RouterEvent } from '../../../client/router'
import isError from '../../../lib/is-error'
import type { DomainLocale } from '../../../server/config'
import { denormalizePagePath } from '../../../server/denormalize-page-path'
import { normalizeLocalePath } from '../i18n/normalize-locale-path'
......@@ -1226,7 +1227,7 @@ export default class Router implements BaseRouter {
return true
} catch (err) {
if (err.cancelled) {
if (isError(err) && err.cancelled) {
return false
}
throw err
......@@ -1271,7 +1272,7 @@ export default class Router implements BaseRouter {
}
async handleRouteInfoError(
err: Error & { code: any; cancelled: boolean },
err: Error & { code?: any; cancelled?: boolean },
pathname: string,
query: ParsedUrlQuery,
as: string,
......@@ -1337,7 +1338,7 @@ export default class Router implements BaseRouter {
return routeInfo
} catch (routeInfoErr) {
return this.handleRouteInfoError(
routeInfoErr,
isError(routeInfoErr) ? routeInfoErr : new Error(routeInfoErr + ''),
pathname,
query,
as,
......@@ -1420,7 +1421,13 @@ export default class Router implements BaseRouter {
this.components[route] = routeInfo
return routeInfo
} catch (err) {
return this.handleRouteInfoError(err, pathname, query, as, routeProps)
return this.handleRouteInfoError(
isError(err) ? err : new Error(err + ''),
pathname,
query,
as,
routeProps
)
}
}
......@@ -1650,7 +1657,7 @@ export default class Router implements BaseRouter {
_getServerData(dataHref: string): Promise<object> {
const { href: resourceKey } = new URL(dataHref, window.location.href)
if (this.sdr[resourceKey]) {
if (this.sdr[resourceKey] !== undefined) {
return this.sdr[resourceKey]
}
return (this.sdr[resourceKey] = fetchNextData(dataHref, this.isSsr)
......
......@@ -25,3 +25,7 @@ declare module '*.module.scss' {
const classes: { readonly [key: string]: string }
export default classes
}
interface Window {
MSInputMethodContext?: unknown
}
......@@ -30,7 +30,7 @@ export function getNodeError(error: Error): Error {
try {
throw new Error(error.message)
} catch (e) {
n = e
n = e as Error
}
n.name = error.name
......
......@@ -19267,10 +19267,10 @@ typedarray@^0.0.6:
version "0.0.6"
resolved "https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"
typescript@4.3.4:
version "4.3.4"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.3.4.tgz#3f85b986945bcf31071decdd96cf8bfa65f9dcbc"
integrity sha512-uauPG7XZn9F/mo+7MrsRjyvbxFpzemRjKEZXS4AK83oP2KKOJPvb+9cO/gmnv8arWZvhnjVOXz7B49m1l0e9Ew==
typescript@4.4.3:
version "4.4.3"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.4.3.tgz#bdc5407caa2b109efd4f82fe130656f977a29324"
integrity sha512-4xfscpisVgqqDfPaJo5vkd+Qd/ItkoagnHpufr+i2QCHBsNYp+G7UAoyFl8aPtx879u38wPV65rZ8qbGZijalA==
typescript@^4.1.3:
version "4.1.3"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment