Unverified Commit d88fd14a authored by Sanjaiyan Parthipan's avatar Sanjaiyan Parthipan Committed by GitHub

Hoist styles for Route Announcer 📢 (#39331)

Hi,

- Remove inlined CSS style which have minor performance loss. And hoist it to top of the component.
> Each time you inline an object, React re-creates a new reference to this object on every render. This causes components that receive this object to treat it as a referentially different one which have some performance pitfalls.


_Extremely sorry if I made any mistakes :(_
parent 869a2fe8
import React from 'react' import React from 'react'
import { useRouter } from './router' import { useRouter } from './router'
export function RouteAnnouncer() { const nextjsRouteAnnouncerStyles: React.CSSProperties = {
border: 0,
clip: 'rect(0 0 0 0)',
height: '1px',
margin: '-1px',
overflow: 'hidden',
padding: 0,
position: 'absolute',
width: '1px',
// https://medium.com/@jessebeach/beware-smushed-off-screen-accessible-text-5952a4c2cbfe
whiteSpace: 'nowrap',
wordWrap: 'normal',
}
export const RouteAnnouncer = () => {
const { asPath } = useRouter() const { asPath } = useRouter()
const [routeAnnouncement, setRouteAnnouncement] = React.useState('') const [routeAnnouncement, setRouteAnnouncement] = React.useState('')
...@@ -39,20 +54,7 @@ export function RouteAnnouncer() { ...@@ -39,20 +54,7 @@ export function RouteAnnouncer() {
aria-live="assertive" // Make the announcement immediately. aria-live="assertive" // Make the announcement immediately.
id="__next-route-announcer__" id="__next-route-announcer__"
role="alert" role="alert"
style={{ style={nextjsRouteAnnouncerStyles}
border: 0,
clip: 'rect(0 0 0 0)',
height: '1px',
margin: '-1px',
overflow: 'hidden',
padding: 0,
position: 'absolute',
width: '1px',
// https://medium.com/@jessebeach/beware-smushed-off-screen-accessible-text-5952a4c2cbfe
whiteSpace: 'nowrap',
wordWrap: 'normal',
}}
> >
{routeAnnouncement} {routeAnnouncement}
</p> </p>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment