Unverified Commit dcf8f041 authored by Leah's avatar Leah Committed by GitHub

fix(turbopack): deal with eventual consistency in get_directory_tree (#62444)

### What?

The file watcher might invalidate the (moved / deleted) directory before
the parent task can mark it as no longer needed.

Closes PACK-2588
parent 01c1bfa3
...@@ -296,7 +296,14 @@ async fn get_directory_tree_internal( ...@@ -296,7 +296,14 @@ async fn get_directory_tree_internal(
page_extensions: Vc<Vec<String>>, page_extensions: Vc<Vec<String>>,
) -> Result<Vc<DirectoryTree>> { ) -> Result<Vc<DirectoryTree>> {
let DirectoryContent::Entries(entries) = &*dir.read_dir().await? else { let DirectoryContent::Entries(entries) = &*dir.read_dir().await? else {
bail!("{} must be a directory", dir.to_string().await?); // the file watcher might invalidate things in the wrong order,
// and we have to account for the eventual consistency of turbo-tasks
// so we just return an empty tree here.
return Ok(DirectoryTree {
subdirectories: Default::default(),
components: Components::default().cell(),
}
.cell());
}; };
let page_extensions_value = page_extensions.await?; let page_extensions_value = page_extensions.await?;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment