Commit e19d91cf authored by Zack Tanner's avatar Zack Tanner Committed by JJ Kasper

add missing node modules to externals (#70382)

We should not attempt to bundle builtin node modules on the server. This
adds modules provided by Node.js to our externals list (along with some
missing internal ones in Turbopack. These were copied from
[here](https://github.com/vercel/next.js/blob/a675bde6c738318264573144663e38819aeb2661/crates/next-custom-transforms/src/transforms/warn_for_edge_runtime.rs#L77-L89)).

Fixes #70262
Closes NDX-314
# Conflicts:
#	turbopack/crates/turbopack-resolve/src/resolve.rs
parent ab03c774
......@@ -844,6 +844,8 @@ export default async function getBaseWebpackConfig(
const aliasCodeConditionTest = [codeCondition.test, pageExtensionsRegex]
const builtinModules = require('module').builtinModules
let webpackConfig: webpack.Configuration = {
parallelism: Number(process.env.NEXT_WEBPACK_PARALLELISM) || undefined,
...(isNodeServer ? { externalsPresets: { node: true } } : {}),
......@@ -867,6 +869,7 @@ export default async function getBaseWebpackConfig(
: []),
]
: [
...builtinModules,
({
context,
request,
......
......@@ -18,6 +18,8 @@ import timers from 'timers'
import tty from 'tty'
import util from 'util'
import zlib from 'zlib'
import '_http_common'
import 'setimmediate'
async function getData() {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment