Unverified Commit e296bcb8 authored by Zack Tanner's avatar Zack Tanner Committed by GitHub

[tests]: remove unnecessary skipDeployment flags (#92423)

These tests won't ever be run in a deployed environment, so this removes
`skipDeployment` so it's easier to grok which tests are intentionally
disabled because they don't work when deployed.
parent b43c4efb
...@@ -9,7 +9,6 @@ import stripAnsi from 'strip-ansi' ...@@ -9,7 +9,6 @@ import stripAnsi from 'strip-ansi'
describe('with turbopack.ignoreIssue config', () => { describe('with turbopack.ignoreIssue config', () => {
const { next, skipped } = nextTestSetup({ const { next, skipped } = nextTestSetup({
files: __dirname, files: __dirname,
skipDeployment: true,
nextConfig: { nextConfig: {
turbopack: { turbopack: {
ignoreIssue: [ ignoreIssue: [
...@@ -47,7 +46,6 @@ import stripAnsi from 'strip-ansi' ...@@ -47,7 +46,6 @@ import stripAnsi from 'strip-ansi'
describe('without turbopack.ignoreIssue config', () => { describe('without turbopack.ignoreIssue config', () => {
const { next, skipped } = nextTestSetup({ const { next, skipped } = nextTestSetup({
files: __dirname, files: __dirname,
skipDeployment: true,
}) })
if (skipped) return if (skipped) return
......
...@@ -3,7 +3,6 @@ import { nextTestSetup } from 'e2e-utils' ...@@ -3,7 +3,6 @@ import { nextTestSetup } from 'e2e-utils'
describe('app dir - dynamic error trace', () => { describe('app dir - dynamic error trace', () => {
const { next, skipped } = nextTestSetup({ const { next, skipped } = nextTestSetup({
files: __dirname, files: __dirname,
skipDeployment: true,
}) })
if (skipped) return if (skipped) return
......
...@@ -7,7 +7,6 @@ describe('turbopack-ignore-issue', () => { ...@@ -7,7 +7,6 @@ describe('turbopack-ignore-issue', () => {
const { next, skipped, isTurbopack } = nextTestSetup({ const { next, skipped, isTurbopack } = nextTestSetup({
files: __dirname, files: __dirname,
// turbopack.ignoreIssue is turbopack-only // turbopack.ignoreIssue is turbopack-only
skipDeployment: true,
nextConfig: { nextConfig: {
turbopack: { turbopack: {
ignoreIssue: [ ignoreIssue: [
...@@ -125,7 +124,6 @@ describe('turbopack-ignore-issue', () => { ...@@ -125,7 +124,6 @@ describe('turbopack-ignore-issue', () => {
describe('without turbopack.ignoreIssue config', () => { describe('without turbopack.ignoreIssue config', () => {
const { next, skipped, isTurbopack } = nextTestSetup({ const { next, skipped, isTurbopack } = nextTestSetup({
files: __dirname, files: __dirname,
skipDeployment: true,
}) })
if (skipped) return if (skipped) return
......
...@@ -3,8 +3,6 @@ import { nextTestSetup } from 'e2e-utils' ...@@ -3,8 +3,6 @@ import { nextTestSetup } from 'e2e-utils'
describe('turbopack-import-assertions-use', () => { describe('turbopack-import-assertions-use', () => {
const { next, isTurbopack } = nextTestSetup({ const { next, isTurbopack } = nextTestSetup({
files: __dirname, files: __dirname,
// This test is Turbopack-only; turbopackUse is not supported in webpack
skipDeployment: true,
}) })
if (!isTurbopack) { if (!isTurbopack) {
......
...@@ -7,7 +7,6 @@ import { nextTestSetup } from 'e2e-utils' ...@@ -7,7 +7,6 @@ import { nextTestSetup } from 'e2e-utils'
() => { () => {
const { next, skipped } = nextTestSetup({ const { next, skipped } = nextTestSetup({
files: path.join(__dirname, 'fixtures', 'compilation-errors-app'), files: path.join(__dirname, 'fixtures', 'compilation-errors-app'),
skipDeployment: true,
}) })
if (skipped) { if (skipped) {
......
...@@ -5,7 +5,6 @@ import { retry } from 'next-test-utils' ...@@ -5,7 +5,6 @@ import { retry } from 'next-test-utils'
describe('get-logs MCP tool', () => { describe('get-logs MCP tool', () => {
const { next, skipped } = nextTestSetup({ const { next, skipped } = nextTestSetup({
files: path.join(__dirname, 'fixtures', 'log-file-app'), files: path.join(__dirname, 'fixtures', 'log-file-app'),
skipDeployment: true,
}) })
if (skipped) { if (skipped) {
......
...@@ -4,7 +4,6 @@ import { nextTestSetup } from 'e2e-utils' ...@@ -4,7 +4,6 @@ import { nextTestSetup } from 'e2e-utils'
describe('get_routes MCP tool', () => { describe('get_routes MCP tool', () => {
const { next, skipped } = nextTestSetup({ const { next, skipped } = nextTestSetup({
files: path.join(__dirname, 'fixtures', 'dynamic-routes-app'), files: path.join(__dirname, 'fixtures', 'dynamic-routes-app'),
skipDeployment: true,
}) })
if (skipped) { if (skipped) {
......
...@@ -4,7 +4,6 @@ import { waitForRedbox, getRedboxSource } from 'next-test-utils' ...@@ -4,7 +4,6 @@ import { waitForRedbox, getRedboxSource } from 'next-test-utils'
describe('app dir - css', () => { describe('app dir - css', () => {
const { next, skipped } = nextTestSetup({ const { next, skipped } = nextTestSetup({
files: __dirname, files: __dirname,
skipDeployment: true,
dependencies: { dependencies: {
sass: 'latest', sass: 'latest',
}, },
......
...@@ -5,7 +5,6 @@ import path from 'path' ...@@ -5,7 +5,6 @@ import path from 'path'
describe('500-page - mixed-router-no-custom-pages-error', () => { describe('500-page - mixed-router-no-custom-pages-error', () => {
const { next, skipped } = nextTestSetup({ const { next, skipped } = nextTestSetup({
files: __dirname, files: __dirname,
skipDeployment: true,
}) })
if (skipped) { if (skipped) {
......
...@@ -5,7 +5,6 @@ import path from 'path' ...@@ -5,7 +5,6 @@ import path from 'path'
describe('500-page - mixed-router-with-custom-pages-error', () => { describe('500-page - mixed-router-with-custom-pages-error', () => {
const { next, skipped } = nextTestSetup({ const { next, skipped } = nextTestSetup({
files: __dirname, files: __dirname,
skipDeployment: true,
}) })
if (skipped) { if (skipped) {
......
...@@ -10,7 +10,6 @@ import { retry } from 'next-test-utils' ...@@ -10,7 +10,6 @@ import { retry } from 'next-test-utils'
() => { () => {
const { next } = nextTestSetupActionTreeShaking({ const { next } = nextTestSetupActionTreeShaking({
files: __dirname, files: __dirname,
skipDeployment: true,
}) })
it('should not tree-shake namespace exports the manifest', async () => { it('should not tree-shake namespace exports the manifest', async () => {
......
...@@ -3,7 +3,6 @@ import { nextTestSetup } from 'e2e-utils' ...@@ -3,7 +3,6 @@ import { nextTestSetup } from 'e2e-utils'
describe('bad-file-structure', () => { describe('bad-file-structure', () => {
const { next } = nextTestSetup({ const { next } = nextTestSetup({
files: __dirname, files: __dirname,
skipDeployment: true,
skipStart: true, skipStart: true,
}) })
......
...@@ -24,7 +24,6 @@ async function readFilesRecursive( ...@@ -24,7 +24,6 @@ async function readFilesRecursive(
describe('browser-chunks', () => { describe('browser-chunks', () => {
const { next } = nextTestSetup({ const { next } = nextTestSetup({
files: __dirname, files: __dirname,
skipDeployment: true,
}) })
let sources: string[] = [] let sources: string[] = []
......
...@@ -3,7 +3,6 @@ import { nextTestSetup } from 'e2e-utils' ...@@ -3,7 +3,6 @@ import { nextTestSetup } from 'e2e-utils'
describe('app-dir client-components-tree-shaking', () => { describe('app-dir client-components-tree-shaking', () => {
const { next, skipped } = nextTestSetup({ const { next, skipped } = nextTestSetup({
files: __dirname, files: __dirname,
skipDeployment: true,
}) })
if (skipped) return if (skipped) return
......
...@@ -5,7 +5,6 @@ describe('empty-generate-static-params', () => { ...@@ -5,7 +5,6 @@ describe('empty-generate-static-params', () => {
const { next, skipped } = nextTestSetup({ const { next, skipped } = nextTestSetup({
files: __dirname, files: __dirname,
skipStart: true, skipStart: true,
skipDeployment: true,
}) })
if (skipped) return if (skipped) return
......
...@@ -6,9 +6,6 @@ describe('empty-shell-route-cache', () => { ...@@ -6,9 +6,6 @@ describe('empty-shell-route-cache', () => {
const { next } = nextTestSetup({ const { next } = nextTestSetup({
files: __dirname, files: __dirname,
skipStart: true, skipStart: true,
// This regression inspects on-disk .next artifacts, so it only applies to
// self-hosted build + start and is not portable to deployment mode.
skipDeployment: true,
}) })
beforeAll(async () => { beforeAll(async () => {
......
...@@ -4,7 +4,6 @@ import { nextTestSetup } from 'e2e-utils' ...@@ -4,7 +4,6 @@ import { nextTestSetup } from 'e2e-utils'
describe.skip('app-dir - metadata-streaming-config-customized', () => { describe.skip('app-dir - metadata-streaming-config-customized', () => {
const { next } = nextTestSetup({ const { next } = nextTestSetup({
files: __dirname, files: __dirname,
skipDeployment: true,
overrideFiles: { overrideFiles: {
'next.config.js': ` 'next.config.js': `
module.exports = { module.exports = {
......
...@@ -4,7 +4,6 @@ import { nextTestSetup } from 'e2e-utils' ...@@ -4,7 +4,6 @@ import { nextTestSetup } from 'e2e-utils'
() => { () => {
const { next, skipped } = nextTestSetup({ const { next, skipped } = nextTestSetup({
files: __dirname, files: __dirname,
skipDeployment: true,
}) })
if (skipped) return if (skipped) return
......
...@@ -4,7 +4,6 @@ import { nextTestSetup } from 'e2e-utils' ...@@ -4,7 +4,6 @@ import { nextTestSetup } from 'e2e-utils'
() => { () => {
const { next, skipped } = nextTestSetup({ const { next, skipped } = nextTestSetup({
files: __dirname, files: __dirname,
skipDeployment: true,
}) })
if (skipped) return if (skipped) return
......
...@@ -10,7 +10,6 @@ const strictRouteTypes = ...@@ -10,7 +10,6 @@ const strictRouteTypes =
const { next } = nextTestSetup({ const { next } = nextTestSetup({
files: __dirname, files: __dirname,
skipStart: true, skipStart: true,
skipDeployment: true,
}) })
it('should pass build with Promise params', async () => { it('should pass build with Promise params', async () => {
......
...@@ -12,7 +12,6 @@ describe('post-build', () => { ...@@ -12,7 +12,6 @@ describe('post-build', () => {
const { next, isTurbopack, skipped } = nextTestSetup({ const { next, isTurbopack, skipped } = nextTestSetup({
files: __dirname, files: __dirname,
skipStart: true, skipStart: true,
skipDeployment: true,
env: { env: {
NEXT_USE_POST_BUILD: '1', NEXT_USE_POST_BUILD: '1',
}, },
......
...@@ -3,7 +3,6 @@ import { nextTestSetup } from 'e2e-utils' ...@@ -3,7 +3,6 @@ import { nextTestSetup } from 'e2e-utils'
describe('app-dir revalidate', () => { describe('app-dir revalidate', () => {
const { next, skipped } = nextTestSetup({ const { next, skipped } = nextTestSetup({
files: __dirname, files: __dirname,
skipDeployment: true,
}) })
if (skipped) { if (skipped) {
......
...@@ -5,8 +5,6 @@ import type { ClientReferenceManifest } from 'next/dist/build/webpack/plugins/fl ...@@ -5,8 +5,6 @@ import type { ClientReferenceManifest } from 'next/dist/build/webpack/plugins/fl
describe('route-handler-manifest-size', () => { describe('route-handler-manifest-size', () => {
const { next, isNextStart, skipped } = nextTestSetup({ const { next, isNextStart, skipped } = nextTestSetup({
files: __dirname, files: __dirname,
// This test is specifically for webpack behavior
skipDeployment: true,
}) })
if (skipped) return if (skipped) return
......
...@@ -3,7 +3,6 @@ import { retry } from 'next-test-utils' ...@@ -3,7 +3,6 @@ import { retry } from 'next-test-utils'
describe('ssg-single-pass', () => { describe('ssg-single-pass', () => {
const { next, skipped } = nextTestSetup({ const { next, skipped } = nextTestSetup({
skipDeployment: true,
files: __dirname, files: __dirname,
}) })
......
...@@ -8,7 +8,6 @@ const strictRouteTypes = ...@@ -8,7 +8,6 @@ const strictRouteTypes =
describe('types-gen-nounuselocal', () => { describe('types-gen-nounuselocal', () => {
const { next, skipped } = nextTestSetup({ const { next, skipped } = nextTestSetup({
files: __dirname, files: __dirname,
skipDeployment: true,
}) })
if (skipped) { if (skipped) {
......
...@@ -3,7 +3,6 @@ import { nextTestSetup } from 'e2e-utils' ...@@ -3,7 +3,6 @@ import { nextTestSetup } from 'e2e-utils'
describe('unstable-cache-foreground-revalidate', () => { describe('unstable-cache-foreground-revalidate', () => {
const { next, isNextDev } = nextTestSetup({ const { next, isNextDev } = nextTestSetup({
files: __dirname, files: __dirname,
skipDeployment: true,
}) })
if (isNextDev) { if (isNextDev) {
......
...@@ -10,7 +10,6 @@ describe('build-failed-trace', () => { ...@@ -10,7 +10,6 @@ describe('build-failed-trace', () => {
const { next } = nextTestSetup({ const { next } = nextTestSetup({
files: __dirname, files: __dirname,
skipStart: true, skipStart: true,
skipDeployment: true,
}) })
it('should mark the next-build span as failed when the build fails', async () => { it('should mark the next-build span as failed when the build fails', async () => {
......
...@@ -5,7 +5,6 @@ import { nextTestSetup } from 'e2e-utils' ...@@ -5,7 +5,6 @@ import { nextTestSetup } from 'e2e-utils'
describe('Cleaning distDir', () => { describe('Cleaning distDir', () => {
const { next, isTurbopack, skipped } = nextTestSetup({ const { next, isTurbopack, skipped } = nextTestSetup({
files: __dirname, files: __dirname,
skipDeployment: true,
skipStart: true, skipStart: true,
}) })
......
...@@ -3,7 +3,6 @@ import { nextTestSetup } from 'e2e-utils' ...@@ -3,7 +3,6 @@ import { nextTestSetup } from 'e2e-utils'
describe('config validation - fatal errors', () => { describe('config validation - fatal errors', () => {
const { next } = nextTestSetup({ const { next } = nextTestSetup({
skipStart: true, skipStart: true,
skipDeployment: true,
files: __dirname, files: __dirname,
}) })
......
...@@ -3,7 +3,6 @@ import { nextTestSetup } from 'e2e-utils' ...@@ -3,7 +3,6 @@ import { nextTestSetup } from 'e2e-utils'
describe('config validation - warnings only', () => { describe('config validation - warnings only', () => {
const { next } = nextTestSetup({ const { next } = nextTestSetup({
skipStart: true, skipStart: true,
skipDeployment: true,
files: __dirname, files: __dirname,
}) })
......
...@@ -3,7 +3,6 @@ import { isNextStart, nextTestSetup } from 'e2e-utils' ...@@ -3,7 +3,6 @@ import { isNextStart, nextTestSetup } from 'e2e-utils'
describe('css-url-deployment-id', () => { describe('css-url-deployment-id', () => {
const { next } = nextTestSetup({ const { next } = nextTestSetup({
files: __dirname, files: __dirname,
skipDeployment: true,
dependencies: { sass: '1.54.0' }, dependencies: { sass: '1.54.0' },
env: { env: {
NEXT_DEPLOYMENT_ID: isNextStart ? 'test-deployment-id' : undefined, NEXT_DEPLOYMENT_ID: isNextStart ? 'test-deployment-id' : undefined,
......
...@@ -5,7 +5,6 @@ describe('debug-build-paths', () => { ...@@ -5,7 +5,6 @@ describe('debug-build-paths', () => {
describe('default fixture', () => { describe('default fixture', () => {
const { next, skipped } = nextTestSetup({ const { next, skipped } = nextTestSetup({
files: path.join(__dirname, 'fixtures/default'), files: path.join(__dirname, 'fixtures/default'),
skipDeployment: true,
skipStart: true, skipStart: true,
}) })
...@@ -283,7 +282,6 @@ describe('debug-build-paths', () => { ...@@ -283,7 +282,6 @@ describe('debug-build-paths', () => {
describe('with-compile-error fixture', () => { describe('with-compile-error fixture', () => {
const { next, skipped } = nextTestSetup({ const { next, skipped } = nextTestSetup({
files: path.join(__dirname, 'fixtures/with-compile-error'), files: path.join(__dirname, 'fixtures/with-compile-error'),
skipDeployment: true,
skipStart: true, skipStart: true,
}) })
......
...@@ -216,7 +216,6 @@ const FILES = { ...@@ -216,7 +216,6 @@ const FILES = {
NOW_BUILDER: '1', NOW_BUILDER: '1',
}, },
skipStart: true, skipStart: true,
skipDeployment: true,
disableAutoSkewProtection: true, disableAutoSkewProtection: true,
}) })
...@@ -254,7 +253,6 @@ const FILES = { ...@@ -254,7 +253,6 @@ const FILES = {
} }
: undefined, : undefined,
skipStart: true, skipStart: true,
skipDeployment: true,
disableAutoSkewProtection: true, disableAutoSkewProtection: true,
}) })
......
...@@ -3,7 +3,6 @@ import { nextTestSetup } from 'e2e-utils' ...@@ -3,7 +3,6 @@ import { nextTestSetup } from 'e2e-utils'
describe('Edge config validations', () => { describe('Edge config validations', () => {
const { next } = nextTestSetup({ const { next } = nextTestSetup({
skipStart: true, skipStart: true,
skipDeployment: true,
files: { files: {
'pages/index.js': ` 'pages/index.js': `
export default function Page() { export default function Page() {
......
...@@ -72,7 +72,6 @@ async function readNormalizedNFT(next, name) { ...@@ -72,7 +72,6 @@ async function readNormalizedNFT(next, name) {
describe('with output:standalone', () => { describe('with output:standalone', () => {
const { next, skipped } = nextTestSetup({ const { next, skipped } = nextTestSetup({
files: __dirname, files: __dirname,
skipDeployment: true,
dependencies: { dependencies: {
typescript: '5.9.2', typescript: '5.9.2',
}, },
...@@ -402,7 +401,6 @@ async function readNormalizedNFT(next, name) { ...@@ -402,7 +401,6 @@ async function readNormalizedNFT(next, name) {
describe('default mode', () => { describe('default mode', () => {
const { next, skipped } = nextTestSetup({ const { next, skipped } = nextTestSetup({
files: __dirname, files: __dirname,
skipDeployment: true,
dependencies: { dependencies: {
typescript: '5.9.2', typescript: '5.9.2',
}, },
......
...@@ -60,7 +60,6 @@ describe('Production browser sourcemaps', () => { ...@@ -60,7 +60,6 @@ describe('Production browser sourcemaps', () => {
nextConfig: { nextConfig: {
productionBrowserSourceMaps, productionBrowserSourceMaps,
}, },
skipDeployment: true,
}) })
if (skipped) { if (skipped) {
......
...@@ -3,7 +3,6 @@ import { nextTestSetup } from 'e2e-utils' ...@@ -3,7 +3,6 @@ import { nextTestSetup } from 'e2e-utils'
describe('remove-unused-imports', () => { describe('remove-unused-imports', () => {
const { next, skipped } = nextTestSetup({ const { next, skipped } = nextTestSetup({
files: __dirname, files: __dirname,
skipDeployment: true,
}) })
if (skipped) { if (skipped) {
......
...@@ -6,7 +6,6 @@ describe('standalone mode - tracing-side-effects-false', () => { ...@@ -6,7 +6,6 @@ describe('standalone mode - tracing-side-effects-false', () => {
const { next, skipped } = nextTestSetup({ const { next, skipped } = nextTestSetup({
files: __dirname, files: __dirname,
dependencies, dependencies,
skipDeployment: true,
skipStart: true, skipStart: true,
}) })
......
...@@ -6,7 +6,6 @@ describe('standalone mode - tracing-static-files', () => { ...@@ -6,7 +6,6 @@ describe('standalone mode - tracing-static-files', () => {
const { next, skipped } = nextTestSetup({ const { next, skipped } = nextTestSetup({
files: __dirname, files: __dirname,
dependencies, dependencies,
skipDeployment: true,
skipStart: true, skipStart: true,
}) })
......
...@@ -6,7 +6,6 @@ describe('standalone mode - tracing-unparsable', () => { ...@@ -6,7 +6,6 @@ describe('standalone mode - tracing-unparsable', () => {
const { next, skipped } = nextTestSetup({ const { next, skipped } = nextTestSetup({
files: __dirname, files: __dirname,
dependencies, dependencies,
skipDeployment: true,
skipStart: true, skipStart: true,
}) })
......
...@@ -4,7 +4,6 @@ describe('typescript-build-output', () => { ...@@ -4,7 +4,6 @@ describe('typescript-build-output', () => {
const { next, isNextDeploy, skipped } = nextTestSetup({ const { next, isNextDeploy, skipped } = nextTestSetup({
files: __dirname, files: __dirname,
skipStart: true, skipStart: true,
skipDeployment: true,
}) })
if (skipped) { if (skipped) {
......
...@@ -4,7 +4,6 @@ describe('Side-effect imports with noUncheckedSideEffectImports', () => { ...@@ -4,7 +4,6 @@ describe('Side-effect imports with noUncheckedSideEffectImports', () => {
const { next, skipped } = nextTestSetup({ const { next, skipped } = nextTestSetup({
files: __dirname, files: __dirname,
dependencies: { sass: '1.54.0' }, dependencies: { sass: '1.54.0' },
skipDeployment: true, // No need to run this in deployment mode.
skipStart: true, skipStart: true,
}) })
if (skipped) return if (skipped) return
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment