Unverified Commit e50620b9 authored by Jan Potoms's avatar Jan Potoms Committed by GitHub

Use memoizedPagechecker (#13191)

It seems like this was supposed to use the memoized version of `pageChecker`. I also updated the function to memoize promises instead of promise results. Just in case this function ever gets called concurrently.
parent ed2ca820
...@@ -162,12 +162,12 @@ export default class Router { ...@@ -162,12 +162,12 @@ export default class Router {
parsedUrl: UrlWithParsedQuery parsedUrl: UrlWithParsedQuery
): Promise<boolean> { ): Promise<boolean> {
// memoize page check calls so we don't duplicate checks for pages // memoize page check calls so we don't duplicate checks for pages
const pageChecks: { [name: string]: boolean } = {} const pageChecks: { [name: string]: Promise<boolean> } = {}
const memoizedPageChecker = async (p: string): Promise<boolean> => { const memoizedPageChecker = async (p: string): Promise<boolean> => {
if (pageChecks[p]) { if (pageChecks[p]) {
return pageChecks[p] return pageChecks[p]
} }
const result = await this.pageChecker(p) const result = this.pageChecker(p)
pageChecks[p] = result pageChecks[p] = result
return result return result
} }
...@@ -200,7 +200,7 @@ export default class Router { ...@@ -200,7 +200,7 @@ export default class Router {
if (!pathname) { if (!pathname) {
return { finished: false } return { finished: false }
} }
if (await this.pageChecker(pathname)) { if (await memoizedPageChecker(pathname)) {
return this.catchAllRoute.fn(req, res, params, parsedUrl) return this.catchAllRoute.fn(req, res, params, parsedUrl)
} }
return { finished: false } return { finished: false }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment