Unverified Commit e5a7452f authored by Benjamin Woodruff's avatar Benjamin Woodruff Committed by GitHub

chore(turbo-tasks-backend): Disable flaky performance test by default (#70974)

The CI environment is **very** noisy and this test can (and does) flake:
https://github.com/vercel/next.js/pull/69667#discussion_r1792296524

```
cargo nextest r -p turbo-tasks-memory many_calls_to_many_children --no-capture
```

```
TURBOPACK_TEST_PERFORMANCE=yes cargo nextest r -p turbo-tasks-memory many_calls_to_many_children --no-capture
```

The plan to solve this is to integrate codspeed, which should guarantee
low noise via an emulated CPU.
parent f9d40660
...@@ -14,6 +14,14 @@ const COUNT2: u32 = 2000; ...@@ -14,6 +14,14 @@ const COUNT2: u32 = 2000;
#[tokio::test] #[tokio::test]
async fn many_calls_to_many_children() { async fn many_calls_to_many_children() {
if matches!(
std::env::var("TURBOPACK_TEST_PERFORMANCE").ok().as_deref(),
None | Some("") | Some("no") | Some("false")
) {
println!("Skipping test, pass `TURBOPACK_TEST_PERFORMANCE=yes` to run it");
return;
}
run(&REGISTRATION, || async { run(&REGISTRATION, || async {
// The first call will actually execute many_children and its children. // The first call will actually execute many_children and its children.
let start = std::time::Instant::now(); let start = std::time::Instant::now();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment