Unverified Commit e6690841 authored by JJ Kasper's avatar JJ Kasper Committed by GitHub

Ensure manifests check has correct exit code on fail (#29183)

parent 37c66dcd
...@@ -2,13 +2,12 @@ ...@@ -2,13 +2,12 @@
#### Why This Error Occurred #### Why This Error Occurred
`getServerSideProps()` surfaces a `ServerResponse` object through the `res` property of its `context` arg. This object is not intended to be accessed or changed after `getServerSideProps()` resolves. `getServerSideProps()` surfaces a `ServerResponse` object through the `res` property of its `context` arg. This object is not intended to be accessed or changed after `getServerSideProps()` resolves.
This is because the framework tries to optimize when items like headers or status codes are flushed to the browser. If they are changed after `getServerSideProps()` completes, we can't guarantee that the changes will work. This is because the framework tries to optimize when items like headers or status codes are flushed to the browser. If they are changed after `getServerSideProps()` completes, we can't guarantee that the changes will work.
For this reason, accessing the object after this time is disallowed. For this reason, accessing the object after this time is disallowed.
#### Possible Ways to Fix It #### Possible Ways to Fix It
You can fix this error by moving any access of the `res` object into `getServerSideProps()` itself or any functions that run before `getServerSideProps()` returns. You can fix this error by moving any access of the `res` object into `getServerSideProps()` itself or any functions that run before `getServerSideProps()` returns.
......
...@@ -64,4 +64,7 @@ async function main() { ...@@ -64,4 +64,7 @@ async function main() {
main() main()
.then(() => console.log('success')) .then(() => console.log('success'))
.catch(console.error) .catch((err) => {
console.error(err)
process.exit(1)
})
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment