Unverified Commit e6b43fb1 authored by vercel-fleet-prod[bot]'s avatar vercel-fleet-prod[bot] Committed by GitHub

turbopack: ignore deferred circuit breaker edges

Co-authored-by: 's avatarLuke Sandberg <210140+lukesandberg@users.noreply.github.com>
parent 87a97cf1
......@@ -15,7 +15,7 @@ use crate::{
async_module_info::AsyncModulesInfo,
side_effect_module_info::{SideEffectFreeModules, compute_side_effect_free_module_info},
},
resolve::{ExportUsage, ImportUsage},
resolve::{ExportUsage, ImportUsage, ModuleEvaluationTiming},
};
#[turbo_tasks::value(transparent, cell = "keyed")]
......@@ -349,8 +349,12 @@ pub async fn compute_binding_usage_info(
let mut export_circuit_breakers = FxHashSet::default();
graph_ref.traverse_cycles(
// No need to traverse edges that are unused.
|e| e.chunking_type.is_parallel() && !unused_references.contains_key(&e.reference),
// Deferred and unused edges can't participate in an evaluation cycle.
|e| {
e.chunking_type.is_parallel()
&& e.binding_usage.evaluation_timing != ModuleEvaluationTiming::Deferred
&& !unused_references.contains_key(&e.reference)
},
|cycle| {
// We could compute this based on the module graph via a DFS from each entry point
// to the cycle. Whatever node is hit first is an entry point to the cycle.
......
export const deferredValue = 'deferred'
export function loadEntry() {
return require('./index.js').entryValue
}
import { deferredValue, loadEntry } from './deferred.js'
export const entryValue = 'entry'
it('does not need a circuit breaker for a deferred cycle', () => {
expect(deferredValue).toBe('deferred')
expect(loadEntry()).toBe('entry')
})
import { eagerB, readEntry } from './eager-b.js'
export { readEntry }
export const eagerA = 'a'
export function readB() {
return eagerB
}
import { entryValue } from './index.js'
export const eagerB = 'b'
export function readEntry() {
return entryValue
}
import { eagerA, readB, readEntry } from './eager-a.js'
export const entryValue = 'entry'
it('preserves an evaluation-time cycle', () => {
expect(eagerA).toBe('a')
expect(readB()).toBe('b')
expect(readEntry()).toBe('entry')
})
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment