Unverified Commit e750f437 authored by Balázs Orbán's avatar Balázs Orbán Committed by GitHub

fix: send url to gtm.pageview (#21747)

`gtm.pageview` was called without sending an actual URL, while it is required here:

https://github.com/vercel/next.js/blob/36aeca8f041a81ae01cae3c55e5c187a038e4166/examples/with-google-tag-manager/lib/gtm.js#L3-L6
parent 4cadb68d
...@@ -2,17 +2,13 @@ import { useEffect } from 'react' ...@@ -2,17 +2,13 @@ import { useEffect } from 'react'
import { useRouter } from 'next/router' import { useRouter } from 'next/router'
import * as gtm from '../lib/gtm' import * as gtm from '../lib/gtm'
const handleRouteChange = () => {
gtm.pageview()
}
const GoogleTagManager = ({ children }) => { const GoogleTagManager = ({ children }) => {
const router = useRouter() const router = useRouter()
useEffect(() => { useEffect(() => {
router.events.on('routeChangeComplete', handleRouteChange) router.events.on('routeChangeComplete', gtm.pageview)
return () => { return () => {
router.events.off('routeChangeComplete', handleRouteChange) router.events.off('routeChangeComplete', gtm.pageview)
} }
}, [router.events]) }, [router.events])
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment