Remove suspend during operations (#99383)
## What
Remove the ability to suspend in flight operations to allow for
snapshotting and GC
## Why
Exstensive testing with GC has revealed a number of bugs latent in this
system
* transient task ids are getting serialized as part of operations, this
confuses our new stricter task access semantics in fresh sessions
* child execution contexts don't properly participate, they both need to
suspend when requested to avoid exceeding retries since the task they
are waiting for has already suspended, and cannot suspend because that
could deadlock the scope_bounded call
Instead we just don't suspend. This simplifies a lot, should be a small
perf win (purely from not touching the atomics as often)
The major risk is that waiting for everything to settle adds latency. To
mitigate that:
* idle snapshots don't wait for operations to settle, they just bail out
instead
* other snapshots do wait but log warnings if it takes more than 10s,
this should never happen but if it does we will have a smoking gun
---------
Co-authored-by:
Luke Sandberg <lukesandberg@users.noreply.github.com>
Showing
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
Please
register
or
sign in
to comment