Unverified Commit eb5bafb7 authored by Sebastian "Sebbie" Silbermann's avatar Sebastian "Sebbie" Silbermann Committed by GitHub

[cd] Document that Turbopack team can also approve releases (#100650)

Follow-up to #100121. The gated release environments (`bot-approved`,
`release-stable`, `release-beta`, `release-release-candidate`,
`release-preview`) now list both Next.js Engineering and Turbopack as
reviewer teams, so a member of either team can approve stable tag
creation and non-canary publishes.
Co-authored-by: 's avatarClaude Code <noreply@anthropic.com>
parent c0f54e5d
...@@ -46,14 +46,15 @@ repository secrets, so using them is gated by deployment rules: ...@@ -46,14 +46,15 @@ repository secrets, so using them is gated by deployment rules:
from the `canary` branch and release tags). This is what keeps the nightly from the `canary` branch and release tags). This is what keeps the nightly
canary unattended. Prerelease tags only ever point at reviewed branch canary unattended. Prerelease tags only ever point at reviewed branch
content, so creating them needs no approval. content, so creating them needs no approval.
- Only `stable` requires a deployment approval from the Next.js Engineering team - Only `stable` requires a deployment approval from the Next.js Engineering
**before the release tag is created** (environment `bot-approved`). The or Turbopack team **before the release tag is created** (environment
person who dispatched the release cannot approve it themselves. `bot-approved`). The person who dispatched the release cannot approve it
themselves.
- Publishing to npm is gated per channel: the publish job only runs in the - Publishing to npm is gated per channel: the publish job only runs in the
channel's `release-*` environment (deployable only from matching tags), and channel's `release-*` environment (deployable only from matching tags), and
every channel except canary (`release-stable`, `release-beta`, every channel except canary (`release-stable`, `release-beta`,
`release-release-candidate`, `release-preview`) requires Next.js `release-release-candidate`, `release-preview`) requires Next.js
Engineering approval there. Engineering or Turbopack approval there.
So a stable release is approved twice — once before its tag exists and once So a stable release is approved twice — once before its tag exists and once
before the packages reach npm — every other prerelease is approved once (at before the packages reach npm — every other prerelease is approved once (at
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment