Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
N
next.js
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Alex
next.js
Commits
eb86d82e
Unverified
Commit
eb86d82e
authored
Nov 21, 2024
by
Tobias Koppers
Committed by
GitHub
Nov 21, 2024
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix benchmark directory (#73057)
### What? The bench need to run in the correct directory
parent
d434b4ce
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
13 additions
and
8 deletions
+13
-8
next.config.mjs
bench/heavy-npm-deps/next.config.mjs
+1
-1
devlow-bench.mjs
scripts/devlow-bench.mjs
+12
-7
No files found.
bench/heavy-npm-deps/next.config.mjs
View file @
eb86d82e
...
@@ -8,7 +8,7 @@ const nextConfig = {
...
@@ -8,7 +8,7 @@ const nextConfig = {
},
},
experimental
:
{
experimental
:
{
turbo
:
{
turbo
:
{
unstablePersistentCaching
:
process
.
env
.
TURBO_CACHE
?
1
:
false
,
unstablePersistentCaching
:
process
.
env
.
TURBO_CACHE
?
true
:
false
,
},
},
},
},
}
}
...
...
scripts/devlow-bench.mjs
View file @
eb86d82e
...
@@ -26,7 +26,7 @@ const GIT_BRANCH =
...
@@ -26,7 +26,7 @@ const GIT_BRANCH =
})())
})())
const
nextBuildWorkflow
=
const
nextBuildWorkflow
=
(
benchmarkName
,
pages
,
enableTurbopackCache
)
=>
(
benchmarkName
,
benchDir
,
pages
,
enableTurbopackCache
)
=>
async
({
turbopack
,
page
})
=>
{
async
({
turbopack
,
page
})
=>
{
const
pageConfig
=
const
pageConfig
=
typeof
pages
[
page
]
===
'string'
?
{
url
:
pages
[
page
]
}
:
pages
[
page
]
typeof
pages
[
page
]
===
'string'
?
{
url
:
pages
[
page
]
}
:
pages
[
page
]
...
@@ -47,7 +47,7 @@ const nextBuildWorkflow =
...
@@ -47,7 +47,7 @@ const nextBuildWorkflow =
__NEXT_TEST_MODE
:
'1'
,
__NEXT_TEST_MODE
:
'1'
,
}
}
const
benchmarkDir
=
resolve
(
REPO_ROOT
,
'bench'
,
bench
markName
)
const
benchmarkDir
=
resolve
(
REPO_ROOT
,
'bench'
,
bench
Dir
)
// cleanup .next directory to remove persistent cache
// cleanup .next directory to remove persistent cache
await
retry
(()
=>
await
retry
(()
=>
...
@@ -233,13 +233,13 @@ const nextBuildWorkflow =
...
@@ -233,13 +233,13 @@ const nextBuildWorkflow =
}
}
const
nextDevWorkflow
=
const
nextDevWorkflow
=
(
benchmarkName
,
pages
)
=>
(
benchmarkName
,
benchDir
,
pages
)
=>
async
({
turbopack
,
page
})
=>
{
async
({
turbopack
,
page
})
=>
{
const
pageConfig
=
const
pageConfig
=
typeof
pages
[
page
]
===
'string'
?
{
url
:
pages
[
page
]
}
:
pages
[
page
]
typeof
pages
[
page
]
===
'string'
?
{
url
:
pages
[
page
]
}
:
pages
[
page
]
const
cleanupTasks
=
[]
const
cleanupTasks
=
[]
try
{
try
{
const
benchmarkDir
=
resolve
(
REPO_ROOT
,
'bench'
,
bench
markName
)
const
benchmarkDir
=
resolve
(
REPO_ROOT
,
'bench'
,
bench
Dir
)
// cleanup .next directory to remove persistent cache
// cleanup .next directory to remove persistent cache
await
retry
(()
=>
await
retry
(()
=>
...
@@ -565,7 +565,7 @@ describe(
...
@@ -565,7 +565,7 @@ describe(
mode
:
'dev'
,
mode
:
'dev'
,
page
:
Object
.
keys
(
pages
),
page
:
Object
.
keys
(
pages
),
},
},
nextDevWorkflow
(
'heavy-npm-deps'
,
pages
)
nextDevWorkflow
(
'heavy-npm-deps'
,
'heavy-npm-deps'
,
pages
)
)
)
describe
(
describe
(
...
@@ -575,7 +575,7 @@ describe(
...
@@ -575,7 +575,7 @@ describe(
mode
:
'build'
,
mode
:
'build'
,
page
:
Object
.
keys
(
pages
),
page
:
Object
.
keys
(
pages
),
},
},
nextBuildWorkflow
(
'heavy-npm-deps'
,
pages
,
false
)
nextBuildWorkflow
(
'heavy-npm-deps'
,
'heavy-npm-deps'
,
pages
,
false
)
)
)
describe
(
describe
(
...
@@ -585,7 +585,12 @@ describe(
...
@@ -585,7 +585,12 @@ describe(
mode
:
'build'
,
mode
:
'build'
,
page
:
Object
.
keys
(
pages
),
page
:
Object
.
keys
(
pages
),
},
},
nextBuildWorkflow
(
'heavy-npm-deps-build-turbo-cache-enabled'
,
pages
,
true
)
nextBuildWorkflow
(
'heavy-npm-deps-build-turbo-cache-enabled'
,
'heavy-npm-deps'
,
pages
,
true
)
)
)
async
function
retry
(
fn
)
{
async
function
retry
(
fn
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment