Unverified Commit ec4df713 authored by Steven's avatar Steven Committed by GitHub

Fix Image Optimization cache-control regression with external images (#37625)

In a previous PR (#34075), the ISR behavior was introduced to the Image Optimization API, however it changed the cache-control header to always set maxage=0. While this is probably the right behavior (the client shouldn't cache the image), it introduced a regression for users who have CDNs in front of a single Next.js instance (as opposed to [multiple Next.js instances](https://nextjs.org/docs/basic-features/data-fetching/incremental-static-regeneration#self-hosting-isr)).

Furthermore, the pros of client-side caching outweight the cons because its easy to change the image url (add querystring param for example) to invalidate the cache.

This PR reverts the cache-control behavior until we can come up with a better long-term solution.

- Fixes #35987
- Related to #19914 
- Related to #22319 
- Closes #35596
parent 77c96a19
...@@ -485,7 +485,7 @@ The cache status of an image can be determined by reading the value of the `x-ne ...@@ -485,7 +485,7 @@ The cache status of an image can be determined by reading the value of the `x-ne
- `STALE` - the path is in the cache but exceeded the revalidate time so it will be updated in the background - `STALE` - the path is in the cache but exceeded the revalidate time so it will be updated in the background
- `HIT` - the path is in the cache and has not exceeded the revalidate time - `HIT` - the path is in the cache and has not exceeded the revalidate time
The expiration (or rather Max Age) is defined by either the [`minimumCacheTTL`](#minimum-cache-ttl) configuration or the upstream server's `Cache-Control` header, whichever is larger. Specifically, the `max-age` value of the `Cache-Control` header is used. If both `s-maxage` and `max-age` are found, then `s-maxage` is preferred. The expiration (or rather Max Age) is defined by either the [`minimumCacheTTL`](#minimum-cache-ttl) configuration or the upstream image `Cache-Control` header, whichever is larger. Specifically, the `max-age` value of the `Cache-Control` header is used. If both `s-maxage` and `max-age` are found, then `s-maxage` is preferred. The `max-age` is also passed-through to any downstream clients including CDNs and browsers.
- You can configure [`minimumCacheTTL`](#minimum-cache-ttl) to increase the cache duration when the upstream image does not include `Cache-Control` header or the value is very low. - You can configure [`minimumCacheTTL`](#minimum-cache-ttl) to increase the cache duration when the upstream image does not include `Cache-Control` header or the value is very low.
- You can configure [`deviceSizes`](#device-sizes) and [`imageSizes`](#device-sizes) to reduce the total number of possible generated images. - You can configure [`deviceSizes`](#device-sizes) and [`imageSizes`](#device-sizes) to reduce the total number of possible generated images.
...@@ -503,7 +503,11 @@ module.exports = { ...@@ -503,7 +503,11 @@ module.exports = {
} }
``` ```
If you need to add a `Cache-Control` header for the browser (not recommended), you can configure [`headers`](/docs/api-reference/next.config.js/headers) on the upstream image e.g. `/some-asset.jpg` not `/_next/image` itself. The expiration (or rather Max Age) of the optimized image is defined by either the `minimumCacheTTL` or the upstream image `Cache-Control` header, whichever is larger.
If you need to change the caching behavior per image, you can configure [`headers`](/docs/api-reference/next.config.js/headers) to set the `Cache-Control` header on the upstream image (e.g. `/some-asset.jpg`, not `/_next/image` itself).
There is no mechanism to invalidate the cache at this time, so its best to keep `minimumCacheTTL` low. Otherwise you may need to manually change the [`src`](#src) prop or delete `<distDir>/cache/images`.
### Disable Static Imports ### Disable Static Imports
......
...@@ -567,14 +567,16 @@ function setResponseHeaders( ...@@ -567,14 +567,16 @@ function setResponseHeaders(
contentType: string | null, contentType: string | null,
isStatic: boolean, isStatic: boolean,
xCache: XCacheHeader, xCache: XCacheHeader,
contentSecurityPolicy: string contentSecurityPolicy: string,
maxAge: number,
isDev: boolean
) { ) {
res.setHeader('Vary', 'Accept') res.setHeader('Vary', 'Accept')
res.setHeader( res.setHeader(
'Cache-Control', 'Cache-Control',
isStatic isStatic
? 'public, max-age=315360000, immutable' ? 'public, max-age=315360000, immutable'
: `public, max-age=0, must-revalidate` : `public, max-age=${isDev ? 0 : maxAge}, must-revalidate`
) )
if (sendEtagResponse(req, res, etag)) { if (sendEtagResponse(req, res, etag)) {
// already called res.end() so we're finished // already called res.end() so we're finished
...@@ -608,7 +610,9 @@ export function sendResponse( ...@@ -608,7 +610,9 @@ export function sendResponse(
buffer: Buffer, buffer: Buffer,
isStatic: boolean, isStatic: boolean,
xCache: XCacheHeader, xCache: XCacheHeader,
contentSecurityPolicy: string contentSecurityPolicy: string,
maxAge: number,
isDev: boolean
) { ) {
const contentType = getContentType(extension) const contentType = getContentType(extension)
const etag = getHash([buffer]) const etag = getHash([buffer])
...@@ -620,7 +624,9 @@ export function sendResponse( ...@@ -620,7 +624,9 @@ export function sendResponse(
contentType, contentType,
isStatic, isStatic,
xCache, xCache,
contentSecurityPolicy contentSecurityPolicy,
maxAge,
isDev
) )
if (!result.finished) { if (!result.finished) {
res.setHeader('Content-Length', Buffer.byteLength(buffer)) res.setHeader('Content-Length', Buffer.byteLength(buffer))
......
...@@ -281,7 +281,9 @@ export default class NextNodeServer extends BaseServer { ...@@ -281,7 +281,9 @@ export default class NextNodeServer extends BaseServer {
cacheEntry.value.buffer, cacheEntry.value.buffer,
paramsResult.isStatic, paramsResult.isStatic,
cacheEntry.isMiss ? 'MISS' : cacheEntry.isStale ? 'STALE' : 'HIT', cacheEntry.isMiss ? 'MISS' : cacheEntry.isStale ? 'STALE' : 'HIT',
imagesConfig.contentSecurityPolicy imagesConfig.contentSecurityPolicy,
cacheEntry.revalidate || 0,
Boolean(this.renderOpts.dev)
) )
} catch (err) { } catch (err) {
if (err instanceof ImageError) { if (err instanceof ImageError) {
......
...@@ -476,7 +476,7 @@ describe('Image Optimizer', () => { ...@@ -476,7 +476,7 @@ describe('Image Optimizer', () => {
const res = await fetchViaHTTP(appPort, '/_next/image', query, opts) const res = await fetchViaHTTP(appPort, '/_next/image', query, opts)
expect(res.status).toBe(200) expect(res.status).toBe(200)
expect(res.headers.get('Cache-Control')).toBe( expect(res.headers.get('Cache-Control')).toBe(
`public, max-age=0, must-revalidate` `public, max-age=86400, must-revalidate`
) )
expect(res.headers.get('Content-Disposition')).toBe( expect(res.headers.get('Content-Disposition')).toBe(
`inline; filename="test.webp"` `inline; filename="test.webp"`
...@@ -505,7 +505,7 @@ describe('Image Optimizer', () => { ...@@ -505,7 +505,7 @@ describe('Image Optimizer', () => {
const res = await fetchViaHTTP(appPort, '/_next/image', query, opts) const res = await fetchViaHTTP(appPort, '/_next/image', query, opts)
expect(res.status).toBe(200) expect(res.status).toBe(200)
expect(res.headers.get('Cache-Control')).toBe( expect(res.headers.get('Cache-Control')).toBe(
`public, max-age=0, must-revalidate` `public, max-age=60, must-revalidate`
) )
expect(res.headers.get('Content-Disposition')).toBe( expect(res.headers.get('Content-Disposition')).toBe(
`inline; filename="test.webp"` `inline; filename="test.webp"`
...@@ -577,7 +577,7 @@ describe('Image Optimizer', () => { ...@@ -577,7 +577,7 @@ describe('Image Optimizer', () => {
expect(res.status).toBe(200) expect(res.status).toBe(200)
expect(res.headers.get('Content-Type')).toBe('image/webp') expect(res.headers.get('Content-Type')).toBe('image/webp')
expect(res.headers.get('Cache-Control')).toBe( expect(res.headers.get('Cache-Control')).toBe(
`public, max-age=0, must-revalidate` `public, max-age=31536000, must-revalidate`
) )
expect(res.headers.get('Vary')).toBe('Accept') expect(res.headers.get('Vary')).toBe('Accept')
expect(res.headers.get('Content-Disposition')).toBe( expect(res.headers.get('Content-Disposition')).toBe(
......
...@@ -128,6 +128,7 @@ async function fetchWithDuration(...args) { ...@@ -128,6 +128,7 @@ async function fetchWithDuration(...args) {
} }
export function runTests(ctx) { export function runTests(ctx) {
const { isDev, minimumCacheTTL = 60 } = ctx
let slowImageServer let slowImageServer
beforeAll(async () => { beforeAll(async () => {
slowImageServer = await serveSlowImage() slowImageServer = await serveSlowImage()
...@@ -266,7 +267,7 @@ export function runTests(ctx) { ...@@ -266,7 +267,7 @@ export function runTests(ctx) {
expect(res.status).toBe(200) expect(res.status).toBe(200)
expect(res.headers.get('Content-Type')).toContain('image/x-icon') expect(res.headers.get('Content-Type')).toContain('image/x-icon')
expect(res.headers.get('Cache-Control')).toBe( expect(res.headers.get('Cache-Control')).toBe(
`public, max-age=0, must-revalidate` `public, max-age=${isDev ? 0 : minimumCacheTTL}, must-revalidate`
) )
expect(res.headers.get('Vary')).toMatch(/^Accept(,|$)/) expect(res.headers.get('Vary')).toMatch(/^Accept(,|$)/)
expect(res.headers.get('etag')).toBeTruthy() expect(res.headers.get('etag')).toBeTruthy()
...@@ -290,7 +291,7 @@ export function runTests(ctx) { ...@@ -290,7 +291,7 @@ export function runTests(ctx) {
expect(res.status).toBe(200) expect(res.status).toBe(200)
expect(res.headers.get('Content-Type')).toContain('image/jpeg') expect(res.headers.get('Content-Type')).toContain('image/jpeg')
expect(res.headers.get('Cache-Control')).toBe( expect(res.headers.get('Cache-Control')).toBe(
`public, max-age=0, must-revalidate` `public, max-age=${isDev ? 0 : minimumCacheTTL}, must-revalidate`
) )
expect(res.headers.get('Vary')).toBe('Accept') expect(res.headers.get('Vary')).toBe('Accept')
expect(res.headers.get('etag')).toBeTruthy() expect(res.headers.get('etag')).toBeTruthy()
...@@ -308,7 +309,7 @@ export function runTests(ctx) { ...@@ -308,7 +309,7 @@ export function runTests(ctx) {
expect(res.status).toBe(200) expect(res.status).toBe(200)
expect(res.headers.get('Content-Type')).toContain('image/png') expect(res.headers.get('Content-Type')).toContain('image/png')
expect(res.headers.get('Cache-Control')).toBe( expect(res.headers.get('Cache-Control')).toBe(
`public, max-age=0, must-revalidate` `public, max-age=${isDev ? 0 : minimumCacheTTL}, must-revalidate`
) )
expect(res.headers.get('Vary')).toBe('Accept') expect(res.headers.get('Vary')).toBe('Accept')
expect(res.headers.get('etag')).toBeTruthy() expect(res.headers.get('etag')).toBeTruthy()
...@@ -326,7 +327,7 @@ export function runTests(ctx) { ...@@ -326,7 +327,7 @@ export function runTests(ctx) {
expect(res.status).toBe(200) expect(res.status).toBe(200)
expect(res.headers.get('Content-Type')).toContain('image/jpeg') expect(res.headers.get('Content-Type')).toContain('image/jpeg')
expect(res.headers.get('Cache-Control')).toBe( expect(res.headers.get('Cache-Control')).toBe(
`public, max-age=0, must-revalidate` `public, max-age=${isDev ? 0 : minimumCacheTTL}, must-revalidate`
) )
expect(res.headers.get('Vary')).toBe('Accept') expect(res.headers.get('Vary')).toBe('Accept')
expect(res.headers.get('etag')).toBeTruthy() expect(res.headers.get('etag')).toBeTruthy()
...@@ -346,7 +347,7 @@ export function runTests(ctx) { ...@@ -346,7 +347,7 @@ export function runTests(ctx) {
expect(res.status).toBe(200) expect(res.status).toBe(200)
expect(res.headers.get('Content-Type')).toContain('image/jpeg') expect(res.headers.get('Content-Type')).toContain('image/jpeg')
expect(res.headers.get('Cache-Control')).toBe( expect(res.headers.get('Cache-Control')).toBe(
`public, max-age=0, must-revalidate` `public, max-age=${isDev ? 0 : minimumCacheTTL}, must-revalidate`
) )
expect(res.headers.get('Vary')).toBe('Accept') expect(res.headers.get('Vary')).toBe('Accept')
expect(res.headers.get('etag')).toBeTruthy() expect(res.headers.get('etag')).toBeTruthy()
...@@ -449,7 +450,7 @@ export function runTests(ctx) { ...@@ -449,7 +450,7 @@ export function runTests(ctx) {
expect(res.status).toBe(200) expect(res.status).toBe(200)
expect(res.headers.get('Content-Type')).toBe('image/webp') expect(res.headers.get('Content-Type')).toBe('image/webp')
expect(res.headers.get('Cache-Control')).toBe( expect(res.headers.get('Cache-Control')).toBe(
`public, max-age=0, must-revalidate` `public, max-age=${isDev ? 0 : minimumCacheTTL}, must-revalidate`
) )
expect(res.headers.get('Vary')).toBe('Accept') expect(res.headers.get('Vary')).toBe('Accept')
expect(res.headers.get('etag')).toBeTruthy() expect(res.headers.get('etag')).toBeTruthy()
...@@ -466,7 +467,7 @@ export function runTests(ctx) { ...@@ -466,7 +467,7 @@ export function runTests(ctx) {
expect(res.status).toBe(200) expect(res.status).toBe(200)
expect(res.headers.get('Content-Type')).toBe('image/png') expect(res.headers.get('Content-Type')).toBe('image/png')
expect(res.headers.get('Cache-Control')).toBe( expect(res.headers.get('Cache-Control')).toBe(
`public, max-age=0, must-revalidate` `public, max-age=${isDev ? 0 : minimumCacheTTL}, must-revalidate`
) )
expect(res.headers.get('Vary')).toBe('Accept') expect(res.headers.get('Vary')).toBe('Accept')
expect(res.headers.get('etag')).toBeTruthy() expect(res.headers.get('etag')).toBeTruthy()
...@@ -483,7 +484,7 @@ export function runTests(ctx) { ...@@ -483,7 +484,7 @@ export function runTests(ctx) {
expect(res.status).toBe(200) expect(res.status).toBe(200)
expect(res.headers.get('Content-Type')).toBe('image/png') expect(res.headers.get('Content-Type')).toBe('image/png')
expect(res.headers.get('Cache-Control')).toBe( expect(res.headers.get('Cache-Control')).toBe(
`public, max-age=0, must-revalidate` `public, max-age=${isDev ? 0 : minimumCacheTTL}, must-revalidate`
) )
expect(res.headers.get('Vary')).toBe('Accept') expect(res.headers.get('Vary')).toBe('Accept')
expect(res.headers.get('etag')).toBeTruthy() expect(res.headers.get('etag')).toBeTruthy()
...@@ -500,7 +501,7 @@ export function runTests(ctx) { ...@@ -500,7 +501,7 @@ export function runTests(ctx) {
expect(res.status).toBe(200) expect(res.status).toBe(200)
expect(res.headers.get('Content-Type')).toBe('image/gif') expect(res.headers.get('Content-Type')).toBe('image/gif')
expect(res.headers.get('Cache-Control')).toBe( expect(res.headers.get('Cache-Control')).toBe(
`public, max-age=0, must-revalidate` `public, max-age=${isDev ? 0 : minimumCacheTTL}, must-revalidate`
) )
expect(res.headers.get('Vary')).toBe('Accept') expect(res.headers.get('Vary')).toBe('Accept')
expect(res.headers.get('etag')).toBeTruthy() expect(res.headers.get('etag')).toBeTruthy()
...@@ -517,7 +518,7 @@ export function runTests(ctx) { ...@@ -517,7 +518,7 @@ export function runTests(ctx) {
expect(res.status).toBe(200) expect(res.status).toBe(200)
expect(res.headers.get('Content-Type')).toBe('image/tiff') expect(res.headers.get('Content-Type')).toBe('image/tiff')
expect(res.headers.get('Cache-Control')).toBe( expect(res.headers.get('Cache-Control')).toBe(
`public, max-age=0, must-revalidate` `public, max-age=${isDev ? 0 : minimumCacheTTL}, must-revalidate`
) )
expect(res.headers.get('Vary')).toBe('Accept') expect(res.headers.get('Vary')).toBe('Accept')
expect(res.headers.get('etag')).toBeTruthy() expect(res.headers.get('etag')).toBeTruthy()
...@@ -536,7 +537,7 @@ export function runTests(ctx) { ...@@ -536,7 +537,7 @@ export function runTests(ctx) {
expect(res.status).toBe(200) expect(res.status).toBe(200)
expect(res.headers.get('Content-Type')).toBe('image/webp') expect(res.headers.get('Content-Type')).toBe('image/webp')
expect(res.headers.get('Cache-Control')).toBe( expect(res.headers.get('Cache-Control')).toBe(
`public, max-age=0, must-revalidate` `public, max-age=${isDev ? 0 : minimumCacheTTL}, must-revalidate`
) )
expect(res.headers.get('Vary')).toBe('Accept') expect(res.headers.get('Vary')).toBe('Accept')
expect(res.headers.get('etag')).toBeTruthy() expect(res.headers.get('etag')).toBeTruthy()
...@@ -558,7 +559,7 @@ export function runTests(ctx) { ...@@ -558,7 +559,7 @@ export function runTests(ctx) {
expect(res.status).toBe(200) expect(res.status).toBe(200)
expect(res.headers.get('Content-Type')).toBe('image/avif') expect(res.headers.get('Content-Type')).toBe('image/avif')
expect(res.headers.get('Cache-Control')).toBe( expect(res.headers.get('Cache-Control')).toBe(
`public, max-age=0, must-revalidate` `public, max-age=${isDev ? 0 : minimumCacheTTL}, must-revalidate`
) )
expect(res.headers.get('Vary')).toBe('Accept') expect(res.headers.get('Vary')).toBe('Accept')
expect(res.headers.get('etag')).toBeTruthy() expect(res.headers.get('etag')).toBeTruthy()
...@@ -592,7 +593,7 @@ export function runTests(ctx) { ...@@ -592,7 +593,7 @@ export function runTests(ctx) {
expect(res.status).toBe(200) expect(res.status).toBe(200)
expect(res.headers.get('Content-Type')).toBe('image/webp') expect(res.headers.get('Content-Type')).toBe('image/webp')
expect(res.headers.get('Cache-Control')).toBe( expect(res.headers.get('Cache-Control')).toBe(
`public, max-age=0, must-revalidate` `public, max-age=${isDev ? 0 : minimumCacheTTL}, must-revalidate`
) )
expect(res.headers.get('Vary')).toBe('Accept') expect(res.headers.get('Vary')).toBe('Accept')
expect(res.headers.get('etag')).toBeTruthy() expect(res.headers.get('etag')).toBeTruthy()
...@@ -615,7 +616,7 @@ export function runTests(ctx) { ...@@ -615,7 +616,7 @@ export function runTests(ctx) {
expect(res.status).toBe(200) expect(res.status).toBe(200)
expect(res.headers.get('Content-Type')).toBe('image/webp') expect(res.headers.get('Content-Type')).toBe('image/webp')
expect(res.headers.get('Cache-Control')).toBe( expect(res.headers.get('Cache-Control')).toBe(
`public, max-age=0, must-revalidate` `public, max-age=${isDev ? 0 : minimumCacheTTL}, must-revalidate`
) )
expect(res.headers.get('Vary')).toBe('Accept') expect(res.headers.get('Vary')).toBe('Accept')
expect(res.headers.get('etag')).toBeTruthy() expect(res.headers.get('etag')).toBeTruthy()
...@@ -955,7 +956,7 @@ export function runTests(ctx) { ...@@ -955,7 +956,7 @@ export function runTests(ctx) {
expect(res1.status).toBe(200) expect(res1.status).toBe(200)
expect(res1.headers.get('Content-Type')).toBe('image/webp') expect(res1.headers.get('Content-Type')).toBe('image/webp')
expect(res1.headers.get('Cache-Control')).toBe( expect(res1.headers.get('Cache-Control')).toBe(
`public, max-age=0, must-revalidate` `public, max-age=${isDev ? 0 : minimumCacheTTL}, must-revalidate`
) )
expect(res1.headers.get('Vary')).toBe('Accept') expect(res1.headers.get('Vary')).toBe('Accept')
const etag = res1.headers.get('Etag') const etag = res1.headers.get('Etag')
...@@ -971,7 +972,7 @@ export function runTests(ctx) { ...@@ -971,7 +972,7 @@ export function runTests(ctx) {
expect(res2.headers.get('Content-Type')).toBeFalsy() expect(res2.headers.get('Content-Type')).toBeFalsy()
expect(res2.headers.get('Etag')).toBe(etag) expect(res2.headers.get('Etag')).toBe(etag)
expect(res2.headers.get('Cache-Control')).toBe( expect(res2.headers.get('Cache-Control')).toBe(
`public, max-age=0, must-revalidate` `public, max-age=${isDev ? 0 : minimumCacheTTL}, must-revalidate`
) )
expect(res2.headers.get('Vary')).toBe('Accept') expect(res2.headers.get('Vary')).toBe('Accept')
expect(res2.headers.get('Content-Disposition')).toBeFalsy() expect(res2.headers.get('Content-Disposition')).toBeFalsy()
...@@ -982,7 +983,7 @@ export function runTests(ctx) { ...@@ -982,7 +983,7 @@ export function runTests(ctx) {
expect(res3.status).toBe(200) expect(res3.status).toBe(200)
expect(res3.headers.get('Content-Type')).toBe('image/webp') expect(res3.headers.get('Content-Type')).toBe('image/webp')
expect(res3.headers.get('Cache-Control')).toBe( expect(res3.headers.get('Cache-Control')).toBe(
`public, max-age=0, must-revalidate` `public, max-age=${isDev ? 0 : minimumCacheTTL}, must-revalidate`
) )
expect(res3.headers.get('Vary')).toBe('Accept') expect(res3.headers.get('Vary')).toBe('Accept')
expect(res3.headers.get('Etag')).toBeTruthy() expect(res3.headers.get('Etag')).toBeTruthy()
...@@ -1003,7 +1004,7 @@ export function runTests(ctx) { ...@@ -1003,7 +1004,7 @@ export function runTests(ctx) {
expect(res.status).toBe(200) expect(res.status).toBe(200)
expect(res.headers.get('Content-Type')).toBe('image/bmp') expect(res.headers.get('Content-Type')).toBe('image/bmp')
expect(res.headers.get('Cache-Control')).toBe( expect(res.headers.get('Cache-Control')).toBe(
`public, max-age=0, must-revalidate` `public, max-age=${isDev ? 0 : minimumCacheTTL}, must-revalidate`
) )
// bmp is compressible so will have accept-encoding set from // bmp is compressible so will have accept-encoding set from
// compression // compression
...@@ -1030,7 +1031,7 @@ export function runTests(ctx) { ...@@ -1030,7 +1031,7 @@ export function runTests(ctx) {
expect(res.status).toBe(200) expect(res.status).toBe(200)
expect(res.headers.get('Content-Type')).toBe('image/webp') expect(res.headers.get('Content-Type')).toBe('image/webp')
expect(res.headers.get('Cache-Control')).toBe( expect(res.headers.get('Cache-Control')).toBe(
`public, max-age=0, must-revalidate` `public, max-age=${isDev ? 0 : minimumCacheTTL}, must-revalidate`
) )
expect(res.headers.get('Vary')).toBe('Accept') expect(res.headers.get('Vary')).toBe('Accept')
expect(res.headers.get('etag')).toBeTruthy() expect(res.headers.get('etag')).toBeTruthy()
...@@ -1052,7 +1053,7 @@ export function runTests(ctx) { ...@@ -1052,7 +1053,7 @@ export function runTests(ctx) {
expect(res.status).toBe(200) expect(res.status).toBe(200)
expect(res.headers.get('Content-Type')).toBe('image/png') expect(res.headers.get('Content-Type')).toBe('image/png')
expect(res.headers.get('Cache-Control')).toBe( expect(res.headers.get('Cache-Control')).toBe(
`public, max-age=0, must-revalidate` `public, max-age=${isDev ? 0 : minimumCacheTTL}, must-revalidate`
) )
expect(res.headers.get('Vary')).toBe('Accept') expect(res.headers.get('Vary')).toBe('Accept')
expect(res.headers.get('Content-Disposition')).toBe( expect(res.headers.get('Content-Disposition')).toBe(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment