Unverified Commit f01457e8 authored by Tim Neutkens's avatar Tim Neutkens Committed by GitHub

Take full advantage of caching between builds (#5597)

Takes advantage of caching between builds for Terser, also makes writing caches for babel-loader faster by disabling compression.

Results for zeit.co (350 pages):

Without cache:
[4:16:22 PM] Compiled server in 1m
[4:16:57 PM] Compiled client in 2m
✨  Done in 125.83s.

With cache:
[4:19:38 PM] Compiled client in 17s
[4:19:50 PM] Compiled server in 29s
✨  Done in 31.79s.

Note: these results are from my multi-core Macbook Pro 2017, exact specs:
MacBook Pro (13-inch, 2017, Four Thunderbolt 3 Ports)
- 3,3 GHz Intel Core i5
- 16 GB 2133 MHz LPDDR3
- Intel Iris Plus Graphics 650 1536 MB

The `without cache` build runs uglify in parallel, so without cache is likely to take longer on environments where you have only 1 core available.

The `with cache` build however runs in a single thread, so the results should be similar.
parent 3c1c972b
...@@ -94,11 +94,19 @@ function optimizationConfig ({dir, dev, isServer, totalPages}) { ...@@ -94,11 +94,19 @@ function optimizationConfig ({dir, dev, isServer, totalPages}) {
} }
// Terser is a better uglifier // Terser is a better uglifier
config.minimizer = [new TerserPlugin({ config.minimizer = [
parallel: true, new TerserPlugin({
sourceMap: false, parallel: true,
cache: true sourceMap: false,
})] cache: true,
cacheKeys: (keys) => {
// path changes per build because we add buildId
// because the input is already hashed the path is not needed
delete keys.path
return keys
}
})
]
// Only enabled in production // Only enabled in production
// This logic will create a commons bundle // This logic will create a commons bundle
...@@ -268,6 +276,7 @@ export default async function getBaseWebpackConfig (dir: string, {dev = false, i ...@@ -268,6 +276,7 @@ export default async function getBaseWebpackConfig (dir: string, {dev = false, i
dev && new webpack.NoEmitOnErrorsPlugin(), dev && new webpack.NoEmitOnErrorsPlugin(),
dev && new UnlinkFilePlugin(), dev && new UnlinkFilePlugin(),
dev && new CaseSensitivePathPlugin(), // Since on macOS the filesystem is case-insensitive this will make sure your path are case-sensitive dev && new CaseSensitivePathPlugin(), // Since on macOS the filesystem is case-insensitive this will make sure your path are case-sensitive
!dev && new webpack.HashedModuleIdsPlugin(),
// Removes server/client code by minifier // Removes server/client code by minifier
new webpack.DefinePlugin({ new webpack.DefinePlugin({
'process.browser': JSON.stringify(!isServer) 'process.browser': JSON.stringify(!isServer)
......
...@@ -12,6 +12,7 @@ module.exports = babelLoader.custom(babel => { ...@@ -12,6 +12,7 @@ module.exports = babelLoader.custom(babel => {
dev: opts.dev dev: opts.dev
} }
const loader = Object.assign({ const loader = Object.assign({
cacheCompression: false,
cacheDirectory: true cacheDirectory: true
}, opts) }, opts)
delete loader.isServer delete loader.isServer
......
...@@ -66,6 +66,6 @@ describe('Production response size', () => { ...@@ -66,6 +66,6 @@ describe('Production response size', () => {
console.log(`Response Sizes:\n${responseSizes.map(obj => ` ${obj.url}: ${obj.bytes} (bytes)`).join('\n')} \nOverall: ${responseSizeKilobytes} KB`) console.log(`Response Sizes:\n${responseSizes.map(obj => ` ${obj.url}: ${obj.bytes} (bytes)`).join('\n')} \nOverall: ${responseSizeKilobytes} KB`)
// These numbers are without gzip compression! // These numbers are without gzip compression!
expect(responseSizeKilobytes).toBeLessThanOrEqual(203) // Kilobytes expect(responseSizeKilobytes).toBeLessThanOrEqual(207) // Kilobytes
}) })
}) })
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment