Unverified Commit f37a4545 authored by Jiachi Liu's avatar Jiachi Liu Committed by GitHub

fix: enable new overlay properly when env var is set (#75747)

parent 7cb21cbe
...@@ -288,11 +288,7 @@ export function getDefineEnv({ ...@@ -288,11 +288,7 @@ export function getDefineEnv({
} }
: undefined), : undefined),
'process.env.__NEXT_EXPERIMENTAL_NEW_DEV_OVERLAY': 'process.env.__NEXT_EXPERIMENTAL_NEW_DEV_OVERLAY':
// When `__NEXT_EXPERIMENTAL_NEW_DEV_OVERLAY` is set on CI, config.experimental.newDevOverlay || false,
// we need to pass it here so it can be enabled.
process.env.__NEXT_EXPERIMENTAL_NEW_DEV_OVERLAY === 'true' ||
config.experimental.newDevOverlay ||
false,
'process.env.__NEXT_REACT_OWNER_STACK': 'process.env.__NEXT_REACT_OWNER_STACK':
config.experimental.reactOwnerStack ?? false, config.experimental.reactOwnerStack ?? false,
} }
......
...@@ -440,13 +440,6 @@ function assignDefaults( ...@@ -440,13 +440,6 @@ function assignDefaults(
} }
} }
// TODO(jiwon): remove once we've made new UI default
// Enable reactOwnerStack when newDevOverlay is enabled to have
// better call stack output in the new UI.
if (result.experimental?.newDevOverlay) {
result.experimental.reactOwnerStack = true
}
warnCustomizedOption( warnCustomizedOption(
result, result,
'experimental.esmExternals', 'experimental.esmExternals',
...@@ -926,6 +919,17 @@ function assignDefaults( ...@@ -926,6 +919,17 @@ function assignDefaults(
if (!result.experimental) { if (!result.experimental) {
result.experimental = {} result.experimental = {}
} }
// TODO(jiwon): remove once we've made new UI default
// Enable reactOwnerStack when newDevOverlay is enabled to have
// better call stack output in the new UI.
if (process.env.__NEXT_EXPERIMENTAL_NEW_DEV_OVERLAY === 'true') {
result.experimental.newDevOverlay = true
}
if (result.experimental.newDevOverlay) {
result.experimental.reactOwnerStack = true
}
result.experimental.optimizePackageImports = [ result.experimental.optimizePackageImports = [
...new Set([ ...new Set([
...userProvidedOptimizePackageImports, ...userProvidedOptimizePackageImports,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment