Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
N
next.js
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Alex
next.js
Commits
f37a4545
Unverified
Commit
f37a4545
authored
Feb 06, 2025
by
Jiachi Liu
Committed by
GitHub
Feb 06, 2025
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix: enable new overlay properly when env var is set (#75747)
parent
7cb21cbe
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
12 additions
and
12 deletions
+12
-12
define-env-plugin.ts
packages/next/src/build/webpack/plugins/define-env-plugin.ts
+1
-5
config.ts
packages/next/src/server/config.ts
+11
-7
No files found.
packages/next/src/build/webpack/plugins/define-env-plugin.ts
View file @
f37a4545
...
@@ -288,11 +288,7 @@ export function getDefineEnv({
...
@@ -288,11 +288,7 @@ export function getDefineEnv({
}
}
:
undefined
),
:
undefined
),
'process.env.__NEXT_EXPERIMENTAL_NEW_DEV_OVERLAY'
:
'process.env.__NEXT_EXPERIMENTAL_NEW_DEV_OVERLAY'
:
// When `__NEXT_EXPERIMENTAL_NEW_DEV_OVERLAY` is set on CI,
config
.
experimental
.
newDevOverlay
||
false
,
// we need to pass it here so it can be enabled.
process
.
env
.
__NEXT_EXPERIMENTAL_NEW_DEV_OVERLAY
===
'true'
||
config
.
experimental
.
newDevOverlay
||
false
,
'process.env.__NEXT_REACT_OWNER_STACK'
:
'process.env.__NEXT_REACT_OWNER_STACK'
:
config
.
experimental
.
reactOwnerStack
??
false
,
config
.
experimental
.
reactOwnerStack
??
false
,
}
}
...
...
packages/next/src/server/config.ts
View file @
f37a4545
...
@@ -440,13 +440,6 @@ function assignDefaults(
...
@@ -440,13 +440,6 @@ function assignDefaults(
}
}
}
}
// TODO(jiwon): remove once we've made new UI default
// Enable reactOwnerStack when newDevOverlay is enabled to have
// better call stack output in the new UI.
if
(
result
.
experimental
?.
newDevOverlay
)
{
result
.
experimental
.
reactOwnerStack
=
true
}
warnCustomizedOption
(
warnCustomizedOption
(
result
,
result
,
'experimental.esmExternals'
,
'experimental.esmExternals'
,
...
@@ -926,6 +919,17 @@ function assignDefaults(
...
@@ -926,6 +919,17 @@ function assignDefaults(
if
(
!
result
.
experimental
)
{
if
(
!
result
.
experimental
)
{
result
.
experimental
=
{}
result
.
experimental
=
{}
}
}
// TODO(jiwon): remove once we've made new UI default
// Enable reactOwnerStack when newDevOverlay is enabled to have
// better call stack output in the new UI.
if
(
process
.
env
.
__NEXT_EXPERIMENTAL_NEW_DEV_OVERLAY
===
'true'
)
{
result
.
experimental
.
newDevOverlay
=
true
}
if
(
result
.
experimental
.
newDevOverlay
)
{
result
.
experimental
.
reactOwnerStack
=
true
}
result
.
experimental
.
optimizePackageImports
=
[
result
.
experimental
.
optimizePackageImports
=
[
...
new
Set
([
...
new
Set
([
...
userProvidedOptimizePackageImports
,
...
userProvidedOptimizePackageImports
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment