Unverified Commit f530b0d3 authored by Tobias Koppers's avatar Tobias Koppers Committed by GitHub

only listen to drain even once (#29885)

gets rid of `(node:670) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 drain listeners added to [WriteStream]. Use emitter.setMaxListeners() to increase limit`
parent a002f612
...@@ -18,7 +18,8 @@ class RotatingWriteStream { ...@@ -18,7 +18,8 @@ class RotatingWriteStream {
writeStream!: fs.WriteStream writeStream!: fs.WriteStream
size: number size: number
sizeLimit: number sizeLimit: number
isRotating: Promise<void> | undefined private rotatePromise: Promise<void> | undefined
private drainPromise: Promise<void> | undefined
constructor(file: string, sizeLimit: number) { constructor(file: string, sizeLimit: number) {
this.file = file this.file = file
this.size = 0 this.size = 0
...@@ -29,8 +30,8 @@ class RotatingWriteStream { ...@@ -29,8 +30,8 @@ class RotatingWriteStream {
this.writeStream = fs.createWriteStream(this.file, writeStreamOptions) this.writeStream = fs.createWriteStream(this.file, writeStreamOptions)
} }
// Recreate the file // Recreate the file
private rotate(): void { private async rotate() {
this.end() await this.end()
try { try {
fs.unlinkSync(this.file) fs.unlinkSync(this.file)
} catch (err: any) { } catch (err: any) {
...@@ -41,23 +42,33 @@ class RotatingWriteStream { ...@@ -41,23 +42,33 @@ class RotatingWriteStream {
} }
this.size = 0 this.size = 0
this.createWriteStream() this.createWriteStream()
this.rotatePromise = undefined
} }
async write(data: string): Promise<void> { async write(data: string): Promise<void> {
this.size += data.length if (this.rotatePromise) await this.rotatePromise
this.size += data.length
if (this.size > this.sizeLimit) { if (this.size > this.sizeLimit) {
this.rotate() await (this.rotatePromise = this.rotate())
} }
if (!this.writeStream.write(data, 'utf8')) { if (!this.writeStream.write(data, 'utf8')) {
await new Promise<void>((resolve, _reject) => { if (this.drainPromise === undefined) {
this.writeStream.once('drain', resolve) this.drainPromise = new Promise<void>((resolve, _reject) => {
}) this.writeStream.once('drain', () => {
this.drainPromise = undefined
resolve()
})
})
}
await this.drainPromise
} }
} }
end(): void { end(): Promise<void> {
this.writeStream.end('', 'utf8') return new Promise((resolve) => {
this.writeStream.end(resolve)
})
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment