Unverified Commit f55359ff authored by Tobias Koppers's avatar Tobias Koppers Committed by GitHub

Avoid skipping the required Test Codemods job (#49589)

A required CI check can't be skipped. Otherwise this leads to kodiak
stalling forever on these PRs:

<img width="515" alt="image"
src="https://github.com/vercel/next.js/assets/1365881/142f0f77-1fe1-445c-bdff-1cf7957ebe3e">
parent ba4c2f2b
...@@ -672,7 +672,6 @@ jobs: ...@@ -672,7 +672,6 @@ jobs:
name: Test Codemods name: Test Codemods
runs-on: ubuntu-latest runs-on: ubuntu-latest
needs: [build] needs: [build]
if: ${{ needs.build.outputs.codemodChange == 'yup' }}
timeout-minutes: 5 timeout-minutes: 5
env: env:
NEXT_TELEMETRY_DISABLED: 1 NEXT_TELEMETRY_DISABLED: 1
...@@ -683,9 +682,11 @@ jobs: ...@@ -683,9 +682,11 @@ jobs:
# https://github.com/actions/virtual-environments/issues/1187 # https://github.com/actions/virtual-environments/issues/1187
- name: tune linux network - name: tune linux network
if: ${{ needs.build.outputs.codemodChange == 'yup' }}
run: sudo ethtool -K eth0 tx off rx off run: sudo ethtool -K eth0 tx off rx off
- uses: actions/cache@v3 - uses: actions/cache@v3
if: ${{ needs.build.outputs.codemodChange == 'yup' }}
timeout-minutes: 5 timeout-minutes: 5
id: restore-build id: restore-build
with: with:
...@@ -693,6 +694,7 @@ jobs: ...@@ -693,6 +694,7 @@ jobs:
key: ${{ github.sha }}-${{ github.run_number }} key: ${{ github.sha }}-${{ github.run_number }}
- name: Run tests - name: Run tests
if: ${{ needs.build.outputs.codemodChange == 'yup' }}
run: docker run --rm -v $(pwd):/work mcr.microsoft.com/playwright:v1.28.1-jammy /bin/bash -c "cd /work && NODE_VERSION=${{ env.NODE_LTS_VERSION }} ./scripts/setup-node.sh && npm i -g pnpm@${PNPM_VERSION} > /dev/null && cd ./packages/next-codemod && pnpm build && pnpm test >> /proc/1/fd/1" run: docker run --rm -v $(pwd):/work mcr.microsoft.com/playwright:v1.28.1-jammy /bin/bash -c "cd /work && NODE_VERSION=${{ env.NODE_LTS_VERSION }} ./scripts/setup-node.sh && npm i -g pnpm@${PNPM_VERSION} > /dev/null && cd ./packages/next-codemod && pnpm build && pnpm test >> /proc/1/fd/1"
testIntegration: testIntegration:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment