Unverified Commit f81ba18c authored by Hendrik Liebau's avatar Hendrik Liebau Committed by GitHub

Run nightly bundler integration tests also with React 18 (#76606)

While #76544 doesn't hurt, this is the more important fix to ensure that
tests that were previously marked as `failed` are only promoted to
`passed` if they also pass when the test is run with React 18.
parent 69116fdc
...@@ -86,6 +86,8 @@ jobs: ...@@ -86,6 +86,8 @@ jobs:
fail-fast: false fail-fast: false
matrix: matrix:
group: ${{ fromJSON(needs.generate-matrices.outputs.e2e) }} group: ${{ fromJSON(needs.generate-matrices.outputs.e2e) }}
# Empty value uses default
react: ['', '18.3.1']
uses: ./.github/workflows/build_reusable.yml uses: ./.github/workflows/build_reusable.yml
with: with:
afterBuild: | afterBuild: |
...@@ -93,6 +95,7 @@ jobs: ...@@ -93,6 +95,7 @@ jobs:
export NEXT_TEST_CONTINUE_ON_ERROR=TRUE export NEXT_TEST_CONTINUE_ON_ERROR=TRUE
export NEXT_E2E_TEST_TIMEOUT=240000 export NEXT_E2E_TEST_TIMEOUT=240000
export NEXT_TEST_REACT_VERSION=${{ matrix.react }}
export NEXT_TEST_MODE=${{ export NEXT_TEST_MODE=${{
inputs.test_type == 'development' && 'dev' || 'start' inputs.test_type == 'development' && 'dev' || 'start'
}} }}
...@@ -119,6 +122,8 @@ jobs: ...@@ -119,6 +122,8 @@ jobs:
fail-fast: false fail-fast: false
matrix: matrix:
group: ${{ fromJSON(needs.generate-matrices.outputs.integration) }} group: ${{ fromJSON(needs.generate-matrices.outputs.integration) }}
# Empty value uses default
react: ['', '18.3.1']
uses: ./.github/workflows/build_reusable.yml uses: ./.github/workflows/build_reusable.yml
with: with:
nodeVersion: 18.18.2 nodeVersion: 18.18.2
...@@ -127,6 +132,7 @@ jobs: ...@@ -127,6 +132,7 @@ jobs:
export NEXT_TEST_CONTINUE_ON_ERROR=TRUE export NEXT_TEST_CONTINUE_ON_ERROR=TRUE
export NEXT_E2E_TEST_TIMEOUT=240000 export NEXT_E2E_TEST_TIMEOUT=240000
export NEXT_TEST_REACT_VERSION=${{ matrix.react }}
# HACK: Despite the name, these environment variables are just used to # HACK: Despite the name, these environment variables are just used to
# gate tests, so they're applicable to both turbopack and rspack tests # gate tests, so they're applicable to both turbopack and rspack tests
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment