Unverified Commit fa5d41b3 authored by Jamie's avatar Jamie Committed by GitHub

fix: replace usage of `fromEntries` in browser bundled `resolve-rewrites.ts` (#25208)



## Bug

- [x] Related issues linked using `fixes #number`
- [ ] Integration tests added

Fixes #25207

Currently rewritten routes that use a `has` condition throw an `Object.fromEntries is not a function` error in older browsers.

## Documentation / Examples

- [x] Make sure the linting passes

## Solution

As mentioned in issue #25207, looks like last year the team decided not to include the `fromEntries` polyfill https://github.com/vercel/next.js/pull/15772#discussion_r463957221.

As such, we should avoid using non-polyfilled methods in core next.js code bundled in the browser.

This PR's changes should result in the same object being returned, without using `fromEntries`.
parent ac7c8f35
...@@ -43,12 +43,13 @@ export default function resolveRewrites( ...@@ -43,12 +43,13 @@ export default function resolveRewrites(
headers: { headers: {
host: document.location.hostname, host: document.location.hostname,
}, },
cookies: Object.fromEntries( cookies: document.cookie
document.cookie.split('; ').map((item) => { .split('; ')
.reduce<Record<string, string>>((acc, item) => {
const [key, ...value] = item.split('=') const [key, ...value] = item.split('=')
return [key, value.join('=')] acc[key] = value.join('=')
}) return acc
), }, {}),
} as any, } as any,
rewrite.has, rewrite.has,
parsedAs.query parsedAs.query
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment