Unverified Commit fc3ef810 authored by JJ Kasper's avatar JJ Kasper Committed by GitHub

Update dev watcher to ignore more accurately (#40412)

This ensures we ignore all except the files/directories we are explicitly wanting to watch to prevent watching/considering directories with massive amounts of files slowing down startup.

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

Fixes: https://github.com/vercel/next.js/pull/38483#issuecomment-1242154665
parent 8bc587aa
...@@ -273,12 +273,10 @@ export default class DevServer extends Server { ...@@ -273,12 +273,10 @@ export default class DevServer extends Server {
}) })
} }
const wp = (this.webpackWatcher = new Watchpack({
ignored: /([/\\]node_modules[/\\]|[/\\]\.next[/\\]|[/\\]\.git[/\\])/,
}))
const pages = this.pagesDir ? [this.pagesDir] : [] const pages = this.pagesDir ? [this.pagesDir] : []
const app = this.appDir ? [this.appDir] : [] const app = this.appDir ? [this.appDir] : []
const directories = [...pages, ...app] const directories = [...pages, ...app]
const files = this.pagesDir const files = this.pagesDir
? getPossibleMiddlewareFilenames( ? getPossibleMiddlewareFilenames(
pathJoin(this.pagesDir, '..'), pathJoin(this.pagesDir, '..'),
...@@ -303,6 +301,15 @@ export default class DevServer extends Server { ...@@ -303,6 +301,15 @@ export default class DevServer extends Server {
] ]
files.push(...tsconfigPaths) files.push(...tsconfigPaths)
const wp = (this.webpackWatcher = new Watchpack({
ignored: (pathname: string) => {
return (
!files.some((file) => file.startsWith(pathname)) &&
!directories.some((dir) => pathname.startsWith(dir))
)
},
}))
wp.watch({ directories: [this.dir], startTime: 0 }) wp.watch({ directories: [this.dir], startTime: 0 })
const fileWatchTimes = new Map() const fileWatchTimes = new Map()
let enabledTypeScript = this.usingTypeScript let enabledTypeScript = this.usingTypeScript
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment