[ci] Fix create_release_branch for new repo permissions (#96641)
### What Fixes the **Create Release Branch** workflow, which currently fails on every run. 1. Drop `permission-environments: write` from the GitHub App token request. - The release App installation no longer grants it, and `actions/create-github-app-token` fails hard on an ungranted permission. 2. Drop the runtime `deployment-branch-policies` API call (and its 5s sleep) from `scripts/create-release-branch.js`. - No longer needed: the `release-stable` environment now statically allows branches conforming to `next-NN` / `next-NN-*`. This is what the permission above existed for. 3. Create the setup commit as a GitHub-signed commit via `scripts/github-utils/signed-commit.js` instead of `git push`. - Branch protection requires signed commits; `git push` pushed an unsigned one. Uses the same `createSignedCommit` + `upsertBranchRef` pattern as `scripts/automated-update-workflow.js`. ### Why The most recent run ([30923742579](https://github.com/vercel/next.js/actions/runs/30923742579/job/92040655448)) dies at the first step, `Create GitHub App token`, with a 422 — so the job never even clones the repo. ### Note for review Release tags are **annotated** tag objects, so `git rev-parse v16.0.0` returns the tag object SHA, not the commit. `createSignedCommit` passes `baseSha` straight into `parents: [...]`, so the base is dereferenced with `^{commit}`. Its internal `^{tree}` lookup happens to resolve either way, so this would otherwise only have failed at commit-creation time during a real release. The static patterns cover `next-16-2`-style names but not a single-digit major like `next-9-5`. Not a concern for current or future releases, but noting it since the previous code created the policy for any branch name. ### Verification The workflow is `workflow_dispatch`-only and writes to the real repo, so it can't be run end-to-end from a PR. Verified locally against the real `v16.0.0` tag in a throwaway clone: - `git reset --hard v16.0.0` leaves HEAD exactly at `v16.0.0^{commit}`, confirming the base SHA is right. - Replaying the lerna.json / `build_and_deploy.yml` / `build_and_test.yml` mutations produces exactly those 3 changed files and nothing else. - Driving `createTreeFromLocalCommit` with a mocked `request` (no network) uploads 3 blobs with correct `100644` modes and a `base_tree` that matches the tag's tree. - `node --check`, prettier, and eslint all clean. Still needs a real `workflow_dispatch` run after merge to confirm the token step succeeds and the resulting commit shows as **Verified**.
Showing
Please
register
or
sign in
to comment