Unverified Commit fcd3fdeb authored by Andrew Clark's avatar Andrew Clark Committed by GitHub

Define the review agent's team as the owners in review/OWNERS (#100927)

REVIEW.md told the review agent to approve only PRs "from human authors
on the Next.js team". Neither half of that was something the agent could
check. It had no list of who is on the team, and it has no way to
confirm that the person behind a GitHub account is human. Taken
literally, the second condition can never be met, so the agent
intermittently withheld approval from PRs it would otherwise approve,
citing that it couldn't prove the author was human.

The team is now defined as the owners listed in review/OWNERS, which the
agent can check directly and which scripts/review-context.mjs already
treats as the team when picking default reviewers. Bots and outside
contributors aren't on that list, so excluding them no longer needs a
separate "human" condition.

The rule also now says outright that a team member's account stands for
that person. The agent shouldn't try to prove the author is human, and
it shouldn't withhold approval because a PR was written with an AI
agent, which is the same refusal in another form.
parent 80d27553
......@@ -4,7 +4,8 @@ Instructions for the agent that reviews PRs in this repo. Humans: see [review/RE
## How this works
- Only approve PRs from human authors on the Next.js team. For anyone else, comment but don't approve.
- Only approve PRs whose author is on the Next.js team: anyone listed as an owner in [`review/OWNERS`](review/OWNERS). For anyone else, comment but don't approve.
- A team member's account stands for that person. Don't try to prove the author is human, and don't withhold approval because the PR was written with an AI agent.
- **Default to approval.** Approve unless the PR's findings add up to an [escalation](#severity).
- Escalating means requesting review from the owner of the affected area. It doesn't block the PR.
- Your approval is one input to CI. Existing checks still must pass.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment