Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
N
next.js
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Alex
next.js
Commits
ffc4f296
Unverified
Commit
ffc4f296
authored
May 18, 2026
by
Hendrik Liebau
Committed by
GitHub
May 18, 2026
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[backport] Patch `playwright-core` to resolve `_finishedPromise` on `requestFailed` (#93920)
Backports: - #93802
parent
bc1791dd
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
32 additions
and
4 deletions
+32
-4
package.json
package.json
+2
-1
playwright-core@1.58.2.patch
patches/playwright-core@1.58.2.patch
+24
-0
pnpm-lock.yaml
pnpm-lock.yaml
+6
-3
No files found.
package.json
View file @
ffc4f296
...
@@ -350,7 +350,8 @@
...
@@ -350,7 +350,8 @@
"@types/node@20.17.6"
:
"patches/@types__node@20.17.6.patch"
,
"@types/node@20.17.6"
:
"patches/@types__node@20.17.6.patch"
,
"taskr@1.1.0"
:
"patches/taskr@1.1.0.patch"
,
"taskr@1.1.0"
:
"patches/taskr@1.1.0.patch"
,
"minizlib@3.1.0"
:
"patches/minizlib@3.1.0.patch"
,
"minizlib@3.1.0"
:
"patches/minizlib@3.1.0.patch"
,
"http-proxy@1.18.1"
:
"patches/http-proxy@1.18.1.patch"
"http-proxy@1.18.1"
:
"patches/http-proxy@1.18.1.patch"
,
"playwright-core@1.58.2"
:
"patches/playwright-core@1.58.2.patch"
}
}
}
}
}
}
patches/playwright-core@1.58.2.patch
0 → 100644
View file @
ffc4f296
diff --git a/lib/client/browserContext.js b/lib/client/browserContext.js
index 0b5cb3356cdc4917d9198a184f1a2cb391924453..3ad3d86bebde7a7e25af4f94b964d003e10d40a0 100644
--- a/lib/client/browserContext.js
+++ b/lib/client/browserContext.js
@@ -183,6 +183,19 @@ class BrowserContext extends import_channelOwner.ChannelOwner {
_onRequestFailed(request, responseEndTiming, failureText, page) {
request._failureText = failureText || null;
request._setResponseEndTiming(responseEndTiming);
+ // PATCH (next.js): mirror what `_onRequestFinished` does for the
+ // response, so callers awaiting `response.finished()` don't hang on
+ // failed/canceled requests. The server side already resolves the
+ // server-side `_finishedPromise` from `_onLoadingFailed` (see
+ // chromium/crNetworkManager.js), but only the `requestFinished` IPC
+ // carries a response payload — `requestFailed` does not, so the
+ // client-side Response's `_finishedPromise` is otherwise never
+ // resolved. We look up the response via the existing async RPC and
+ // resolve it fire-and-forget; catch is a no-op so we never produce
+ // an unhandled rejection if the context tears down concurrently.
+ request.response().then((response) => {
+ if (response !== null) response._finishedPromise.resolve(null);
+ }).catch(() => {});
this.emit(import_events.Events.BrowserContext.RequestFailed, request);
if (page)
page.emit(import_events.Events.Page.RequestFailed, request);
pnpm-lock.yaml
View file @
ffc4f296
...
@@ -34,6 +34,9 @@ patchedDependencies:
...
@@ -34,6 +34,9 @@ patchedDependencies:
minizlib@3.1.0
:
minizlib@3.1.0
:
hash
:
o4nv5mg6kfnuzlknbdln3azhvu
hash
:
o4nv5mg6kfnuzlknbdln3azhvu
path
:
patches/minizlib@3.1.0.patch
path
:
patches/minizlib@3.1.0.patch
playwright-core@1.58.2
:
hash
:
jzsvxuc7w6vcysg5v4e5lyjitq
path
:
patches/playwright-core@1.58.2.patch
stacktrace-parser@0.1.10
:
stacktrace-parser@0.1.10
:
hash
:
x5tdcojc7b5m2b5ojepbcdl36a
hash
:
x5tdcojc7b5m2b5ojepbcdl36a
path
:
patches/stacktrace-parser@0.1.10.patch
path
:
patches/stacktrace-parser@0.1.10.patch
...
@@ -35120,15 +35123,15 @@ snapshots:
...
@@ -35120,15 +35123,15 @@ snapshots:
playwright-chromium@1.58.2
:
playwright-chromium@1.58.2
:
dependencies
:
dependencies
:
playwright-core
:
1.58.2
playwright-core
:
1.58.2
(patch_hash=jzsvxuc7w6vcysg5v4e5lyjitq)
playwright-core@1.51.1
:
{}
playwright-core@1.51.1
:
{}
playwright-core@1.58.2
:
{}
playwright-core@1.58.2
(patch_hash=jzsvxuc7w6vcysg5v4e5lyjitq)
:
{}
playwright@1.58.2
:
playwright@1.58.2
:
dependencies
:
dependencies
:
playwright-core
:
1.58.2
playwright-core
:
1.58.2
(patch_hash=jzsvxuc7w6vcysg5v4e5lyjitq)
optionalDependencies
:
optionalDependencies
:
fsevents
:
2.3.2
fsevents
:
2.3.2
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment