- 13 Jun, 2018 2 commits
-
-
Tim Neutkens authored
-
Lon Ilesanmi authored
- Remove unused imports - Edit some comments - Rename Wrapper App Class
-
- 12 Jun, 2018 1 commit
-
-
James Hegedus authored
* remove `predeploy` scripts from `firebase.json` in favour of `npm` `pre` scripts as they are consistent across `deploy` and `serve` commands. (to revisit once Firebase add support in the `firebase.json` for `preserve`) * update deps * workaround some bug where Babel could not resolve the standard `next/babel` config. Explicitly defining this seems to remove the issue. * closes #4562
-
- 11 Jun, 2018 1 commit
-
-
Tim Neutkens authored
Fixes #4581
-
- 10 Jun, 2018 1 commit
-
-
Telegin Evgeniy authored
Hello! I have got an error while building [gh-pages example](https://github.com/zeit/next.js/tree/canary/examples/gh-pages) with next 6.0.3. I have found solution to use CommonJS modules in `.babelrc` This resolves #4227
-
- 09 Jun, 2018 1 commit
-
-
Rafał Ruciński authored
This fixes a missed bug introduced in #4510. Because the regexp was `/-[^-]*/` and not `/-[^-]*$/`, a wrong part of the filename was being removed: ``` bad: 'foo-bar-0123456789abcdef-0123456789abcdef.js' -> 'foo-0123456789abcdef-0123456789abcdef.js' good: 'foo-bar-0123456789abcdef-0123456789abcdef.js' -> 'foo-bar-0123456789abcdef' ``` By a stroke of luck this didn't affect the existing dynamically generated chunks. To prevent regression I've added unit tests for the function that generates the name. Btw. in the original issue (#4433) I used the right regexp, I just used the wrong regexp in #4510. cc @timneutkens
-
- 08 Jun, 2018 3 commits
-
-
Brice BERNARD authored
We don't need `.data` as `apollo.cache.extract()` returns at least `{}` when cache is empty -
Brice BERNARD authored
We don't pass apolloClient as props, so I removed the check as confusing and always false. see https://github.com/zeit/next.js/blob/canary/examples/with-apollo-auth/lib/withApollo.js#L72-L75 Again please explain me if I am wrong :)
-
Brice BERNARD authored
App component does not need/use apolloState prop, so let's remove it. If I'm wrong please explain me the purpose of this.
-
- 07 Jun, 2018 5 commits
-
-
Pascal Birchler authored
* Fix Access-Control-Request-Method header * Make OPTIONS request work
-
Tim Neutkens authored
React hot loader was removed already, the dependency still had to be removed.
-
Rafał Ruciński authored
Fixes one of the problems described in #4433. The old regexp was removing everything after a hyphen, so with a chunk name like so: ``` chunks/path-to-a-file-[hash].js ``` the saved chunk name was ``` chunks/path ``` This caused problems, because webpack by default changes `/` to `-` in chunk names generated e.g. by ``import(`foo/${bar}`)``. After this change the chunk name will be ``` chunks/path-to-a-file ``` -
Giau Tran Minh authored
* Added example for Ant Design with LESS * Fix ESLINT
-
Robert van Steen authored
Since `_app.js` is used on every page it makes sense to move it's dependencies to the `commons.js` so that if you require a dependency in `_app.js` and in one of your pages it is not included twice in your bundles. This PR modifies the `CommonsChunkPlugin` to move every module that is used in `_app.js` and at least in one other bundle.
-
- 06 Jun, 2018 2 commits
-
-
Eugene Sokovikov authored
**Make amp example valid** I'm using amp validator chrome plugin which shows that `meta charset=utf-8` is duplicated. I assume that `Head` component adds `<meta charset="utf-8" class="next-head next-head">` anyway. And this line just duplicating it. <img width="987" alt="screen shot 2018-06-06 at 15 54 45" src="https://user-images.githubusercontent.com/1488195/41036743-198ca00a-69a2-11e8-978c-5a5cb5a994d2.png">
-
Nick Gauthier authored
Hello! I ran into an issue using typescript and jest with next 6.0.0. I was able to work through fixing it and I wanted to share my solution back to next.js, by upgrading the with-jest-typescript example to next 6.0.0. The steps I followed were: 1. `npx babel-upgrade --write` which added babel-core@^7.0.0-bridge.0 to allow jest's babel 6 to play nice with next's babel 7 2. Remove `ts-jest` and replace with `babel-jest` to use babel to transform the typescript code, as is done when the dev and production builds run 3. Update the babelrc to use commonjs modules in test mode to be compatible with jest Also, I removed the `NODE_ENV=test` on the jest task, because jest sets the env to test anyways, and I'm on windows where this code is incorrect. The other option is to use `cross-env` but I felt it was simpler to just remove the environment override. To my knowledge, this PR would help on the following issues: #3663 #4227 #4531 #4528 #4239
-
- 05 Jun, 2018 1 commit
-
-
Tim Neutkens authored
* Make router properties update when re-rendering * Remove documentation about methods that have been deprecated since v2/v3 * Update next export documentation
-
- 04 Jun, 2018 3 commits
-
-
Tim Neutkens authored
This was spread around the server. Now it's set in one place and passed around.
-
Tim Neutkens authored
-
Tim Neutkens authored
This was pulled from #4518, it can already be merged so it's easier to get it in.
-
- 01 Jun, 2018 3 commits
-
-
Tobi authored
-
Tim Neutkens authored
-
Davor Santic authored
resolves #4115 For now, I just added `'article:tag'` so it could be duplicated if we need more we have to extend: ```javascript const ALLOWED_DUPLICATES = ['article:tag'] ```
-
- 31 May, 2018 3 commits
-
-
Tim Neutkens authored
Previously we called this directory holding the pages/chunks for server rendering `.next/dist` instead of `.next/server` which is confusing both when looking at it and in the codebase, since there's also `distDir` as a configuration option. Also made this a constant in `next/constants` so functionality using this can be easily found.
-
Tim Neutkens authored
-
Tim Neutkens authored
Fixes #4494
-
- 29 May, 2018 4 commits
-
-
Tim Neutkens authored
-
Jorge Cuadra authored
-
Tim Neutkens authored
-
Shu Ding authored
-
- 27 May, 2018 1 commit
-
-
Michał Miszczyszyn authored
Allow `onClick` on `next/link` child. This should not be a breaking change, but it's a very useful feature. Real-life use cases include: analytics or closing menu on navigation, and other. - [x] allow optional `onClick` on `next/link` component's child - [x] call original `child.props.onClick(e)` before `this.linkClicked(e)` - [x] add integration tests - [x] cancel the navigation if `e.defaultPrevented === true` Fixes #1490
-
- 26 May, 2018 1 commit
-
-
daniel tea authored
`idead` to `idea`
-
- 25 May, 2018 8 commits
-
-
Tim Neutkens authored
-
Vlad Nicula authored
Just in case #3345 was a regression and nextjs should still support non webpack node envs for testing.
-
Ari Leo Frankel authored
This accepts arguments to a node --inspect flag as well as other debugging node flags. Resolves #4151
-
andy-viv authored
This PR adds events for when there is a hash-only change in the URL. This is needed because `window.addEventListener('hashchange', ...)` does not work with next.js because it is using pushState. -
Tim Neutkens authored
-
Tim Neutkens authored
-
Robin Wieruch authored
I stumbled into this Issue https://github.com/zeit/next.js/issues/2868 and thought it should be mentioned properly in the documentation.
-
João Granado authored
This fixes the generated page chunk created by the webpack `pages-plugin` which adds a new line in the beginning of the template, when using `output.libraryTarget` set to be [`umd`](https://webpack.js.org/configuration/output/#module-definition-systems) it returns the module. Consider the following example, which is the output with the previous implementation: ```js (function webpackUniversalModuleDefinition(root, factory) { if(typeof exports === 'object' && typeof module === 'object') module.exports = factory(); else if(typeof define === 'function' && define.amd) define([], factory); else if(typeof exports === 'object') exports["MyLibrary"] = factory(); else root["MyLibrary"] = factory(); })(typeof self !== 'undefined' ? self : this, function() { return __NEXT_REGISTER_PAGE(...) }); ``` `__NEXT_REGISTER_PAGE()` won't be executed since a `return` statement followed by a new line is the same as having a semicolon inserted right after the `return`. By removing the new line in the beginning of the source concatenation (which I suppose was added for stylistic reasons) this works as expected.
-