1. 13 Jun, 2018 2 commits
  2. 12 Jun, 2018 1 commit
    • James Hegedus's avatar
      with-firebase-hosting: fix npm scripts, remove firebase.json predeploy scripts (#4593) · 4f4b7a1b
      James Hegedus authored
      * remove `predeploy` scripts from `firebase.json` in favour of `npm` `pre` scripts as they are consistent across `deploy` and `serve` commands. (to revisit once Firebase add support in the `firebase.json` for `preserve`)
      * update deps
      * workaround some bug where Babel could not resolve the standard `next/babel` config. Explicitly defining this seems to remove the issue.
      * closes #4562
      4f4b7a1b
  3. 11 Jun, 2018 1 commit
  4. 10 Jun, 2018 1 commit
  5. 09 Jun, 2018 1 commit
    • Rafał Ruciński's avatar
      Fix a mistake in chunk name generation (#4573) · c74ad93e
      Rafał Ruciński authored
      This fixes a missed bug introduced in #4510.
      
      Because the regexp was `/-[^-]*/` and not `/-[^-]*$/`, a wrong part of the filename was being removed:
      
      ```
      bad:
      'foo-bar-0123456789abcdef-0123456789abcdef.js' -> 'foo-0123456789abcdef-0123456789abcdef.js'
      
      good:
      'foo-bar-0123456789abcdef-0123456789abcdef.js' -> 'foo-bar-0123456789abcdef'
      ```
      
      By a stroke of luck this didn't affect the existing dynamically generated chunks. To prevent regression I've added unit tests for the function that generates the name.
      
      Btw. in the original issue (#4433) I used the right regexp, I just used the wrong regexp in #4510.
      
      cc @timneutkens 
      c74ad93e
  6. 08 Jun, 2018 3 commits
  7. 07 Jun, 2018 5 commits
  8. 06 Jun, 2018 2 commits
    • Eugene Sokovikov's avatar
      stop duplicating charset (#4546) · 3684231a
      Eugene Sokovikov authored
      **Make amp example valid**
      
      I'm using amp validator chrome plugin which shows that `meta charset=utf-8` is duplicated.
      I assume that `Head` component adds `<meta charset="utf-8" class="next-head next-head">`
      anyway.
      And this line just duplicating it.
      
      <img width="987" alt="screen shot 2018-06-06 at 15 54 45" src="https://user-images.githubusercontent.com/1488195/41036743-198ca00a-69a2-11e8-978c-5a5cb5a994d2.png">
      3684231a
    • Nick Gauthier's avatar
      Upgrade with-jest-typescript example to next 6.0.0 (#4543) · bbbf7ab4
      Nick Gauthier authored
      Hello! I ran into an issue using typescript and jest with next 6.0.0. I was able to work through fixing it and I wanted to share my solution back to next.js, by upgrading the with-jest-typescript example to next 6.0.0.
      
      The steps I followed were:
      
      1. `npx babel-upgrade --write` which added babel-core@^7.0.0-bridge.0 to allow jest's babel 6 to play nice with next's babel 7
      2. Remove `ts-jest` and replace with `babel-jest` to use babel to transform the typescript code, as is done when the dev and production builds run
      3. Update the babelrc to use commonjs modules in test mode to be compatible with jest
      
      Also, I removed the `NODE_ENV=test` on the jest task, because jest sets the env to test anyways, and I'm on windows where this code is incorrect. The other option is to use `cross-env` but I felt it was simpler to just remove the environment override.
      
      To my knowledge, this PR would help on the following issues:
      
      #3663 #4227 #4531 #4528 #4239 
      bbbf7ab4
  9. 05 Jun, 2018 1 commit
  10. 04 Jun, 2018 3 commits
  11. 01 Jun, 2018 3 commits
  12. 31 May, 2018 3 commits
  13. 29 May, 2018 4 commits
  14. 27 May, 2018 1 commit
    • Michał Miszczyszyn's avatar
      Allow onClick on next/link component's child (#4474) · 66922526
      Michał Miszczyszyn authored
      Allow `onClick` on `next/link` child. This should not be a breaking change, but it's a very useful feature. Real-life use cases include: analytics or closing menu on navigation, and other.
      
      - [x] allow optional `onClick` on `next/link` component's child
      - [x] call original `child.props.onClick(e)` before `this.linkClicked(e)`
      - [x] add integration tests
      - [x] cancel the navigation if `e.defaultPrevented === true`
      
      Fixes #1490
      66922526
  15. 26 May, 2018 1 commit
  16. 25 May, 2018 8 commits