- 19 Jul, 2018 1 commit
-
-
Tim Neutkens authored
-
- 18 Jul, 2018 2 commits
-
-
Tim Neutkens authored
-
Tim Neutkens authored
-
- 17 Jul, 2018 1 commit
-
-
Lukasz Ostrowski authored
Fixes [this issue](https://github.com/zeit/next.js/issues/4747) I don't know what is the reason why the process does not finish, because it can be reproduced in this repo in many environments (my local mac os and Netlify pipeline). However, it fixes the problem and it's 100% safe.
-
- 15 Jul, 2018 1 commit
-
-
David Calhoun authored
-
- 13 Jul, 2018 3 commits
-
-
Leo Lamprecht authored
As per [this post](https://blog.npmjs.org/post/175824896885/incident-report-npm-inc-operations-incident-of). **This needs to be cherry-picked to master as well.**
-
Tim Neutkens authored
-
Albin Ekblom authored
* Add support for custom App and Component enhancers * Add ctx.renderPage test * Add tests for single enhancer function * Cleanup renderPage options check * Cleanup * Add comment about backwards compatibility for renderPage * Add more test cases
-
- 12 Jul, 2018 1 commit
-
-
Kenneth Luján Rosas authored
As seen on `with-apollo-auth` there are some things that need to be addressed here too. * #4554 remove useless `apolloState` from App props on `getDataFromTree` * #4563 simplify `apolloState` prop Let me know if further changes/fixes are needed. Thank you
🎉
-
- 11 Jul, 2018 4 commits
-
-
James Reggio authored
There are occasions where it is useful to have `target='_blank'` on hyperlinks within your own app. (For example, if your app is being loaded in an iframe and you'd like for the links to break out in to new windows.) With this PR, the `onClick` logic in Link now checks for an external target on the nested <a/> tag, and will fall back to the default behavior if it's present, similar to the logic for shift-/cmd-clicking the link.
-
James Reggio authored
## What's wrong This problem is specific to errors that happen on the client _after_ the initial mounting of the component. (The router has special logic to handle exceptions thrown in `getInitialProps` during a client-side navigation, and I've confirmed this logic is correct.) Specifically, if the page is mounted, and you raise an exception on the page, the exception will cause the error page to be mounted without ever invoking `getInitialProps` on the new App/Error page pairing. This has been illustrated with multiple repros in #4574. ## Why is it broken This regression was introduced two months ago in #4156, where the invocation of `getInitialProps` was removed from the app's top-level error handler. Specifically, [this line](https://github.com/zeit/next.js/pull/4156/files#diff-895656aeaccff5d7c0f56a113ede9662L147) was removed and [replaced by a comment](https://github.com/zeit/next.js/pull/4156/files#diff-895656aeaccff5d7c0f56a113ede9662R167) that says that "`App` will handle the calling of `getInitialProps`". I believe the sentiment about "`App` will handle calling `getInitialProps`" is mistaken. In fact, it really doesn't make sense on its face, since it would require an instance lifecycle method of `App` (which is mounted immediately after the comment) to invoke the `static getInitialProps` method on the error page. ## How I fixed it I've fixed this in a fork by restoring Lines 146 – 148 that were removed in #4156. I think this is the right fix, but Next.js's handling of `getInitialProps` could certainly be improved. (The code in [this conditional](https://github.com/zeit/next.js/blob/86d01706a67cee5c80796974d04c1e11cdff453a/client/index.js#L173) speaks to the unnecessary complexity around this.)
-
Michael Herold authored
Preferably this installation wouldn't be necessary, but in lieu of a fix... #4751
-
Albin Ekblom authored
-
- 10 Jul, 2018 1 commit
-
-
Jacob Page authored
* Remove nesting of runtime configuration under the babel section, since it's not related to babel. * Clean up confusing verbiage relating to "keys."
-
- 09 Jul, 2018 1 commit
-
-
jhartley218 authored
Updating to a more recent version of `@types/next` fixes an error I encountered while building a new app on top of the "with-typescript" example: `Property `push` not found in SingletonRouter` Additional context: https://github.com/DefinitelyTyped/DefinitelyTyped/issues/26665 To test, add a simple Router.push operation to the `pages/index.tsx` ``` import Router from 'next/router' // ... <span onClick={() => Router.push({ pathname: '/about' })}>TEST</span> ```
-
- 06 Jul, 2018 3 commits
-
-
Tim Neutkens authored
-
Tim Neutkens authored
-
Brendan Houle authored
-
- 05 Jul, 2018 2 commits
-
-
NikitaVlaznev authored
Apollo's getDataFromTree is supposed to be called during the server side rendering. Being called in browser it fires an unnecessary fake render process and blocks components from rendering with loading=true. Also there was a mistake in this code: // `getDataFromTree` renders the component first, the client is passed off as a property. // After that rendering is done using Next's normal rendering pipeline this.apolloClient = props.apolloClient || initApollo(props.apolloState.data) **Apollo** component is not rendered by getDataFromTree actually, it renders the **App** directly, thus props.apolloClient will always be undefined. This example was discussed here: https://github.com/zeit/next.js/issues/387. -
Jacob Page authored
Fixes #4679 * Document usage of `events` router property * Expose `events` in the `router` context object
-
- 04 Jul, 2018 1 commit
-
-
Michael Hsu authored
This PR is a follow-up to 6.1 breaking #4506: Rename `dist` to `server`
-
- 02 Jul, 2018 1 commit
-
-
Luc authored
Fixes #4713 I ran into this issue, when re-installing : ``` error upath@1.0.4: The engine "node" is incompatible with this module. Expected version ">=4 <=9". error Found incompatible module ``` I used `yarn install --ignore-engines` as a workaround.
-
- 30 Jun, 2018 2 commits
-
-
Junyoung Choi (Sai) authored
in flavor of https://github.com/zeit/next.js/pull/4377
-
Vinicius Pacheco Furtado authored
Update @zeit/next-typescript version on examples using it
-
- 29 Jun, 2018 5 commits
-
-
Gary Meehan authored
The purpose of the PR is to add the simplest possible integration with Storybook. It leaves the default Storybook and also adds a custom component to show how it would be used in both the app and Storybook. Update: Tested with latest
👉 6.1.1 -
Gary Meehan authored
Removes unused file Adds note on `day` subdirectory.
-
dengyunxie authored
unified format
😀 😋 -
Tim Neutkens authored
-
Niklas Wagner authored
I had some trouble to get server side rendering with the AWSAppSyncClient working. I finally found a solution in https://github.com/awslabs/aws-mobile-appsync-sdk-js/issues/82 but it might be worth to share it here as well. Instead of adding a big code block to each file I'll just refer to this Pull Request. ______ In case you want to use the `AWSAppSyncClient` you just need to replace the `create()` function with this function: ```jsx import AWSAppSyncClient from 'aws-appsync'; import { AUTH_TYPE } from 'aws-appsync/lib/link/auth-link'; function create(initialState) { const client = new AWSAppSyncClient({ url: AWS_AppSync.graphqlEndpoint, region: AWS_AppSync.region, auth: { type: AUTH_TYPE.API_KEY, apiKey: AWS_AppSync.apiKey, // Amazon Cognito Federated Identities using AWS Amplify //credentials: () => Auth.currentCredentials(), // Amazon Cognito user pools using AWS Amplify // type: AUTH_TYPE.AMAZON_COGNITO_USER_POOLS, // jwtToken: async () => (await Auth.currentSession()).getIdToken().getJwtToken(), }, disableOffline: true, }, { cache: new InMemoryCache().restore(initialState || {}), ssrMode: true }); return client; } ```
-
- 28 Jun, 2018 8 commits
-
-
Tim Neutkens authored
-
Tim Neutkens authored
-
Tim Neutkens authored
When clicking a next/link with a hash (#something) multiple times, it wouldn't keep the scrolling behavior browsers have. This makes sure we correctly trigger it.
-
Thomas Hermann authored
When implementing a strict CSP with nonces and `strict-dynamic`, every script and preload requires a nonce. https://csp.withgoogle.com/docs/strict-csp.html
-
Tim Neutkens authored
Fixes #4686 Adds tests for @zeit/next-typescript so that we don't regress on this again. I've fixed an issue in the `next` CLI too which caused lingering processes when the process gets force killed, which is what we do in the test suite, so it kept running if there was no manual quit.
-
Leo Lamprecht authored
-
Andrew Cherniavskii authored
Closes #4684
-
Luc authored
This PR fixes #4615 From the issue : > One thing we might consider is merging and showing a warning for keys not defined in exportPathMap The behaviour after this PR is the following : ```js // next.config.js module.exports = { exportPathMap: () => ({ '/': { page: '/', query: { a: 'blue' } } }) } ``` | url called | `ctx.query` | warning ? | |-|-|-| | `/` | `{ a: 'blue' }` | | | `/?a=red` | `{ a: 'blue' }` | | | `/?b=green` | `{ a: 'blue', b: 'green' }` | `... parameter 'b' missing in exportPathMap` | Is that the expected behaviour ? If not, I'll update the PR to shape the expected behavior.
-
- 27 Jun, 2018 2 commits
-
-
Tim Neutkens authored
-
Steve Korshakov authored
I have spend whole day on profiling next.js compiling performance and one of the easy hacks to reduce built time is avoid doing full `stats.toJson()` that is heavy by default.
-
- 25 Jun, 2018 1 commit
-
-
Tim Neutkens authored
-