- 05 Nov, 2020 14 commits
-
-
Joe Haddad authored
-
Steven authored
Fixes #18794
-
Matthew Lilley authored
This PR fixes issues in two apollo examples where cached queries are lost, and cached data is merged incorrectly.
-
Vitor Dino authored
hey there
👋 stumbled on the [`using-preact` example](https://github.com/vercel/next.js/tree/canary/examples/using-preact) first when i tried to port my project, just saw that the [config wasn’t that trivial](https://github.com/vercel/next.js/issues/13969#issuecomment-641540051), and it would fit better on a [plugin](https://github.com/preactjs/next-plugin-preact).. I did this migration first on my project (it worked super well) and realized that people also would dislike having to maintain that kind of code, and would stumble faster on the plugin if it was already on the official example✨ -
JJ Kasper authored
-
Alex Vilchis authored
The previous props are in bold, but `notFound` is not.
-
Joe Haddad authored
-
Guy Bedford authored
This adds inlining for Babel and the Babel plugins used in next. This is based to the PR at https://github.com/vercel/next.js/pull/18823. The approach is to make one large bundle and then separate out the individual packages from that in order to avoid duplications. In the first attempt the Babel bundle size was 10MB... using "resolutions" in the Yarn workspace to reduce the duplicated packages this was brought down to a 2.8MB bundle for Babel and all the used plugins which is exactly the expected file size here. This will thus add a 2.8MB download size to the next package, but save downloading any babel dependencies separately, removing a large number of package dependencies from the overall install.
-
James George authored
The helper `runStarter()` is extraneous.
-
-
Will Heslam authored
The rule [total-functions/no-unsafe-readonly-mutable-assignment](https://github.com/danielnixon/eslint-plugin-total-functions#total-functionsno-unsafe-readonly-mutable-assignment) triggers with this error message: > Assigning a readonly type to a mutable type can lead to unexpected mutation in the readonly value when invoking ``` NextScript.getInlineScriptSource(this.props) ``` inside a `_document.tsx`'s render function. due to `this.props` having the type: ``` props: Readonly<P> & Readonly<{ children?: ReactNode }> ``` in `@types/react` On the other hand, this is a small, low-priority change (IMO), so an alternative work around is just to disable the lint rule for that line of course. Lint, tests, and build passes. Lint error was discovered using typescript@next, version `4.1.0-dev.20200921` and eslint-plugin-total-functions version `4.1.0`, but I tested the change to nextjs using typescript version `3.8.3`.
-
Joe Haddad authored
This pull request speeds up Next.js' rendering pipeline by fetching data, parsing it, and loading it into memory instead of only doing the network request. This will mainly result in improved Firefox/Safari performance since they handled prefetch incorrectly—only Chrome did it right. This also gets us closer to being able to use `no-store` in our caching headers! --- Fixes #18639 x-ref #18802
-
James George authored
Added a test case for asking for a name for the project if not supplied.
-
Guy Bedford authored
This updates to the latest ncc@0.24.1 release. Initially I thought chalk needed to be removed to make this work, but it turns out it was a caching issue. I've also added a cache clear to the rebuild command to avoid these issues hopefully in future.
-
- 04 Nov, 2020 14 commits
-
-
Willian Justen authored
-
Abdelrahman Rifai authored
-
JJ Kasper authored
-
JJ Kasper authored
This updates the GS(S)P redirect handling to make sure to handle redirects correctly when coming from the incremental-cache. Additional tests have been added to ensure the redirects work correctly after the cache is populated. Fixes: https://github.com/vercel/next.js/issues/18735 Fixes: https://github.com/vercel/next.js/issues/18783
-
Guy Bedford authored
This adds ncc inlining optimizations for the following dependencies: * cacache * schema-utils * find-cache-dir * mkdirp * neo-async * web-vitals The slight increase in output in the reports here is due to the variation of the bundled version of web-vitals. In addition, this moves ast-types to be a devDependencies entry instead of in dependencies as it was before https://github.com/vercel/next.js/pull/14746 as I could not see any production usage (ping @prateekbh). Happy to separate that out into a separate PR if preferred too.
-
Steven authored
This PR disables image optimization and lazy loading for [Data URLs](https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/Data_URIs), because the image data is already inlined. Fixes #18372 Fixes #18692
-
Steven authored
This PR prints a pretty error when the Image `src` property is a [protocol-relative URL](https://www.paulirish.com/2010/the-protocol-relative-url/). > Update 2014.12.17: > Now that SSL is encouraged for everyone and doesn’t have performance concerns, this technique is now an anti-pattern. If the asset you need is available on SSL, then always use the https:// asset. Fixes #18536
-
JJ Kasper authored
Tweak `asPath` docs to mention `basePath` and `locale` will not be included in the value. Closes: https://github.com/vercel/next.js/issues/18782
-
Joris W authored
This page claims that `exportPathMap` is only used by `next export`. This is somewhat misleading, as the mapping is also detected and applied during `yarn develop`. I welcome any other suggestions to make this clearer than I did in this PR.
-
Steven authored
This revises the docs to add headings and also links to layout examples. Fixes #18554
-
Joe Haddad authored
Fixes #18793
-
Tom authored
-
Guy Bedford authored
This is a prerequisite to being able to ncc inline the Babel dependencies in next.js. The removal of preset-modules is based on replacing it with preset-env under `targets: { esmodules: true }`, as per the guidance from the package (https://www.npmjs.com/package/@babel/preset-modules): > Starting from @babel/preset-env 7.9.0, you can enable the bugfixes: true option to get the same behavior as using @babel/preset-modules, but with support for custom targets. If you need to target browsers with native modules support (like this preset does), you can use targets: { esmodules: true }. From the above, I'm pretty sure this is entirely a backwards compatible change, apart from the change to the runtime plugin list being visible. Perhaps @developit can confirm this as well. -
Matsumoto Toshi authored
Co-authored-by:kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
- 03 Nov, 2020 12 commits
-
-
Steven authored
Disabling GH Comments per @Timer These are the same settings we use for the `vercel/vercel` repo.
-
Cowboy Ho authored
Co-authored-by:
Tim Neutkens <timneutkens@me.com> Co-authored-by:
Joe Haddad <joe.haddad@zeit.co> Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
Joe Haddad authored
-
Steven authored
-
Joe Haddad authored
-
JJ Kasper authored
This ensures we don't render the page un-necessarily when a redirect is returned from `getStaticProps` or `getServerSideProps`. Possibly related: https://github.com/vercel/next.js/issues/18735 Closes: https://github.com/vercel/next.js/issues/18747
-
Eric Burel authored
-
Aral Roca Gomez authored
Co-authored-by:Joe Haddad <joe.haddad@zeit.co>
-
Lee Robinson authored
Updates https://nextjs.org/docs/migrating/from-gatsby to mention the new `next/image` component released in Next.js 10.
-
Joe Haddad authored
Next.js would try to "recover" if its CSS assets went missing (i.e. a deployment occured) **while the page was initially loading**. This handled a rare case where we'd try to let the Next.js complete hydrating even though a deployment occured. However, in practice, this never worked: if the `fetch()` failed, that means the original assets never downloaded themselves (because the `fetch()` should be coming from disk cache). Instead of letting Next.js get itself into a weird state, let's just stop hydration so that the page doesn't accidentally delete its styles. The handle-no-styles behavior is already tested in `test/integration/css/test/index.test.js`. There was never a branch for it using its cached styles, so nothing else needs updated. --- Fixes #17930
-
khades authored
Serverside Dynamically loaded CSS module file insertion adds css-files as usual static files with special data-n-p tag, that is used in page transition logic. That files get removed on page transition cause they are not explicitly required in scope of page. Mini-css-extract-plugin adds style tags at chunk insertion without any tags and leave them be, no matter how many page transitions were made. I removed data-n-p tag from dynamically loaded css module files and added new data-n-d tag for it. Fixes #16950
-
Joe Haddad authored
-