- 07 Nov, 2020 6 commits
-
-
Joe Haddad authored
-
Steven authored
This PR fixes two bugs causing HTML validators to complain. - Error: Bad value data:image/svg+xml;charset=utf-8, for attribute src on element img: Illegal character in scheme data: < is not allowed. - Fixed by using base64 for svg during `layout=intrinsic` to avoid angle brackets - Error: Element img is missing required attribute src. - Fixed by using base64 transparent gif for `loading=lazy` placeholder Fixes #18850
-
Dinesh Balaji authored
When `create-next-app` is initialized a git repo, it now uses 'main' as the initial branch. The branch master does not actually exist initially. The branches don't get created only when they have at least one commit. Until the branch gets created, the branch only exists in .git/HEAD. So there is no master branch initialized in the repo. Closes: https://github.com/vercel/next.js/issues/17733 <img width="639" alt="Screenshot 2020-10-09 at 17 26 30" src="https://user-images.githubusercontent.com/4656109/95580229-9f3c6c80-0a54-11eb-967f-180eb9601c1a.png">
-
Joe Haddad authored
This PR adds additional security tests.
-
JJ Kasper authored
This makes sure to compile query values for rewrites/redirects as non-path items to prevent param like values e.g. `https://` from causing the destination to fail to compile. Fixes: https://github.com/vercel/next.js/issues/17440 x-ref: https://github.com/vercel/next.js/issues/18670
-
Ante Sepic authored
Now that all Contentful spaces support GraphQL, we are looking into switching the example from using a JS library to a simple fetch with GraphQL. @stefanjudis
☝ ️
-
- 06 Nov, 2020 15 commits
-
-
Joe Haddad authored
This pull request fixes `<Image />` not updating when new props are passed by removing external DOM mutations and relying on React to do it instead. As an added bonus, I've extracted the intersection observer from both the `<Image />` and `<Link />` component, as their instance can be shared! The increase in size is minor (+3B), and actually a decrease for apps using both `<Image />` and `<Link />`. --- Fixes #18698 Fixes #18369
-
Steven authored
Fixes #18908
-
JJ Kasper authored
-
Bruno Crosier authored
Co-authored-by:Luis Alvarez <luis@vercel.com>
-
JJ Kasper authored
This makes sure we don't use es6 syntax when compiling the `web-vitals` package with `ncc` since that breaks IE11 compatibility x-ref: https://github.com/vercel/ncc/pull/614
-
Joe Haddad authored
While we were fixing how Next.js handled CSS, we added a complex prefetch, preload, fetch sequence to acquire the CSS asset. This unnecessarily overcomplicated what could've been only a `fetch()` from the very start! --- Fixes #16932
-
Prottay Rudra authored
- new chakra-ui rc version doesn't work without 'farmer-motion', installed farmer motion - updated 'chakra-ui' library from '^1.0.0-rc.3' to '^1.0.0-rc.8'
-
Joe Haddad authored
Fixes #17066
-
JJ Kasper authored
-
JJ Kasper authored
This corrects this test failing from an arrow function being used in ie11 which isn't supported natively ``` ● Production Usage › Dynamic import › default behavior › should not remove css styles for same css file between page transitions JavascriptError: Error executing JavaScript at Object.throwDecodedError (../node_modules/selenium-webdriver/lib/error.js:550:15) at parseHttpResponse (../node_modules/selenium-webdriver/lib/http.js:565:13) at Executor.execute (../node_modules/selenium-webdriver/lib/http.js:491:26) ``` -
Luis Alvarez D authored
Note that the indentation of the code samples and notes is important so it uses the same indentation of the items in the list. Fixes https://github.com/vercel/next.js/issues/18869
-
Guy Bedford authored
This upgrades to ncc@0.25.0 and fixes the previous bugs including: * ncc not referenced correctly in build * Babel type errors * node-fetch, etag, chalk and raw-body dependencies not building with ncc - these have been "un-ncc'd" for now. As they are relatively small dependencies, this doesn't seem too much of an issue and we can follow up in the tracking ncc issue at https://github.com/vercel/ncc/issues/612. * `yarn dev` issues Took a lot of bisecting, but the overall diff isn't too bad here in the end.
-
Joe Haddad authored
* Ensure we prefetch on hover * double because of hovering prefetch * rerun workflow * disable flaky test
-
Steven authored
Fixes #18827 so that lazy loading does not break IE 11.
-
Guy Bedford authored
This fixes the current regression with an ncc revert for now. I will continue to follow up with the ncc upgrade in https://github.com/vercel/next.js/pull/18860.
-
- 05 Nov, 2020 15 commits
-
-
JJ Kasper authored
* Fix chromedriver set-up to test electron separately * Update workflow * Update compiled
-
Joe Haddad authored
-
Steven authored
Fixes #18794
-
Matthew Lilley authored
This PR fixes issues in two apollo examples where cached queries are lost, and cached data is merged incorrectly.
-
Vitor Dino authored
hey there
👋 stumbled on the [`using-preact` example](https://github.com/vercel/next.js/tree/canary/examples/using-preact) first when i tried to port my project, just saw that the [config wasn’t that trivial](https://github.com/vercel/next.js/issues/13969#issuecomment-641540051), and it would fit better on a [plugin](https://github.com/preactjs/next-plugin-preact).. I did this migration first on my project (it worked super well) and realized that people also would dislike having to maintain that kind of code, and would stumble faster on the plugin if it was already on the official example✨ -
JJ Kasper authored
-
Alex Vilchis authored
The previous props are in bold, but `notFound` is not.
-
Joe Haddad authored
-
Guy Bedford authored
This adds inlining for Babel and the Babel plugins used in next. This is based to the PR at https://github.com/vercel/next.js/pull/18823. The approach is to make one large bundle and then separate out the individual packages from that in order to avoid duplications. In the first attempt the Babel bundle size was 10MB... using "resolutions" in the Yarn workspace to reduce the duplicated packages this was brought down to a 2.8MB bundle for Babel and all the used plugins which is exactly the expected file size here. This will thus add a 2.8MB download size to the next package, but save downloading any babel dependencies separately, removing a large number of package dependencies from the overall install.
-
James George authored
The helper `runStarter()` is extraneous.
-
-
Will Heslam authored
The rule [total-functions/no-unsafe-readonly-mutable-assignment](https://github.com/danielnixon/eslint-plugin-total-functions#total-functionsno-unsafe-readonly-mutable-assignment) triggers with this error message: > Assigning a readonly type to a mutable type can lead to unexpected mutation in the readonly value when invoking ``` NextScript.getInlineScriptSource(this.props) ``` inside a `_document.tsx`'s render function. due to `this.props` having the type: ``` props: Readonly<P> & Readonly<{ children?: ReactNode }> ``` in `@types/react` On the other hand, this is a small, low-priority change (IMO), so an alternative work around is just to disable the lint rule for that line of course. Lint, tests, and build passes. Lint error was discovered using typescript@next, version `4.1.0-dev.20200921` and eslint-plugin-total-functions version `4.1.0`, but I tested the change to nextjs using typescript version `3.8.3`.
-
Joe Haddad authored
This pull request speeds up Next.js' rendering pipeline by fetching data, parsing it, and loading it into memory instead of only doing the network request. This will mainly result in improved Firefox/Safari performance since they handled prefetch incorrectly—only Chrome did it right. This also gets us closer to being able to use `no-store` in our caching headers! --- Fixes #18639 x-ref #18802
-
James George authored
Added a test case for asking for a name for the project if not supplied.
-
Guy Bedford authored
This updates to the latest ncc@0.24.1 release. Initially I thought chalk needed to be removed to make this work, but it turns out it was a caching issue. I've also added a cache clear to the rebuild command to avoid these issues hopefully in future.
-
- 04 Nov, 2020 4 commits
-
-
Willian Justen authored
-
Abdelrahman Rifai authored
-
JJ Kasper authored
-
JJ Kasper authored
This updates the GS(S)P redirect handling to make sure to handle redirects correctly when coming from the incremental-cache. Additional tests have been added to ensure the redirects work correctly after the cache is populated. Fixes: https://github.com/vercel/next.js/issues/18735 Fixes: https://github.com/vercel/next.js/issues/18783
-