- 09 Nov, 2020 13 commits
-
-
Joe Haddad authored
-
Weston Thayer authored
## New features - Example of how to use `Sentry.captureException()` in API routes https://github.com/vercel/next.js/commit/5a35982717bc7f916022dd713b3b1f9e0921d503 ## Bug fixes - Server-side source maps now work in Sentry when deployed to Vercel https://github.com/vercel/next.js/commit/629a9ed5048629dc12670ef457fe6efaa2e8d3b6 - If uploading source maps, `Sentry.init()` now sets the `release`, so that exceptions are correctly associated with the source maps in that release ## Open issues ### `_error.js` is unused for `getServerSideProps` errors when deployed to Vercel Instead of rendering this example's overridden `_error.js` (like it does when testing locally with `NODE_ENV='production'`), when deployed to Vercel and an Error is thrown from `getServerSideProps`, this page is shown:  This confuses me because the Error is still successfully sent to Sentry, but I would've expected it to be sent by the call to `Sentry.captureException()` in `_error.js`. I'm not sure why it works. ### API test 2 & 3 don't work in the "server" build config They don't work when deployed to Vercel in the "serverless" config either, but that's expected because there aren't any handlers to flush the Sentry queue. I can't figure out why they don't work in the long-lived "server" config.
-
iczero authored
`node-sass` v5 introduced support for Node.js v15, which is not supported by v4. However, Next.js currently errors with ``` Error: Node Sass version 5.0.0 is incompatible with ^4.0.0. ``` when attempting to build with `node-sass` 5.0.0. This error comes from `sass-loader`. They have recently released version 10.0.5 which supports `node-sass` 5.0.0 (PR <https://github.com/webpack-contrib/sass-loader/pull/899>, release <https://github.com/webpack-contrib/sass-loader/releases/tag/v10.0.5>).
-
tolfino authored
This replaces the seen set with a newly instantiated map of refs per value in the array. This corrects the behavior that the refs map passed into isSerializable contains only values along the path to the current value: previously, because the refs map was shared among all values in the array, this would trigger on instances such as: ```js const x = []; isSerializableProps('/', 'test', { arr: [x, [x]] }); ``` ... where the reference is shared but there is no cycle formed, as the presence of elements is disjoint. Fixes #18228. -
James George authored
Prevent `catch` assertions in tests.
-
Davidson Nascimento authored
- Changed script `start` to `dev` and improved it #18934 adding commando to transpile electron code; - Added some folders into `.gitignore`; - Updated react to avoid issues as #18916 Fixes #18934
-
JJ Kasper authored
This updates to use the `Build.SourceVersion` value from the [predefined variables](https://docs.microsoft.com/en-us/azure/devops/pipelines/build/variables?view=azure-devops&tabs=yaml) for the cache key instead of the pull request value since it isn't available after merging to canary. x-ref: https://github.com/vercel/next.js/pull/18931
-
Tadao Iseki authored
This allows to import the type `ImageProps` from `next/image` like `next/link`. https://github.com/vercel/next.js/blob/a6660729ea82fbcb26cfe7c89637b1af37255c9f/packages/next/client/link.tsx#L21 ## Usage ```tsx import Image, { ImageProps } from 'next/image' const CustomImage: React.FC<ImageProps> = (props) => ( <Image {...props} unsized /> ) ```
-
JJ Kasper authored
-
Michael McQuade authored
The other examples are using the typescript `import type` style, which gets stripped during the build, so I added it to the API Routes example too.
-
Jesse Jafa authored
Resolves https://github.com/vercel/next.js/issues/18941
-
Luis Alvarez D authored
Notes: - I use "blank page" to refer to that state where a new tab is waiting for the initial HTML. Lmk if there are better words to describe that. - I did not add an usage example because it's the same thing of `fallback: true` and `fallback: false`, but with a config change. It's also explained below them and mentions the similarity with `fallback: true` --- Fixes #18468
-
JJ Kasper authored
-
- 08 Nov, 2020 1 commit
-
-
JJ Kasper authored
This ensures dynamic routes are correctly generated for `next start` with i18n and adds tests to the i18n suite to ensure they are working correctly. Closes: https://github.com/vercel/next.js/issues/18397
-
- 07 Nov, 2020 7 commits
-
-
Davidson Nascimento authored
-
Joe Haddad authored
-
Steven authored
This PR fixes two bugs causing HTML validators to complain. - Error: Bad value data:image/svg+xml;charset=utf-8, for attribute src on element img: Illegal character in scheme data: < is not allowed. - Fixed by using base64 for svg during `layout=intrinsic` to avoid angle brackets - Error: Element img is missing required attribute src. - Fixed by using base64 transparent gif for `loading=lazy` placeholder Fixes #18850
-
Dinesh Balaji authored
When `create-next-app` is initialized a git repo, it now uses 'main' as the initial branch. The branch master does not actually exist initially. The branches don't get created only when they have at least one commit. Until the branch gets created, the branch only exists in .git/HEAD. So there is no master branch initialized in the repo. Closes: https://github.com/vercel/next.js/issues/17733 <img width="639" alt="Screenshot 2020-10-09 at 17 26 30" src="https://user-images.githubusercontent.com/4656109/95580229-9f3c6c80-0a54-11eb-967f-180eb9601c1a.png">
-
Joe Haddad authored
This PR adds additional security tests.
-
JJ Kasper authored
This makes sure to compile query values for rewrites/redirects as non-path items to prevent param like values e.g. `https://` from causing the destination to fail to compile. Fixes: https://github.com/vercel/next.js/issues/17440 x-ref: https://github.com/vercel/next.js/issues/18670
-
Ante Sepic authored
Now that all Contentful spaces support GraphQL, we are looking into switching the example from using a JS library to a simple fetch with GraphQL. @stefanjudis
☝ ️
-
- 06 Nov, 2020 15 commits
-
-
Joe Haddad authored
This pull request fixes `<Image />` not updating when new props are passed by removing external DOM mutations and relying on React to do it instead. As an added bonus, I've extracted the intersection observer from both the `<Image />` and `<Link />` component, as their instance can be shared! The increase in size is minor (+3B), and actually a decrease for apps using both `<Image />` and `<Link />`. --- Fixes #18698 Fixes #18369
-
Steven authored
Fixes #18908
-
JJ Kasper authored
-
Bruno Crosier authored
Co-authored-by:Luis Alvarez <luis@vercel.com>
-
JJ Kasper authored
This makes sure we don't use es6 syntax when compiling the `web-vitals` package with `ncc` since that breaks IE11 compatibility x-ref: https://github.com/vercel/ncc/pull/614
-
Joe Haddad authored
While we were fixing how Next.js handled CSS, we added a complex prefetch, preload, fetch sequence to acquire the CSS asset. This unnecessarily overcomplicated what could've been only a `fetch()` from the very start! --- Fixes #16932
-
Prottay Rudra authored
- new chakra-ui rc version doesn't work without 'farmer-motion', installed farmer motion - updated 'chakra-ui' library from '^1.0.0-rc.3' to '^1.0.0-rc.8'
-
Joe Haddad authored
Fixes #17066
-
JJ Kasper authored
-
JJ Kasper authored
This corrects this test failing from an arrow function being used in ie11 which isn't supported natively ``` ● Production Usage › Dynamic import › default behavior › should not remove css styles for same css file between page transitions JavascriptError: Error executing JavaScript at Object.throwDecodedError (../node_modules/selenium-webdriver/lib/error.js:550:15) at parseHttpResponse (../node_modules/selenium-webdriver/lib/http.js:565:13) at Executor.execute (../node_modules/selenium-webdriver/lib/http.js:491:26) ``` -
Luis Alvarez D authored
Note that the indentation of the code samples and notes is important so it uses the same indentation of the items in the list. Fixes https://github.com/vercel/next.js/issues/18869
-
Guy Bedford authored
This upgrades to ncc@0.25.0 and fixes the previous bugs including: * ncc not referenced correctly in build * Babel type errors * node-fetch, etag, chalk and raw-body dependencies not building with ncc - these have been "un-ncc'd" for now. As they are relatively small dependencies, this doesn't seem too much of an issue and we can follow up in the tracking ncc issue at https://github.com/vercel/ncc/issues/612. * `yarn dev` issues Took a lot of bisecting, but the overall diff isn't too bad here in the end.
-
Joe Haddad authored
* Ensure we prefetch on hover * double because of hovering prefetch * rerun workflow * disable flaky test
-
Steven authored
Fixes #18827 so that lazy loading does not break IE 11.
-
Guy Bedford authored
This fixes the current regression with an ncc revert for now. I will continue to follow up with the ncc upgrade in https://github.com/vercel/next.js/pull/18860.
-
- 05 Nov, 2020 4 commits
-
-
JJ Kasper authored
* Fix chromedriver set-up to test electron separately * Update workflow * Update compiled
-
Joe Haddad authored
-
Steven authored
Fixes #18794
-
Matthew Lilley authored
This PR fixes issues in two apollo examples where cached queries are lost, and cached data is merged incorrectly.
-