- 02 Feb, 2021 4 commits
-
-
JJ Kasper authored
-
JJ Kasper authored
-
Tim Neutkens authored
-
JJ Kasper authored
This adds a config to output webpack's stats
-
- 01 Feb, 2021 5 commits
-
-
JJ Kasper authored
This ensures we get the latest tag not relying on the order of the tags in the output
-
Tim Neutkens authored
-
Guy Bedford authored
This should resolve the typing issues described in https://github.com/vercel/next.js/issues/21390 from the webpack inlining, by declaring `next/dist/compiled/webpack` in the main typing file as a source.
-
JJ Kasper authored
Co-authored-by:kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Aryan Beezadhur authored
-
- 30 Jan, 2021 2 commits
-
-
Rafael Bonalume Lebre authored
According to [MDN docs](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#attr-href) the page must scroll to the top with both "#" and "#top" anchors. <img width="675" alt="Screen Shot 2020-08-27 at 7 20 19 PM" src="https://user-images.githubusercontent.com/13899924/91500693-582a5b80-e89a-11ea-803f-4592d458baba.png">
-
Lachlan Campbell authored
-
- 29 Jan, 2021 9 commits
-
-
Joe Haddad authored
-
Joe Haddad authored
-
Lee Robinson authored
My addition of the Yarn 2 caveat was more nuanced than I thought. Apologies. @merceyz has been adding extensive e2e tests for Yarn 2 support. We plan to support Yarn 2 compat. Reverts https://github.com/vercel/next.js/pull/21657.
-
JJ Kasper authored
-
Joe Haddad authored
-
Lee Robinson authored
As we saw some confusion with users trying out Yarn 2 and hitting roadblocks in their app. Yarn 2 is supported on a best-effort basis.
-
Janicklas Ralph authored
Adding test for experimental-serverless-trace + fix for the same
-
Tim Neutkens authored
-
Dale Bustad authored
@timneutkens I think this is ready for a review. I've made some changes to the original design that _seem_ to have paid off. The parenting relationships for traces of normal builds are applied more uniformly, resulting in more intelligible traces: <img width="900" alt="Screen Shot 2021-01-29 at 12 53 47 AM" src="https://user-images.githubusercontent.com/5016978/106253732-ba321880-61cc-11eb-98fd-d45af5078273.png"> Hot-reloading is surfaced now, too. I will note, however, that we will want to dig in deeper and find out where the large portion of time at the beginning of hot-reload is spent. Example: <img width="894" alt="Screen Shot 2021-01-29 at 12 53 28 AM" src="https://user-images.githubusercontent.com/5016978/106253828-e057b880-61cc-11eb-967d-46eaff31ecef.png"> Where did those 180 ms go? At the least, we can now track how long a hot-reload takes, and have a place to start with further investigation.
-
- 28 Jan, 2021 2 commits
-
-
Lee Robinson authored
-
Matt Ruby authored
-
- 27 Jan, 2021 2 commits
-
-
JJ Kasper authored
-
JJ Kasper authored
This insures we add entries for each locale version of a non-dynamic SSG page since they can have unique revalidate values. This requires a version bump in the `prerender-manifest` since the static routes now contain additional values which need to be handled separately. Fixes: https://github.com/vercel/next.js/issues/21568
-
- 26 Jan, 2021 16 commits
-
-
Joe Haddad authored
-
JJ Kasper authored
-
JJ Kasper authored
* Update CI docs change diff check * Increse fetch depth for merge base detecting * Update cancel branches config
-
Jaon authored
I tried the preset provided at `packages/next-plugin-storybook` but it was raising error due to an [unsafe negation](https://eslint.org/docs/rules/no-unsafe-negation) in the `preset.js` file. I added a test to show the error: ``` ● next-plugin-storybook filterModuleRules › should filter module rules correctly TypeError: rule.test.test is not a function 48 | if (!rule.test instanceof RegExp) return true 49 | // use Next.js' built-in CSS > 50 | if (rule.test.test('hello.css')) { | ^ 51 | return false 52 | } 53 | // use next-babel-loader instead of storybook's babel-loader at filter (../packages/next-plugin-storybook/preset.js:50:21) at Array.filter (<anonymous>) at Object.filterModuleRules (../packages/next-plugin-storybook/preset.js:46:28) at Object.<anonymous> (unit/webpack-config-overrides.test.js:12:36) ```
-
Luis Alvarez D authored
-
Janicklas Ralph authored
-
Roko Bekavac authored
Co-authored-by:
rokobekavac0 <roko.beakavac2003@gmail.com> Co-authored-by:
Tim Neutkens <tim@timneutkens.nl> Co-authored-by:
Joe Haddad <joe.haddad@zeit.co>
-
Kazutaka NAKAMURA authored
-
Ondřej Chrastina authored
Kontent example also contains the implementation of the preview capabilities in the example. Including the example as it is [Data fetching section](https://nextjs.org/docs/basic-features/data-fetching).
-
Andre Hsu authored
Change type of GetServerSidePropsContext.req.cookies the be the same as NextApiRequest.cookies (#21336) The original type for `GetServerSidePropsContext.req.cookies` was introduced in #19724. In the PR, the test at `test/integration/typescript/test/index.test.js` expects req.cookies to always exist, so `req.cookies` will never be undefined. I'm guessing that req.cookies is parsed using the same cookie middleware as `NextApiRequest`, in which case `req.cookies` should be `{ [key: string]: string }`, not `{ [key: string]: any }`. -
Chulki Lee authored
Closes #17042 I removed mkdirp from package.json taskfil.js, and ran `yarn && ./check-pre-compiled.sh `. Please let me know if anything else is needed! (Extracted from #20411) Note that now compiled webpack has mkdirP function
-
youngvform authored
I made an issue #[21330](https://github.com/vercel/next.js/issues/21330). I think this line https://github.com/vercel/next.js/blob/0bd175264b000895cccd75f4499bdf55daad4882/packages/react-dev-overlay/src/internal/helpers/launchEditor.ts#L216 return string array and toLowerCase is undefined in string array so throw error. I fixed it by referring to [launchEditor](https://github.com/facebook/create-react-app/blob/7e4949a20fc828577fb7626a3262832422f3ae3b/packages/react-dev-utils/launchEditor.js) of create react app.
-
mcha authored
#21279 This is just a comment explaining that changing `pageExtensions` not only applies to `pages/*` but other files as well.
-
tarunama authored
- Add.type to variables and function, arguments
-
Azeez Lukman authored
Added more detailed explanation of why there is no router instance, and other ways to fix the error
-
tarunama authored
- Add return type to function - Add [isNotValidData](https://github.com/vercel/next.js/pull/21148/files#diff-64466461287cc1a70ce5597e3e1d18ac22755f9aeb7ff1865160a8c057540983R374) function for readability
-