- 30 Apr, 2021 7 commits
-
-
JJ Kasper authored
-
Joon Park authored
This is the image component implementation of the blurry placeholder as described in #24004. The matching server side implementation is currently planned. ## Feature - [x] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [x] Related issue #18858 - [x] Integration tests added (Documentation and telemetry to follow after server side is implemented)
-
Ishank Sharma authored
Fixes: #24075 ## Bug - [X] Related issues linked using `fixes #number` - [X] Integration tests added ## Documentation / Examples - [x] Make sure the linting passes
-
Pepijn Senders authored
## Bug - [x] Related issues linked using [`fixes #24328`](https://github.com/vercel/next.js/pull/24328#issuecomment-828847472) - [ ] Integration tests added The change in #24328 will swallow any `MODULE_NOT_FOUND` errors triggered in the page. If you for example have a page with a broken import, it will tell you `Error: Failed to load /whatever`. This of course doesn't really tell people what is going on internally (a broken import). I added a check to see if the error actually happened in the page.
-
Houssein Djirdeh authored
This PR re-includes ESLint with some notable changes, namely a guided setup similar to how TypeScript is instantiated in a Next.js application. To add ESLint to a project, developers will have to create an `.eslintrc` file in the root of their project or add an empty `eslintConfig` object to their `package.json` file. ```js touch .eslintrc ``` Then running `next build` will show instructions to install the required packages needed: <img width="862" alt="Screen Shot 2021-04-19 at 7 38 27 PM" src="https://user-images.githubusercontent.com/12476932/115316182-dfd51b00-a146-11eb-830c-90bad20ed151.png"> Once installed and `next build` is run again, `.eslintrc` will be automatically configured to include the default config: ```json { "extends": "next" } ``` In addition to this change: - The feature is now under the experimental flag and requires opt-in. After testing and feedback, it will be switched to the top-level namespace and turned on by default. - A new ESLint shareable configuration package is included that can be extended in any application with `{ extends: 'next' }` - This default config extends recommended rule sets from [`eslint-plugin-react`](https://www.npmjs.com/package/eslint-plugin-react), [`eslint-plugin-react-hooks`](https://www.npmjs.com/package/eslint-plugin-react-hooks), and [`eslint-plugin-next`](https://www.npmjs.com/package/@next/eslint-plugin-next) - All rules in [`eslint-plugin-next`](https://www.npmjs.com/package/@next/eslint-plugin-next) have been modified to include actionable links that show more information to help resolve each issue
-
JJ Kasper authored
-
JJ Kasper authored
-
- 29 Apr, 2021 3 commits
-
-
JJ Kasper authored
-
JJ Kasper authored
-
Shu Ding authored
When using `sizes`, [`matchAll`](https://caniuse.com/mdn-javascript_builtins_string_matchall) isn't supported by older browsers like IE and Safari 12. This PR changes it to `exec`. There're already tests of `sizes` with multiple `vw` values covered. Fixes #23677. ## Bug - [x] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [x] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes
-
- 28 Apr, 2021 8 commits
-
-
Sumanth Ratna authored
https://github.com/vercel/next.js/pull/21676 moved `fontOptimization` out of the experimental key of `NextConfig` to the top level, so it should be removed from the type ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes
-
Lee Robinson authored
-
Darsh Patel authored
fixes #24401 Simply bumping `swr` to the latest version seems to fix the issue.
🥂 Couldn't find a consistent pattern across the examples, but most examples are flexible with swr version and use the semver caret. Very standard use of the useSWR hook is there in the example with nothing obviously version specific. -
JJ Kasper authored
-
JJ Kasper authored
-
Tim Neutkens authored
Fixes #24421 ## Bug - [x] Related issues linked using `fixes #number` - [ ] Integration tests added Can't add an integration test currently, we'll add Node 16 tests later. ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes
-
Tim Neutkens authored
* Try enabling Babel turbo mode * Pass config file explicitly to babel turbo loader. * Update NextBabelLoaderOptions to use `configFile` instead of `babelrc`. * Re-add support for options passed to next/babel preset with new babel loader. * Load babel config files depending on their file extension. * Include `next/babel` if no Babel config is provided. * Minor cleanup. * Avoid duplicate `next/babel` entries. * No need to pass configFile anymore. * Fix multiple small issues in merging loader opts with cached config. * Remove redundant logging (that also breaks a test). * Include file extension CharacteristicsGermaneToCaching. * bump * Disable turboMode now that tests pass Co-authored-by:Dale Bustad <dale@divmain.com>
-
JJ Kasper authored
This removes the warnings/notes for the `has` custom-routes feature being experimental ## Documentation / Examples - [x] Make sure the linting passes
-
- 27 Apr, 2021 3 commits
-
-
Mario Souto authored
Hi folks I know many people that use that example and it could be using the new version of React to be according with the NextJS v11 ## Documentation / Examples - [ ] Make sure the linting passes - [ ] Make sure that the bumped up versions are okay
-
JJ Kasper authored
-
JJ Kasper authored
This ensures when CSS requests stall that they are included in the route load timeout so that stalled CSS requests don't block us from falling back to a hard navigation. This handles a rare case noticed by @pacocoursey where a transition did not complete while attempting to load CSS assets. ## Bug - [ ] Related issues linked using `fixes #number` - [x] Integration tests added
-
- 26 Apr, 2021 3 commits
-
-
Janicklas Ralph authored
## Bug - [x] Related issues linked using `fixes #23896` - [x] Integration tests added Fixes #23896
-
Jerry K Jia authored
According to the official Next.js documentation on [Environmental Variables](https://nextjs.org/docs/basic-features/environment-variables): > `process.env` is not a standard JavaScript object, so you’re not able to use object destructuring. Environment variables must be referenced as e.g. `process.env.NEXT_PUBLIC_PUBLISHABLE_KEY`, not `const { NEXT_PUBLIC_PUBLISHABLE_KEY } = process.env`. <!-- Thanks for opening a PR! Your contribution is much appreciated. In order to make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change that you're making: --> ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes
-
JJ Kasper authored
* Ensure proxy rewrite does not hang on error * remove logs * Listen to req close
-
- 25 Apr, 2021 3 commits
-
-
Tim Neutkens authored
## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes
-
Allen Hai authored
This PR updates the initial typescript config message to mention that strict-mode is off by default to maintain expectations about type errors. [Tweet](https://twitter.com/timneutkens/status/1372218890260987904?s=20)
-
Sam Poder authored
View title :)
-
- 24 Apr, 2021 1 commit
-
-
Gerald Monaco authored
* Remove reactMode config * Add config + warning * Tweak wording on warning * Tweak wording on warning * Don't default reactRoot for 10.x * yak shaving * Add warning when using old reactMode
-
- 23 Apr, 2021 5 commits
-
-
Joe Haddad authored
-
Tim Neutkens authored
-
Tim Neutkens authored
-
Tim Neutkens authored
-
Gerald Monaco authored
This test is failing for the same reason as https://github.com/facebook/react/pull/21173, so we'll borrow their fix, and follow along for updates.
-
- 22 Apr, 2021 7 commits
-
-
Joe Haddad authored
* chore: remove old plugins implementation * chore: remove `onErrorMiddleware` * Reduce allowed middleware * remove collect plugins file * remove old tests * remove old demo packages
-
Gerald Monaco authored
Fixes the [failing react@experimental tests](https://github.com/vercel/next.js/actions/workflows/test_react_experimental.yml).
-
JJ Kasper authored
-
Shu Ding authored
Fixes #24056. ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes
-
JJ Kasper authored
This expands on https://github.com/vercel/next.js/issues/24070 and ensures we show the dev overlay for additional cases like where `_app` or `_document` have syntax errors causing compilation to not be able to complete. This achieves showing the dev overlay even when compilation fails from a syntax error by doing a third minimal compilation in development with the needed client-side assets to render the dev overlay. ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added x-ref: https://github.com/vercel/next.js/issues/24070
-
Jarrod Watts authored
- Update the Readme to use the latest Amplify CLI versions' prompts - Update the example to use the [SSR features of AWS Amplify ](https://aws.amazon.com/blogs/mobile/ssr-support-for-aws-amplify-javascript-libraries/) - Update to use Next version `10` instead of `9` - Correctly use the types produced by the Amplify CLI in `API.ts` - Add `amplify auth` and auth rules to the GraphQL model as suggested by the Amplify CLI.
-
JJ Kasper authored
This bumps the babel cache key since we modified the `react-loadable` babel plugin and we don't want any cached versions used since the module names generated in previous cached version won't match the newly expected values. x-ref: https://github.com/vercel/next.js/pull/24281 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes
-