- 08 Jun, 2021 18 commits
-
-
JJ Kasper authored
-
Steven authored
This PR fixes a bug where the first request has the correct immutable header but subsequent requests do not. Depends on #25909
-
Houssein Djirdeh authored
* lots of eslint updates * adds eslint: dirs flag to next.config.js * update lint command in docs * update per review comments * re-add --no-lint command for build * Apply suggestions from code review Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Steven authored
Previously we were accepting a `s=1` query string parameter for static imports, but this is not necessary. Instead, this PR looks at the file path to determine if the header should be `immutable`. The nice thing here is we don't need to worry about someone trying `s=1` with an external image or 3rd party loader. In that case, we use the upstream `Cache-Control` header as usual. This change also ensures we don't add the `immutable` header for `next dev`. Related to PR #24993
-
Tim Neutkens authored
Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Dominic Elm authored
This PR adds a `Preview` section and a `Open in StackBlitz` button to various examples. I have tested all examples and omitted the ones that require third party API keys, or didn't work. Some examples don't work locally either. Here's an example:  ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [x] Examples updated - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [x] Make sure the linting passes
-
Tim Neutkens authored
-
Alex Castle authored
Co-authored-by:kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Andrew Turner authored
-
Chris Neven authored
## Bug - [x] Related issues linked using `fixes #number` - [ ] Integration tests added fixes [#21606](https://github.com/vercel/next.js/issues/21606) ### Description When using shallow routing and wanting to scroll to top by setting the `scroll` option to `true` it didn't work. This PR fixes this issue.
-
Vincent Voyer authored
This updates the with-iron-session example with: - updated way to mutate + fetch (re: https://github.com/vvo/next-iron-session/issues/329) - updated readme to include TypeScript example link Requirements: - [x] Make sure the linting passes
-
matamatanot authored
-
JJ Kasper authored
-
JJ Kasper authored
-
Tim Neutkens authored
-
Yamagishi Kazutoshi authored
-
Yuki Takemoto authored
This PR fixed command in upgrade guide.
-
JJ Kasper authored
-
- 07 Jun, 2021 15 commits
-
-
Vitaly Baev authored
As mentioned in #25854 `witn-next-sitemap` example is missing `typescript` package as a dependency - [x] Make sure the linting passes
-
Yamagishi Kazutoshi authored
If you give a Static Image to the Image component, TypeScript will throw a type error. This Pull Request fixes it. ## Bug - ~~Related issues linked using `fixes #number`~~ - [x] Integration tests added ## ~~Feature~~ - ~~Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.~~ - ~~Related issues linked using `fixes #number`~~ - ~~Integration tests added~~ - ~~Documentation added~~ - ~~Telemetry added. In case of a feature if it's used or not.~~ ## ~~Documentation / Examples~~ - ~~Make sure the linting passes~~ --- follow-up #24993 cc @atcastle
-
Munawwar authored
createContext() no longer accepts initialState as parameter ## Documentation / Examples - [x] Make sure the linting passes
-
Geshan Manandhar authored
## Documentation / Examples - [x] Make sure the linting passes ### Deployed with Cloud Run Button <img width="1075" alt="Screen Shot 2021-06-06 at 10 22 51 pm" src="https://user-images.githubusercontent.com/170554/120924210-d7946780-c715-11eb-889e-79679f795c54.png"> ### Next.js working on Google Cloud Run <img width="982" alt="Screen Shot 2021-06-06 at 10 23 10 pm" src="https://user-images.githubusercontent.com/170554/120924229-e418c000-c715-11eb-9aca-569923f7306d.png">
-
Tim Neutkens authored
* Enable webpack 5 by default for all apps Still provides a way to opt-out using `webpack5: false` in next.config.js. Also throws an error for `future.webpack5`. * Update tests * Update test to run on webpack 4 instead of webpack 5 * disable webpack5 for legacy tests * Fix stats-config for webpack4 * update tests * update size for webpack4 test * move basic suite first * update basic test * Add logs * remove outdated testFutureDependencies job Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
JJ Kasper authored
-
Matt Gleich authored
Signed-off-by:
Matthew Gleich <git@mattglei.ch> Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by:
Tim Neutkens <tim@timneutkens.nl>
-
Tim Neutkens authored
Fixes an issue where "env" would be ignored and would crash if there was no top level "presets". Also found that webpack did not invalidate the cache on changes to the babel config, so I also fixed that.
-
JJ Kasper authored
-
Tim Neutkens authored
Co-authored-by:Gerald Monaco <gbmonaco@google.com>
-
Tim Neutkens authored
-
Alex Castle authored
Co-authored-by:
Steven <steven@ceriously.com> Co-authored-by:
Tim Neutkens <timneutkens@me.com> Co-authored-by:
Tim Neutkens <tim@timneutkens.nl> Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Gerald Monaco authored
-
Abdullah Mzaien authored
## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [x] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes
-
Houssein Djirdeh authored
-
- 06 Jun, 2021 1 commit
-
-
Lucas Vieira authored
Hey guys! Some time ago I used the `with-grommet` example to start a project and I ran into some issues because of the styled-components version. I tried to use some new features and it didn't work as I expected, then I noticed the styled-component version was the `v4`. When I bumped the version it started to work. I am bumping all the styled-components versions on examples because some people may run into the same issue. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [x] Make sure the linting passes
-
- 05 Jun, 2021 3 commits
-
-
Patrick El-Hage authored
## What   ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Documentation / Examples - [x] Make sure the linting passes
-
Lee Robinson authored
Some slight tweaks based on my review of the docs. A few outstanding questions left
😄 https://github.com/vercel/next.js/pull/25064#pullrequestreview-676799292 -
Lee Robinson authored
It appears this library isn't maintained, plus there's already the other `with-relay-modern` example. https://github.com/relay-tools/react-relay-network-modern/issues/128
-
- 04 Jun, 2021 3 commits
-
-
matamatanot authored
## Feature - [ ] Telemetry added. In case of a feature if it's used or not. ### Replace 'require' with 'import' in bench files Node.js 12 allows you to use `import`. ### Update dependancies https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md#breaking-changes > Require Node.js v12+ For #25761, Node.js 12 is required. Therefore, there is no problem updating it. For benchmarking purposes, it would be reasonable to update to the latest version.
-
Tim Neutkens authored
-
Alex Castle authored
Co-authored-by:
Steven <steven@ceriously.com> Co-authored-by:
Tim Neutkens <timneutkens@me.com> Co-authored-by:
Tim Neutkens <tim@timneutkens.nl>
-