- 26 Jul, 2021 4 commits
-
-
JJ Kasper authored
-
Luís Galete authored
✨ -
JJ Kasper authored
Follow-up to https://github.com/vercel/next.js/pull/27463 this adds a note about installing as `devDependency` instead of changing the default install command as the plugin being a `devDependency` might cause issues unless wrapped in a `process.env` check. ## Documentation / Examples - [x] Make sure the linting passes
-
Asher Oloo authored
## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes
-
- 25 Jul, 2021 9 commits
-
-
Mahmoud Abdelwahab authored
Update example so Apollo Studio works properly
-
Noah Weingand authored
## Documentation / Examples - [x] Make sure the linting passes ### Changes * Corrected the file extension reference from .tsx to .ts for ```packages/create-next-app/templates/typescript/README-template.md```. This matches the actual file extension and avoids confusion for new users.
-
stefanprobst authored
the behavior of the `eslint.dirs` config option was changed in #26401. this pr adjusts the doc comment accordingly. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes
-
Artur Muller authored
I recently received the "Props must be returned as a plain object" error when I accidentally dropped an array directly inside `props`. This is a trivial error to fix once you know what you did, but I spent good 30 minutes looking in all the wrong places. I hope that this slight clarification in the error message would save someone from wasting their time if they make a similar mistake like myself.
-
Taylor McGann authored
## Documentation / Examples - [ ] Make sure the linting passes
-
brijendravarma authored
The error message indicates better alternatives and added styles.css sample snippet for good visibility.  
-
Michał Bundyra authored
Attempt to fix #26393 ~~Sorry, I wasn't able to run tests on local, but I hope at least test should be valid.~~ Edit: Tests are working correctly on my local :) fixes #26393 ## Bug - [x] Related issues linked using `fixes #26393` - [x] Integration tests added
-
kaykdm authored
* add no-typos rule to eslint * return early when function name is correct * Handle null decl.type * update check Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Guilherme Baron authored
## Documentation / Examples - [x] Make sure the linting passes
-
- 24 Jul, 2021 2 commits
-
-
JJ Kasper authored
-
Houssein Djirdeh authored
Adds `--format` support to `next lint` to allow defining of additional formatters. Fixes #26387.
-
- 23 Jul, 2021 11 commits
-
-
Arthur Puyou authored
The previous paragraph mentions a max-age of 2 years, so the number of seconds should match.
-
Steven authored
We've never supported the `style` prop as seen in the docs https://nextjs.org/docs/api-reference/next/image#other-props TS users already get a build error but JS users were left in the dark. This PR adds a warning so its clear during `next dev`.
-
JJ Kasper authored
-
Tobias Järvelöv authored
The fix in PR #25749 only works some of the time. The reason why it doesn't work all of the time is because the `devBuildResolve` function is called when the assets have been built, but this can happen before the `getFilesForRoute` promise chain has completed, and thus the `cancelled` variable could not yet have been updated. To fix this we wait for the `getFilesForRoute` promise chain to be fulfilled and then resolve the `devBuildPromise` promise afterwards. This allows the `getFilesForRoute` promise chain to be fulfilled before and the `cancelled` variable can be updated accordingly. If an error is thrown somewhere in the `getFilesForRoute` promise chain, i.e. due to a failed fetch request, then that will also resolve the `devBuildPromise` and the error will bubble up to ultimately become a `routeChangeError` which will reload the page. With this fix the need to listen for HMR events has become obsolete as regardless of when the HMR build/sync events complete we still want to ensure that the `getFilesForRoute` promise chain has been fulfilled before resolving the `devBuildPromise`. Co-authored-by:
Tobias Järvelöv <tobias.jarvelov@oderland.se> Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
Mohamed ElSaadany authored
* add locale switcher to dynamic GSP page in i18n-routing example * Apply suggestions from code review Co-authored-by:
JJ Kasper <jj@jjsweb.site> * Add switcher to other pages as well Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
stefanprobst authored
This adds missing eslint config options to the public `NextConfig` type. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes
-
stefanprobst authored
this pr moves the "core-web-vitals" config from `eslint-config-next` to `eslint-plugin-next`. Fixes: #27292 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [x] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes
-
JJ Kasper authored
-
Steven authored
Follow up to #26824
-
Yubin authored
This PR adds `lazyBoundary` prop on Image Component. This feature is to load the images earlier. I'm not good at English. So, I couldn't explain enough in the documentation what `lazyBoundary` is. Feature request: https://github.com/vercel/next.js/discussions/24552 ## Feature - [x] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [x] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [x] Make sure the linting passes
-
Steven authored
Fixes typo mentioned in https://github.com/vercel/next.js/pull/27346#discussion_r675477904
-
- 22 Jul, 2021 12 commits
-
-
JJ Kasper authored
-
Alex Castle authored
* Use sharp for image transformations when available * Refactor resizeImage and add sharp warning * only show sharp warning once per instance * Modify sharp error message * Add documentation for optional sharp dependency * Update docs/basic-features/image-optimization.md Co-authored-by:
Steven <steven@ceriously.com> * Import types for sharp * Update lockfile * Add testing against sharp * use fs-extra for node 12 * Rename test sharp path variable * Apply suggestions from code review Co-authored-by:
Steven <steven@ceriously.com> * update squoosh specific test * Apply suggestions from code review Co-authored-by:
Steven <steven@ceriously.com> * update tests * Apply suggestions from code review Co-authored-by:
Steven <steven@ceriously.com> Co-authored-by:
Steven <steven@ceriously.com> Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
Gerald Monaco authored
It's possible for `renderToHTML` to return `null` if `res.finished || res.headersSent` is `true` after `getInitialProps` or `getServerSideProps`. In such cases, we can't generate a valid `ResponseCacheEntry` or `ResponsePayload`, so we shouldn't try. I took the opportunity to add an invariant for when we expected a cacheable response, but didn't get one. This could happen because Next.js or an application erroneously mutated the underlying `res` during the rendering of a page with `getStaticProps`. This shouldn't normally be possible because `res` isn't exposed in such cases, but it's theoretically possible with a custom server, so it seemed worth flagging.
-
JJ Kasper authored
Follow-up to https://github.com/vercel/next.js/pull/27308 this increases the `exec` timeout to allow more time for the repo to install/build since it can sometimes take longer in GitHub actions.
-
JJ Kasper authored
This corrects a case when redirecting with i18n locale domains configured the locale domain would be prefixed on external redirects un-necessarily. Fixes: https://github.com/vercel/next.js/issues/27405 ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [x] Errors have helpful link attached, see `contributing.md`
-
Lee Robinson authored
Slightly more clear
😄 -
Aryan Beezadhur authored
Rename the `utils` folder to `lib`, and update file imports since other examples favour `lib` over `utils`.
-
Aryan Beezadhur authored
* Rename examples/with-mongodb/util/mongodb.js to examples/with-mongodb/lib/mongodb.js * Change file import from `util` to `lib`
-
Steven authored
Fixes #27109 This PR adds a default `agent` as described in the [`node-fetch` docs](https://github.com/node-fetch/node-fetch#custom-agent). We should see about 2x perf according to some [benchmarks](https://github.com/Ethan-Arrowood/undici-fetch/blob/main/benchmarks.md#fetch).
-
Mandar Patil authored
* Fixed typo and error when using Auth0 service; `Allowed Web Origin` on Auth0 is now required to be set to `http://localhost:3000` * lint-fix Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Rodrigo Roim authored
Closes: https://github.com/vercel/next.js/issues/27129 This configuration is similar to what we've been using at Statsig, and it's the best general purpose config I could think of. At Statsig we also invalidate our caches weekly, since sometimes we spend weeks without updating dependencies for some of our NextJS apps, and the artifact bloat means GitHub starts invalidating other caches in our repo. I could add that step to this diff as well, but I think that's a bit too specific (likely only a problem in monorepos with several caches). In any case, the previous example also has this problem. ## Documentation / Examples - [x] Make sure the linting passes
-
JJ Kasper authored
-
- 21 Jul, 2021 2 commits
-
-
JJ Kasper authored
-
Edward Brey authored
The prior configuration name indicating that it launched the application. Really, it just attaches to an already running application, which the new name indicates.
-