- 05 Aug, 2021 2 commits
-
-
JJ Kasper authored
-
Houssein Djirdeh authored
Documentation: - Expands the "Migrating Existing Config" section of ESLint doc to explain in more detail - Minor changes to the "Ignoring ESLint" doc Bug fixes: - Adds `browser` and `node` environments to `eslint-config-next`. Closes #26319 - Fixes `no-document-import` rule. Closes #26159 - Fixes `no-page-custom-font` rule. Closes #26160 #26894
-
- 04 Aug, 2021 6 commits
-
-
Nick Kelly authored
## Performance improvement - [x] Performance improvement Removes unnecessary `fs.stat` calls in `recursiveReadDir`. `fs.readdir` had an option `withFileTypes: boolean` added NodeJS version 10. It can be used to read the directory contents and fetch its stats simultaneously, removing the need to read individual file stats after reading the directory contents.
-
Houssein Djirdeh authored
This PR introduces an improved developer experience when `next lint` is run for the first time. ### Current behavior `eslint-config-next` is a required package that must be installed before proceeding with `next lint` or `next build`:  Although this has helped many developers start using the new ESLint config, this has also resulted in a few issues: - Users are required to install the full config (`eslint-config-next`) even if they do not use it or use the Next.js plugin directly (`eslint-plugin-next`). - #26348 - There's some confusion on why `eslint-config-next` needs to be installed or how it should be used instead of `eslint-plugin-next`. - #26574 - #26475 - #26438 ### New behavior Instead of enforcing `eslint-config-next` as a required package, this PR prompts the user by asking what config they would like to start. This happens when `next lint` is run for the first time **and** if no ESLint configuration is detected in the application. <img src="https://user-images.githubusercontent.com/12476932/124331177-e1668a80-db5c-11eb-8915-38d3dc20f5d4.gif" width="800" /> - The CLI will take care of installing `eslint` or `eslint-config-next` if either is not already installed - Users now have the option to choose between a strict configuration (`next/core-web-vitals`) or just the base configuration (`next`) - For users that decide to create their own ESLint configuration, or already have an existing one, **installing `eslint-config-next` will not be a requirement for `next lint` or `next build` to run**. A warning message will just show if the Next.js ESLint plugin is not detected in an ESLint config. <img width="682" alt="Screen Shot 2021-06-25 at 3 02 12 PM" src="https://user-images.githubusercontent.com/12476932/123473329-6cc4a680-d5c6-11eb-9a57-d5c0b89a2732.png"> --- In addition, this PR also: - Fixes #26348 - Updates documentation to make it more clear what approach to take for new and existing ESLint configurations
-
Artyom Kurnikov authored
- fix `with-fauna` example to populate client secret properly when auto-deploy on changes happens - improve security by avoiding usage of the `FAUNA_ADMIN_KEY` in the application, now it's used in the setup script only
-
JJ Kasper authored
This is a follow-up to https://github.com/vercel/next.js/pull/26963 which after discussion changes to interpolate the decoded variant of the value into the path. x-ref: https://github.com/vercel/next.js/issues/24775 ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md`
-
Steven authored
According to [MDN](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-hidden_attribute#deciding_between_aria-hiddentrue_rolepresentation_and_rolenone): - `aria-hidden="true"` will remove the entire element from the accessibility API. - `role="presentation"` will remove the semantic meaning of an element while still exposing it to assistive technology. We don't need both so we'll keep `aria-hidden="true"` since the element is used for sizing, not content that should be read. Fixes #27163
-
Steven authored
- Related to #27724 - Related to #19309 - Related to #23140
-
- 03 Aug, 2021 11 commits
-
-
Christian authored
For users looking at the api reference for 'next/head' it might be a good idea to let them know that there is the 'next/script' component. Using 'next/script' has a lot of advantages over adding a script tag with 'next/head' ## Documentation / Examples - [x] Make sure the linting passes
-
Maia Teegarden authored
* Add amp attribute transform * Add amp attribute unit tests * Fix ci if statements * Checkout code in rust tests * Add rust fixtures to eslintignore * Add cargo config * Configure toolchain for cross compilation
-
JJ Kasper authored
This adds handling for repeated forward/back slashes in Next.js, when these slashes are detected in a request to Next.js we will automatically remove the additional slashes redirecting with a 308 status code which prevents duplicate content when being crawled by search engines. Fixes: https://github.com/vercel/next.js/issues/13011 Fixes: https://github.com/vercel/next.js/issues/23772 Closes: https://github.com/vercel/next.js/pull/15171 Closes: https://github.com/vercel/next.js/pull/25745
-
강동윤 authored
-
stefanprobst authored
-
Lee Robinson authored
To make it more clear you're using the admin key on the server.
-
Tom Chen authored
Need `--template` in the `yarn` command, otherwise it's not working
-
JJ Kasper authored
-
Sergio authored
* Add joi and next-joi example * Add more README information * Update examples/with-joi/package.json Co-authored-by:
Lee Robinson <me@leerob.io> * Update all dependencies to latest Co-authored-by:
Lee Robinson <me@leerob.io>
-
Steven authored
Follow up to #27376 so users can disable keep-alive. See comment https://github.com/vercel/next.js/pull/27376#issuecomment-885415623
-
Tobias Koppers authored
-
- 02 Aug, 2021 9 commits
-
-
Steven authored
Resolves #27213
-
JJ Kasper authored
This ensures we enforce a limit for `source`/`destination` values on rewrites, redirects, and headers since these being too long can affect routing performance. Closes: https://github.com/vercel/next.js/issues/27696
-
Gerald Monaco authored
Remove unnecessary `React.Suspense` checks, as the minimum supported version is `react@>=17.0.1`. Also removes some files from the `react-18` integration test that are no longer necessary as of #26664.
-
Lee Robinson authored
A few things I noticed when deploying the example.
-
Artyom Kurnikov authored
Based on https://github.com/vercel/next.js/pull/26708 - Renames FaunaDB -> Fauna - Moves to Tailwind instead of bespoke styling - Use SWR instead of hand-rolled fetch wrapper - List/Create API for Guestbook - Preps for setting correct environment variables from Vercel integration
-
stefanprobst authored
fixes #27210 maybe related: #19668 currently, the image optimizer returns 400 when an image url contains non-ascii characters. this pr uri-encodes the `url` query parameter to fix it. also see https://github.com/vercel/next.js/issues/27210#issuecomment-890305204 ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes
-
Lee Robinson authored
Based on feedback here https://github.com/vercel/next.js/discussions/27687#discussioncomment-1121013.
-
JJ Kasper authored
This undoes the change from https://github.com/vercel/next.js/pull/27623 since it appears to be breaking source maps from changing the sources field in the generated source map to a relative path causing it to break jest's source map handling as can be seen in the `test-unit` CI job [here](https://github.com/vercel/next.js/runs/3214076727). This reverts commit f9ebc777.
-
James Howard authored
`getAllPostsWithSlug` was missing an `await` on `fetchAPI`, resulting in `data?.allPosts` always returning `undefined`. This meant SSG wasn't aware of the paths it needed to generate.
-
- 01 Aug, 2021 2 commits
-
-
Zack Sheppard authored
Documentation to help future developers avoid #27498 ## Documentation / Examples - [X] Make sure the linting passes
-
Tim Neutkens authored
Noticed while debugging that the error output lines did not make sense and found that `sourceFileName` is not supported in SWC yet. This is a temporary fix until @kdy1 adds the option.
-
- 31 Jul, 2021 1 commit
-
-
JJ Kasper authored
x-ref: https://github.com/vercel/next.js/issues/22660#issuecomment-890400273 ## Documentation / Examples - [x] Make sure the linting passes
-
- 30 Jul, 2021 2 commits
-
-
Sjors Smits authored
## Documentation / Examples - [x] Make sure the linting passes ## Explanation Fixes #27465 I added some docs on how to use per page persistent layouts in TypeScript as this requires you to extend some types and it might not be trivial if you are just starting out with TypeScript. I copied the js example so it might be better to remove some of the duplication where possible, let me know. All feedback is welcome
-
JJ Kasper authored
-
- 29 Jul, 2021 7 commits
-
-
Tim van de Vathorst authored
I was trying to run the demo locally and found out that the create user function was missing, so I added it! ## Documentation / Examples - [
✔ ] Make sure the linting passes -
Jiachi Liu authored
For test only, previously the react-dom is still been resolved as react 17 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes
-
Tim Neutkens authored
Fixes #27593 ## Bug - [x] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes
-
Tim Neutkens authored
## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes
-
Tobias Koppers authored
-
Tobias Koppers authored
* improve source-map performance * improve watch performance * bugfixes * improvements to Data URIs
-
JJ Kasper authored
This updates to only output a test's logs when it fails to reduce the noise in the CI's logs to allow easier investigating a failure. This also updates azure to leverage the `run-tests` script when testing ie11 to allow retrying similar to our other tests.
-