- 08 Jul, 2021 6 commits
-
-
JJ Kasper authored
-
Steven authored
Since we are no longer accepting new built-in loaders, users may wish to use a different cloud provider. So this PR renames `dangerously-unoptimized` to `custom` to handle this case as well as the intention of `next export`. If the user doesn't add a `loader` prop, we throw an error. If the user adds a `loader` prop but it doesn't return the width, we print a warning. - Follow up to #26847 - Fixes #21079 - Fixes #19612 - Related to #26850
-
Jaime Rios authored
Improve typing for use with Typescript example <!-- Thanks for opening a PR! Your contribution is much appreciated. In order to make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change that you're making: ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [X] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [X] Make sure the linting passes
-
Terry Tan authored
I think the issue was due to ```nextjs-auth0``` package on version ```0.8.0```. Upgrading to latest version ```1.4.2``` resolve the issue. ## Bug - [x] Related issues linked using `fixes` https://github.com/vercel/next.js/issues/19313
-
Houssein Djirdeh authored
Co-authored-by:kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Tim Neutkens authored
Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
- 07 Jul, 2021 10 commits
-
-
Steven authored
### Description This changes the strict TS types to a looser implementation such that the user can pass `src` without TS errors. ### Pros vs Cons - **Pros**: better support for wrapping `next/image` so that TS won't report false errors - **Cons**: using `src: string` without `blurDataURL` will no longer show TS errors and instead fail with a runtime error ### Issues - Fixes #26892 - Related to #26991
-
destruc7i0n authored
My last PR (#26205) made the hash change events not fire when in i18n was enabled, as seen in #26853. This PR fixes that and adds a test for this case. fixes #26853 ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes
-
Darsh Patel authored
* add support for static loader * update existing test * add test * add prettier-ignore * update docs * apply suggestions from review * remove un-needed normalize * Apply suggestions from code review Co-authored-by:
Steven <steven@ceriously.com> * update test Co-authored-by:
JJ Kasper <jj@jjsweb.site> Co-authored-by:
Steven <steven@ceriously.com>
-
Steven authored
### Description This changes the strict TS types to a looser implementation such that the user can always pass `width` and `height` (even when `layout=fill`) without TS errors. ### Pros vs Cons - **Pros**: better support for wrapping `next/image` so that TS won't report false errors with `layout=fill` - **Cons**: omitting width/height when using other `layout` will no longer show TS errors and instead fail with a runtime error ### Issues - Fixes #26531 - Fixes #25440
-
Alex Castle authored
fixes #19074 This change disables image lazy-loading when both of the following are true: 1) A image is being rendered following a client-side page transition 2) The image has been previously loaded during this session. Before this change, all images with lazy-loading enabled have a visible flicker during client-side page transitions, even though they're already loaded. With this change, there's are two performance risks: 1) There's a chance that some offscreen images will have lazy-loading disabled unnecessarily because they were previously loaded. I think the performance hit here is pretty negligible and the situation is unlikely to come up very often. 2) There's a chance a different-sized version of the image will be selected by the browser, but lazy-loading will be disabled anyway. This seems even more unlikely to me, and anyway the performance hit from a stray un-lazy-loaded image (on a client-side transition) is very minor. In both cases, I think the performance risk is outweighed by the UX improvement of getting rid of the image flicker on page transition.
-
Steven authored
This will ensure `next/script` follows the same naming convention as `next/image`. For example: ```js import Image, { ImageProps } from 'next/image' import Script, { ScriptProps } from 'next/script' ``` Fixes #26290 -
JJ Kasper authored
* Add page with next/image to stats-app * Update stats-config * Update globs * Only run prettier on js outputs * only add image page for non-webpack 4 mode * update config * Re-add moving page chunks
-
Anindya Dey authored
Fixes [issue #19588](https://github.com/vercel/next.js/issues/19588) Here's a screenshot of the error message: 
-
Tim Neutkens authored
-
Tobias Koppers authored
-
- 06 Jul, 2021 9 commits
-
-
JJ Kasper authored
-
JJ Kasper authored
-
Alexander authored
fixes #26609 ## Bug - [x] Related issues linked using fixes #number - [x] Integration tests added ## Documentation / Examples - [x] Make sure the linting passes
-
Paul Schultz authored
## Bug - [x] Related issues linked using `fixes #26970` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md`
-
Theo Strahlen authored
If the `Image` src url had existing query params, the imgix loader would simply append another query string with `?` causing both query strings to break. This PR adds a way to safely merge query strings if needed using [URLSearchParams](https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams). ## Bug - [X] fixes #26288 - [X] Integration tests added
-
Gerald Monaco authored
-
Gerald Monaco authored
Make the typing for `IncrementalCache` more explicit. With streaming, we’ll want to stream page data as well as HTML. This is a bit complicated now because we’re overloading `pageData` for both redirects and pages. This PR makes the different types explicit. With streaming, the data for redirects is synchronously available, while the data for pages will become a stream. A follow up PR will add a “stream through” cache in front of `IncrementalCache`
-
Jeongyeon Lee 이정연 authored
-
Gerald Monaco authored
Refactors the internals of `next-server` to use `ResponsePayload` instead of `string | null` and manual `sendPayload` calls. This is the first step toward streaming support. I split `renderToResponseWithComponents` into a separate `renderToResponseWithComponentsInternal` function for ease of review: GitHub's diff rendering was highly misleading, making it seem as though more of the function had changed. The separate function just makes the actual change clearer: we split `renderToHTMLWithComponents` into two promises; one that represents the actual render result, and one that represents all of the work (including background work for e.g. revalidation) that needs to be done as part of generating the result. These changes make it easier to bubble up a `ResponsePayload`, instead of sometimes calling `sendPayload` out-of-band, centralizing all payload handling in `sendResponse` and eventually a similar function for public APIs that return a string. This centralization will make it much easier to handle a response that needs to be streamed, which is coming soon in another PR.
-
- 05 Jul, 2021 2 commits
-
-
Gerald Monaco authored
-
Houssein Djirdeh authored
-
- 04 Jul, 2021 1 commit
-
-
Sachin Raja authored
Previous TypeScript template in `create-next-app` only had the following in `next-env.d.ts` ```ts /// <reference types="next" /> /// <reference types="next/types/global" /> ``` New `next-env.d.ts` has this: ```ts /// <reference types="next" /> /// <reference types="next/types/global" /> /// <reference types="next/image-types/global" /> ``` Next.js automatically adds the `image-types` reference, but it won't be included in the initial commit. ## Documentation / Examples - [x] Make sure the linting passes
-
- 02 Jul, 2021 12 commits
-
-
JJ Kasper authored
-
Maia Teegarden authored
This decreases the body size limit that triggers a warning from 5MB -> 4MB, which provides a little more wiggle room. Certain things like using base64 on body, headers, path, etc can cause the response to be larger than initially calculated. Initial PR: https://github.com/vercel/next.js/pull/26831
-
Angelo Ashmore authored
The CDN URL is the recommended URL for the Prismic REST and GraphQL APIs. ## Documentation / Examples - [x] Make sure the linting passes
-
JJ Kasper authored
This ensures when an error occurs in an API route while using minimal mode the error is bubbled so it can be handled at the top-level ## Bug - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md`
-
Paweł Tymczuk authored
This fixes the React warning: `Warning: Each child in a list should have a unique "key" prop.` that is thrown when using the `Script` components with the `beforeInteractive` strategy. Fixes: #26618
-
Maia Teegarden authored
This PR adds a warning when api responses exceed 5mb since this will end up failing once deployed. In a future version this scenario will throw an error. ## Bug - [x] Integration tests added ## Documentation / Examples - [x] Make sure the linting passes
-
hiro authored
- Fix typo on "occured" to "occurred"
-
Lee Robinson authored
So there's _conformance_ between the other docs / optimizations.
-
Tim Neutkens authored
Co-authored-by:kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Alex Castle authored
fixes #26607 This change makes it so the image loader plugin only emits a file while processing an image import for the client. The final generated image URL was already the same in SSR and CSR anyway, so this change doesn't have any functional impact. I also changed the name of the static page in the image component tests, since it was causing some conflicts with the static assets folder.
-
Paul van den Dool authored
## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [x] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes ## Why the change I lost quite a few hours figuring out why my environment variable was `undefined` in the browser. I read about the built-in support and was like: "Oh nice" and didn't read much further. I missed the part about how you need to prefix your variables with `NEXT_PUBLIC_` in order to expose them to the browser. I think a hint to this in the anchor link to that section will make it more discoverable as it's then mentioned near the top and will save people who are like me some time and a headache.
-
Tim Neutkens authored
Co-authored-by:
Jiachi Liu <inbox@huozhi.im> Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-