- 31 Aug, 2021 3 commits
-
-
Tim Neutkens authored
-
jj@jjsweb.site authored
-
JJ Kasper authored
* Ensure custom app regex is correct for Windows * lint-fix * update test for ie * update test * lint-fix
-
- 30 Aug, 2021 7 commits
-
-
Kara authored
Previous to this change, getServerSideProps could only return plain objects for props, e.g.: ```javascript export async function getServerSideProps() { return { props: { text: 'some value', } } } ``` With this commit, the props object can also be a Promise, e.g. ```javascript export async function getServerSideProps() { return { props: (async function () { return { text: 'promise value', } })(), } } ``` For now, the framework simply waits for the results of the props Promise to resolve, but this small change sets the groundwork for later allowing props to be streamed (cc @devknoll). ## Feature - [x] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. -- *This is part of @devknoll's ongoing work to support streaming.* - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [x] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. *not sure if this applies here* - [ ] Errors have helpful link attached, see `contributing.md` -
Jiachi Liu authored
Fix warning of peer dep on yarn (berry version) install
-
Steven authored
-
jj@jjsweb.site authored
-
Knut Melvær authored
The client now warns against missing `apiVersion` ([docs](https://www.sanity.io/docs/api-versioning)). This PR adds the config for using the latest API version. There shouldn't be breaking changes in this app. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes
-
Steven authored
-
Steven authored
Add CSP header to Image Optimization API
-
- 29 Aug, 2021 1 commit
-
-
Anderson Leite authored
'await' has no effect on the type of this expression.ts(80007) ## Bug - [X] Integration tests clean up ## Documentation / Examples - [x] Make sure the linting passes
-
- 28 Aug, 2021 1 commit
-
-
Mike Hedman authored
"exclusive of" implies that it doesn't pertain to `export` https://www.merriam-webster.com/dictionary/exclusive%20of "Exclusive to" implies that it's only relevant to `export`. Also changed "can not" to "cannot". ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes
-
- 27 Aug, 2021 2 commits
-
-
Scotty Waggoner authored
Feel free to edit this/suggest changes as you see fit to match the style of your docs or how you want this feature represented. There seemed to be many issues regarding colocating non-page files with page components in the `pages` directory where `pageExtensions` was finally suggested as a solution. I think it would be great to document it better since it seems to be a often requested workflow to colocate test, generated files, styles, and other files needed by page components in the `pages` directory. The note that exists in the docs currently alludes to the ability to do this but it doesn't contain much context that would help make it more discoverable. Relevant issues: https://github.com/vercel/next.js/discussions/11113#discussioncomment-427139 https://github.com/vercel/next.js/issues/8454#issuecomment-560432659 https://github.com/vercel/next.js/issues/8617#issuecomment-790030032 https://github.com/vercel/next.js/issues/3728#issuecomment-523789071
-
JJ Kasper authored
-
- 26 Aug, 2021 3 commits
-
-
Delba de Oliveira authored
This PR updates the with-jest example to the latest version of Jest and adds a note about the Jest and RTL testing environments (related to this [discussion](https://github.com/vercel/next.js/discussions/28337)). Also adds minor tweaks to the testing docs. ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [x] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [x] Make sure the linting passes
-
Gerald Monaco authored
-
Steven authored
- Follow up to #28221 - Fixes #27644
-
- 25 Aug, 2021 12 commits
-
-
Steven authored
-
Houssein Djirdeh authored
Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Ado Kukic authored
* Update to use the latest MongoDB best practices. * lint-fix Co-authored-by:
Lee Robinson <me@leerob.io> Co-authored-by:
jj@jjsweb.site <jj@jjsweb.site>
-
Hunter Tunnicliff authored
* Use recommended pattern in testing example Since the official linter for testing library, `eslint-plugin-testing-library` recommends using `screen` to write queries, this MR updates the testing library example to follow the pattern recommended by the linter. > DOM Testing Library (and other Testing Library frameworks built on top of it) exports a screen object which has every query (and a debug method). This works better with autocomplete and makes each test a little simpler to write and maintain. > This rule aims to force writing tests using built-in queries directly from screen object rather than destructuring them from render result. Given the screen component does not expose utility methods such as rerender() or the container property, it is correct to use the render returned value in those scenarios. See the `prefer-screen-queries` rules docs for more info: https://github.com/testing-library/eslint-plugin-testing-library/blob/main/docs/rules/prefer-screen-queries.md * Update devDependencies * Install and configure test linting * Use recommended pattern in test * Update test names for consistency * Update docs * Set jest environment in each file * Use root true in `with-jest` eslint config * Ensure nested .eslintrcs are not loaded for repo lint Co-authored-by:
jj@jjsweb.site <jj@jjsweb.site>
-
Steven authored
-
JJ Kasper authored
This ensures we handle 204 and 304 status codes correctly in API routes. ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [x] Errors have helpful link attached, see `contributing.md` Fixes: https://github.com/vercel/next.js/issues/28464
-
JJ Kasper authored
* Update i18n locales limit to warning * update version -> versions * bump * Use Log.warn instead * Apply suggestions from code review Co-authored-by:
Lee Robinson <me@leerob.io> Co-authored-by:
Lee Robinson <me@leerob.io>
-
zhafri-shafiq authored
## Bug - Related issues #28480 This is just minor dependency fix that I noticed while going through the examples.
-
Tim Neutkens authored
-
Tim Neutkens authored
-
Tim Neutkens authored
Co-authored-by:Steven <steven@ceriously.com>
-
JJ Kasper authored
* Ensure error is shown correctly for empty headers field * Apply suggestions from code review Co-authored-by:
Steven <steven@ceriously.com> Co-authored-by:
Steven <steven@ceriously.com>
-
- 24 Aug, 2021 10 commits
-
-
Steven authored
There was some confusion in [this tweet](https://twitter.com/mtliendo/status/1430269174459338759) so I revised the docs around `sharp` usage.
-
Anderson Leite authored
Adds tests to the Image component to verify that the correct data is being exposed. Based on #27899 and #28312 ## Bug - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes
-
Robbie Averill authored
## Documentation / Examples - [x] Make sure the linting passes
-
Elliot Scribner authored
Just a small change to recently merged PR; for some reason `import couchbase from 'couchbase'` is not working correctly when I use create-next-app to bootstrap with the `with-couchbase` example, despite initially working within my local next.js directory. The wildcard import fixes that issue. Thanks! ## Documentation / Examples - [x] Make sure the linting passes
-
Aravind Putrevu authored
## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [x] Make sure the linting passes
-
Janicklas Ralph authored
* Fix #27747 * Fix lint error * Add data attribute to script component * Fix #28036 * Fix tests * Fix tests Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
jj@jjsweb.site authored
-
Mateusz Burzyński authored
This is similar to https://github.com/vercel/next.js/pull/27126 , https://github.com/vercel/next.js/pull/27446 and https://github.com/vercel/next.js/pull/27974 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [x] Make sure the linting passes
-
JJ Kasper authored
* Move unit tests to one folder * Migrate unit tests to TypeScript * add test types to lint * Ensure ts(x) tests are run with util * Add tsx extension to jest config * bump
-
Elliot Scribner authored
This adds a simple `with-couchbase` example app complete with a check for successful connection (in `index.js`). **Note:** To check the connection, this application runs a simple KV GET operation with a key that does not exist and expects a response of `document not found`. Any other response indicates a failure to connect. Thank you!
-
- 23 Aug, 2021 1 commit
-
-
JJ Kasper authored
This updates our `jest` configuration to no longer use `babel-jest` and instead uses `@swc/jest` which is much faster. This also updates to the latest version of `jest`, fixes our `tsconfig.json` used for tests (previously types in `node_modules` weren't resolved correctly), and ensures `next/dist` isn't un-necessarily transpiled in `jest`. Timings for `yarn testheadless test/unit/` on CI - before: 3m 30s - 4m ([example run](https://github.com/vercel/next.js/runs/3394701995)) - after: under 1m ([example run](https://github.com/vercel/next.js/pull/28400/checks?check_run_id=3395161621)) Timings for `yarn testheadless test/unit/` locally on m1 mac - before: 90.16 seconds - after: 29.92 seconds
-