- 02 Sep, 2021 3 commits
-
-
Tim Neutkens authored
-
Tim Neutkens authored
Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Alex Castle authored
In talking to partners, I've seen a lot of confusion about the number of wrapping `<div>`s around the image element rendered by `next/image`. There's always just one single wrapper--this PR updates the docs to make that a little more explicit.
-
- 01 Sep, 2021 6 commits
-
-
jj@jjsweb.site authored
-
JJ Kasper authored
Follow-up to https://github.com/vercel/next.js/pull/28713 this ensures we also don't duplicate `@babel/core` in our `babel-packages` bundle. This was occurring from us re-using the `@babel/core` package name which causes us to remove it from the externals [here](https://github.com/vercel/next.js/blob/77c0e0937128409960ee48ee965501f4d18c9c82/packages/next/taskfile-ncc.js#L18-L21).
-
JJ Kasper authored
This is a follow-up to https://github.com/vercel/next.js/pull/28174 to ensure we de-dupe `@babel/types` correctly as this increased the compiled `babel` packages quite a bit.
-
Jiachi Liu authored
## Bug Fixes #28693 - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md`
-
JJ Kasper authored
* Ensure build trace is correct with extra entries * lint-fix * fix check on windows
-
Eungyeol authored
The following error occurred when I created a project with the typecript template of createp-next-app and did the 'next build'. ```shell It looks like you're trying to use TypeScript but do not have the required package(s) installed. Please install @types/node by running: yarn add --dev @types/node If you are not trying to use TypeScript, please remove the tsconfig.json file from your package root (and any TypeScript files in your pages directory). ``` This issue was resolved by adding @types/node. So I added @types/node to the devDependencies of the create-next-app typecript template.
-
- 31 Aug, 2021 9 commits
-
-
Aleksa Cukovic authored
Current docs on exposing environment variables to the browser are slightly misleading as they say that variables loaded from `.env.local` are only available in node by default, but this is the case for all environment variables not just those loaded from `.env.local`. ## Documentation - [x] Make sure the linting passes
-
jj@jjsweb.site authored
-
Rahul Gaba authored
Fix for `next-script-for-ga` ESLint rule crashing when a method is used in dangerouslySetInnerHTML (#28675) Fixes #28635 ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [x] Errors have helpful link attached, see `contributing.md`
-
Steven authored
This type was added in PR #28269 but doesn't need to be public and was causing conflicts with `@types/react@17`. We currently use `@types/react@16` so ideally we should upgrade to `@types/react@17` and then remove the `ts-ignore`. Fixes #28647
-
Tobias Koppers authored
prefer commonjs externals even if "module" condition is used in package.json ## Bug - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md`
-
matamatanot authored
## Documentation / Examples - [x] Make sure the linting passes **My console** > src/pages/_document.tsx#L14 > Use the `next/script` component for loading third party scripts. See: https://nextjs.org/docs/messages/next-script-for-ga https://nextjs.org/docs/messages/next-script-for-ga is 404 now.
-
Tim Neutkens authored
-
jj@jjsweb.site authored
-
JJ Kasper authored
* Ensure custom app regex is correct for Windows * lint-fix * update test for ie * update test * lint-fix
-
- 30 Aug, 2021 7 commits
-
-
Kara authored
Previous to this change, getServerSideProps could only return plain objects for props, e.g.: ```javascript export async function getServerSideProps() { return { props: { text: 'some value', } } } ``` With this commit, the props object can also be a Promise, e.g. ```javascript export async function getServerSideProps() { return { props: (async function () { return { text: 'promise value', } })(), } } ``` For now, the framework simply waits for the results of the props Promise to resolve, but this small change sets the groundwork for later allowing props to be streamed (cc @devknoll). ## Feature - [x] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. -- *This is part of @devknoll's ongoing work to support streaming.* - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [x] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. *not sure if this applies here* - [ ] Errors have helpful link attached, see `contributing.md` -
Jiachi Liu authored
Fix warning of peer dep on yarn (berry version) install
-
Steven authored
-
jj@jjsweb.site authored
-
Knut Melvær authored
The client now warns against missing `apiVersion` ([docs](https://www.sanity.io/docs/api-versioning)). This PR adds the config for using the latest API version. There shouldn't be breaking changes in this app. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes
-
Steven authored
-
Steven authored
Add CSP header to Image Optimization API
-
- 29 Aug, 2021 1 commit
-
-
Anderson Leite authored
'await' has no effect on the type of this expression.ts(80007) ## Bug - [X] Integration tests clean up ## Documentation / Examples - [x] Make sure the linting passes
-
- 28 Aug, 2021 1 commit
-
-
Mike Hedman authored
"exclusive of" implies that it doesn't pertain to `export` https://www.merriam-webster.com/dictionary/exclusive%20of "Exclusive to" implies that it's only relevant to `export`. Also changed "can not" to "cannot". ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes
-
- 27 Aug, 2021 2 commits
-
-
Scotty Waggoner authored
Feel free to edit this/suggest changes as you see fit to match the style of your docs or how you want this feature represented. There seemed to be many issues regarding colocating non-page files with page components in the `pages` directory where `pageExtensions` was finally suggested as a solution. I think it would be great to document it better since it seems to be a often requested workflow to colocate test, generated files, styles, and other files needed by page components in the `pages` directory. The note that exists in the docs currently alludes to the ability to do this but it doesn't contain much context that would help make it more discoverable. Relevant issues: https://github.com/vercel/next.js/discussions/11113#discussioncomment-427139 https://github.com/vercel/next.js/issues/8454#issuecomment-560432659 https://github.com/vercel/next.js/issues/8617#issuecomment-790030032 https://github.com/vercel/next.js/issues/3728#issuecomment-523789071
-
JJ Kasper authored
-
- 26 Aug, 2021 3 commits
-
-
Delba de Oliveira authored
This PR updates the with-jest example to the latest version of Jest and adds a note about the Jest and RTL testing environments (related to this [discussion](https://github.com/vercel/next.js/discussions/28337)). Also adds minor tweaks to the testing docs. ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [x] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [x] Make sure the linting passes
-
Gerald Monaco authored
-
Steven authored
- Follow up to #28221 - Fixes #27644
-
- 25 Aug, 2021 8 commits
-
-
Steven authored
-
Houssein Djirdeh authored
Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Ado Kukic authored
* Update to use the latest MongoDB best practices. * lint-fix Co-authored-by:
Lee Robinson <me@leerob.io> Co-authored-by:
jj@jjsweb.site <jj@jjsweb.site>
-
Hunter Tunnicliff authored
* Use recommended pattern in testing example Since the official linter for testing library, `eslint-plugin-testing-library` recommends using `screen` to write queries, this MR updates the testing library example to follow the pattern recommended by the linter. > DOM Testing Library (and other Testing Library frameworks built on top of it) exports a screen object which has every query (and a debug method). This works better with autocomplete and makes each test a little simpler to write and maintain. > This rule aims to force writing tests using built-in queries directly from screen object rather than destructuring them from render result. Given the screen component does not expose utility methods such as rerender() or the container property, it is correct to use the render returned value in those scenarios. See the `prefer-screen-queries` rules docs for more info: https://github.com/testing-library/eslint-plugin-testing-library/blob/main/docs/rules/prefer-screen-queries.md * Update devDependencies * Install and configure test linting * Use recommended pattern in test * Update test names for consistency * Update docs * Set jest environment in each file * Use root true in `with-jest` eslint config * Ensure nested .eslintrcs are not loaded for repo lint Co-authored-by:
jj@jjsweb.site <jj@jjsweb.site>
-
Steven authored
-
JJ Kasper authored
This ensures we handle 204 and 304 status codes correctly in API routes. ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [x] Errors have helpful link attached, see `contributing.md` Fixes: https://github.com/vercel/next.js/issues/28464
-
JJ Kasper authored
* Update i18n locales limit to warning * update version -> versions * bump * Use Log.warn instead * Apply suggestions from code review Co-authored-by:
Lee Robinson <me@leerob.io> Co-authored-by:
Lee Robinson <me@leerob.io>
-
zhafri-shafiq authored
## Bug - Related issues #28480 This is just minor dependency fix that I noticed while going through the examples.
-