- 28 Oct, 2021 26 commits
-
-
jj@jjsweb.site authored
-
JJ Kasper authored
-
JJ Kasper authored
-
George Karagkiaouris authored
## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` Fixes #30430 There's some more discussion in the issue, but in summary: - web `Headers` implementation combines all header values with `', '` - For `Set-Cookie` headers, you're supposed to set them as separate values, not combine them - web `Headers` forbids the use of `Cookie`, `Set-Cookie` and some more headers, so they don't have custom implementation for those, and still joins them with `,` - We currently just split them using `split(',')`, but this breaks when the header contains a date (expires, max-age) that also includes a `,` I used this method to split the Set-Cookie header properly: https://www.npmjs.com/package/set-cookie-parser#splitcookiestringcombinedsetcookieheader as suggested [here](https://github.com/whatwg/fetch/issues/973#issuecomment-559678813) I didn't add it as a dependency, since we only needed that one method and I wasn't sure what the process is for adding dependencies, so I just added the method in the middleware utils -
Jiachi Liu authored
Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
jj@jjsweb.site authored
-
JJ Kasper authored
-
JJ Kasper authored
-
Keen Yee Liau authored
`featureName` is restricted to certain values for security reasons. Before any change is made in the client, backend code has to be updated first.
-
Mitheel authored
-
Akira Tsuboi authored
## Bug - [x] Related issues linked using `fixes #number` fixes #27170 ### Before  ### After 
-
Tobias Koppers authored
-
Tobias Koppers authored
Co-authored-by:Donny/강동윤 <kdy1997.dev@gmail.com>
-
Tobias Koppers authored
-
Tobias Koppers authored
-
Tobias Koppers authored
-
Tobias Koppers authored
This reverts commit 387d6564.
-
Donny/강동윤 authored
-
Donny/강동윤 authored
Co-authored-by:kdy1 <kdy1@users.noreply.github.com>
-
Kai Malcolm authored
This PR adds documentation on how to debug through VS Code on Windows. Closes #30231 ## Documentation / Examples - [x] Make sure the linting passes
-
Donny/강동윤 authored
Co-authored-by:kdy1 <kdy1@users.noreply.github.com>
-
JJ Kasper authored
Co-authored-by:kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Tim Neutkens authored
-
JJ Kasper authored
Co-authored-by:kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Lucas Vazquez authored
Several examples at https://nextjs.org/docs/api-reference/next.config.js/headers have a comma at the end of the returns, which makes them invalid examples.
-
Maia Teegarden authored
* Fix issue with placeholder followed by numbers * Build next-swc binaries
-
- 27 Oct, 2021 14 commits
-
-
Balázs Orbán authored
I changed the order of `NextRequest` and `NextFetchEvent` as they are presented in the function signature. There also seemed to be some issues with the heading levels. Also, `NextResponse` is a documented API, but the example code uses `Response`. I wasn't sure if this was a mistake in the docs or in the code. I noticed that other similar docs pages have a collapsible `Examples` section at their top: - https://nextjs.org/docs/api-reference/next/image - https://nextjs.org/docs/api-reference/next/head - https://nextjs.org/docs/api-reference/next/amp Image below:  Should the Middleware docs have the same?
-
JJ Kasper authored
This ensures we don't add non-es5 code from ncc'ing Fixes: https://github.com/vercel/next.js/issues/30450 ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [x] Errors have helpful link attached, see `contributing.md`
-
JJ Kasper authored
-
JJ Kasper authored
-
JJ Kasper authored
Links the failed to load bindings error document to the new discussion here: https://github.com/vercel/next.js/discussions/30468 ## Documentation / Examples - [x] Make sure the linting passes by running `yarn lint`
-
Tim Neutkens authored
-
Tim Neutkens authored
Co-authored-by:Tobias Koppers <tobias.koppers@googlemail.com>
-
Steven authored
This warning was incorrectly displaying for the "background" use case demonstrated here: https://image-component.nextjs.gallery/background
-
Luke Howsam authored
This PR: Fixes a broken link in the testing documentation. It appears that the selector currently being used is `#test-environment-variable`. When clicked this results in the user being re-directed to the top of the environment variables page. The correct selector is: `#test-environment-variables` ## Documentation / Examples - [x] Make sure the linting passes by running `yarn lint`
-
Bruce Rodrigues authored
Just removing the duplicated use of `instead` on `next.config.js/rewrites` doc
-
Tobias Koppers authored
-
Tobias Koppers authored
-
Donny/강동윤 authored
Co-authored-by:
kdy1 <kdy1@users.noreply.github.com> Co-authored-by:
Tim Neutkens <tim@timneutkens.nl>
-
Tim Neutkens authored
-