- 02 May, 2022 9 commits
-
-
JJ Kasper authored
-
Steven authored
Fixes the GitHub CODEOWNERS pattern matching which previously missed adding me to #36611
-
Tim Neutkens authored
-
HYEON GYU KIM authored
Script component manages the cache as src or id. But in this example, id is missed. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`
-
Tim Neutkens authored
Co-authored-by:kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Naoyuki Kanezawa authored
- improve the message for importing node builtin module on edge runtime - fix to show the message on overlay of error browser with `next dev` - fix https://github.com/vercel/next.js/issues/36237 The message is NOT shown when using edge runtime (not middleware) since I cannot find a way to detect a webpack compilation is for edge runtime. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`
-
JJ Kasper authored
This updates the `pagesDir` config for the new return shape updated in https://github.com/vercel/next.js/pull/36619, no additional tests were added as existing tests were failing from this. x-ref: https://github.com/vercel/next.js/runs/6257712883?check_suite_focus=true x-ref: https://github.com/vercel/next.js/runs/6257712805?check_suite_focus=true x-ref: https://github.com/vercel/next.js/pull/36619
-
Tim Neutkens authored
Co-authored-by:
JJ Kasper <22380829+ijjk@users.noreply.github.com> Co-authored-by:
Jiachi Liu <4800338+huozhi@users.noreply.github.com>
-
Tim Neutkens authored
## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`
-
- 01 May, 2022 3 commits
-
-
Tim Neutkens authored
-
Tim Neutkens authored
Fixes #35469 Adds `pagesDir` which is required for the Relay transform. Added a test case based on https://github.com/hanford/relay-swc-jest. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint` Co-authored-by:
JJ Kasper <22380829+ijjk@users.noreply.github.com>
-
JJ Kasper authored
This updates to show a 400 (bad request) when an invalid path is sent to Next.js similar to our decode failure handling. ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` Closes: https://github.com/vercel/next.js/issues/36555Co-authored-by:
Tim Neutkens <6324199+timneutkens@users.noreply.github.com>
-
- 30 Apr, 2022 5 commits
-
-
Jiachi Liu authored
When using pnpm / yarnPnP to install next.js, styled-jsx as dependency is not hoisted in the top level node_modules, it will fail when nodejs is trying to resolve `styled-jsx/style` from project directory. Re-export `styled-jsx/style` in next.js and let swc/babel plugin compile the import path it to `next/dist/shared/lib/styled-jsx` Resolves #10149 Closes #21320 Closes #9325 Co-authored-by:Tim Neutkens <6324199+timneutkens@users.noreply.github.com>
-
ro11ingbutler authored
## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`
-
Lee Robinson authored
I've heard a lot of folks not realize this is possible
😄 Hopefully this helps. -
Javi Velasco authored
This PR brings some significant refactoring in preparation for upcoming middleware changes. Each commit can be reviewed independently, here is a summary of what each one does and the reasoning behind it: - [Move pagesDir to next-dev-server](https://github.com/javivelasco/next.js/pull/12/commits/f2fe154c007379f71c14960ddc553eaaaf786ffa) simply moves the `pagesDir` property to the dev server which is the only place where it is needed. Having it for every server is misleading. - [Move (de)normalize page path utils to a file page-path-utils.ts](https://github.com/javivelasco/next.js/pull/12/commits/27cedf087187b9632ef82a34b3af9cc4fe05d98b) Moves the functions to normalize and denormalize page paths to a single file that is intended to hold every utility function that transforms page paths. Since those are complementary it makes sense to have them together. I also added explanatory comments on why they are not idempotent and examples for input -> output that I find very useful. - [Extract removePagePathTail](https://github.com/javivelasco/next.js/pull/12/commits/6b121332aa9d3e50bd0f28b691fb7faea1b95f51) This extracts a function to remove the tail on a page path (absolute or relative). I'm sure there will be other contexts where we can use it. - [Extract getPagePaths and refactor findPageFile](https://github.com/javivelasco/next.js/pull/12/commits/cf2c7b842eebd8c02f23e79345681a794516b646) This extracts a function `getPagePaths` that is used to generate an array of paths to inspect when looking for a page file from `findPageFile`. Then it refactors such function to use it parallelizing lookups. This will allow us to print every path we look at when looking for a file which can be useful for debugging. It also adds a `flatten` helper. - [Refactor onDemandEntryHandler](https://github.com/javivelasco/next.js/pull/12/commits/4be685c37e3d1b797e929ea4f31495ed7b00e1cc) I've found this one quite difficult to understand so it is refactored to use some of the previously mentioned functions and make it easier to read. - [Extract absolutePagePath util](https://github.com/javivelasco/next.js/pull/12/commits/3bc078347426c73491a076d54ef4de977d9da073) Extracts yet another util from the `next-dev-server` that transforms an absolute path into a page name. Of course it adds comments, parameters and examples. - [Refactor MiddlewarePlugin](https://github.com/javivelasco/next.js/pull/12/commits/c595a2cc629b358cc61861a8a4848b7890d0a15b) This is the most significant change. The logic here was very hard to understand so it is totally redistributed with comments. This also removes a global variable `ssrEntries` that was deprecated in favour of module metadata added to Webpack from loaders keeping less dependencies. It also adds types and makes a clear distinction between phases where we statically analyze the code, find metadata and generate the manifest file cc @shuding @huozhi EDIT: - [Split page path utils](https://github.com/vercel/next.js/pull/36576/commits/158fb002d02887d7ce4be6747cf550a825a426eb) After seeing one of the utils was being used by the client while it was defined originally in the server, with this PR we are splitting the util into multiple files and moving it to `shared/lib` in order to make explicit that those can be also imported from client.
-
Steven authored
Fixes #35514
-
- 29 Apr, 2022 5 commits
-
-
JJ Kasper authored
-
Houssein Djirdeh authored
Adds inline script functionality to `next/script` for `worker` and `beforeInteractive` strategies (#36364) Adds inline script functionality to `next/script` for `worker` and `beforeInteractive` strategies. - fixes #36318 - fixes #26343 - fixes #26591 - fixes #26343 - fixes #26240 Co-authored-by:Janicklas Ralph <6142074+janicklas-ralph@users.noreply.github.com>
-
JJ Kasper authored
-
Balázs Orbán authored
Makes it easier to detect why a network error occurred with the CLI or `next info`, based on https://github.com/vercel/next.js/issues/36344 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`
-
Adam Tolley authored
This should be made explicitly clear because other code may just call `next` instead of `next dev` (e.g. https://github.com/netlify/framework-info/blob/main/src/frameworks/next.json). Being in the ninth circle of debug hell right now I could not take it for granted that the two were the same till I saw some kind of confirmation, either from the docs or from the source. Source is great, but calling it out in the docs would saved me some time. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`
-
- 28 Apr, 2022 16 commits
-
-
Jiachi Liu authored
x-ref: https://github.com/coryetzkorn/twitter-algorithm/pull/2 * Bump styled-jsx to latest version (5.0.2), so that it could get dedup when user installs the styled-jsx manually * Remove the legacy `@types/styled-jsx`
-
Jiachi Liu authored
* hoist `react-dom/server` imports to reduce module load time in nodejs * simplify `reactRoot` detection condition by checking the streaming rendering API we're using. (if it doesn't existed, like react 17, then we won't enable `reactRoot`) * Merge `__NEXT_CONCURRENT_FEATURES` into `__NEXT_REACT_ROOT` env var since they're identical now
-
JJ Kasper authored
-
Balázs Orbán authored
Fixes #35753 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint` Co-authored-by:JJ Kasper <22380829+ijjk@users.noreply.github.com>
-
JJ Kasper authored
This is a follow-up to https://github.com/vercel/next.js/pull/36527 to make sure we eagerly patch the lockfile as the correct swc dependency will be present if the platform matches so the load failure isn't hit which is where we were previously patching the lockfile. This is done in the background so does not block compilation. This also removes some extra logs that aren't necessary. <details> <summary>before lockfile patch</summary>  </details> <details> <summary>after lockfile patch</summary>  </details> This also fixes a case I noticed where we weren't flushing events before exiting when builds fail
-
Shu Ding authored
This PR makes the `Options` type of base server configurable as well as assigning to `this.serverOptions`, so the web server can access it during `constructor()`. This gets rid of the dirty `__server_context` hack. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`
-
Lazar Nikolov authored
## Overview This PR updates both Chakra UI examples by updating the Chakra UI packages to the latest versions, and added better examples for Semantic Tokens (new feature in Chakra UI), and pseudo props. ## Documentation / Examples - [x] Make sure the linting passes by running `yarn lint` Co-authored-by:Balázs Orbán <18369201+balazsorban44@users.noreply.github.com>
-
Donny/강동윤 authored
This PR updates swc to https://github.com/swc-project/swc/commit/a72f436148db1aecfbfcbf64c902f926b44e9dbf This PR applies - https://github.com/swc-project/swc/pull/4452 - Fixes `yield*` of async generators in async generators. - Fixes name mangling of injected helpers. - Note: This only applies to tiny files which enables lots of helpers. - https://github.com/swc-project/swc/pull/4468 - Fixes newer version of react.
-
Tim Neutkens authored
-
Tim Neutkens authored
-
Donny/강동윤 authored
-
JJ Kasper authored
-
Jiachi Liu authored
Co-authored-by:kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
LongYinan authored
fixes https://github.com/vercel/next.js/issues/35661 ## Bug - [x] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [x] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`
-
JJ Kasper authored
-
Mohamed ElSaadany authored
This makes it clear that the font optimization adds these for you. This avoids duplicate `<link rel="preconnect" />` in the HTML output if the developer is unaware that it is being added automatically. ## Documentation / Examples - [x] Make sure the linting passes by running `yarn lint`
-
- 27 Apr, 2022 2 commits
-
-
Lee Robinson authored
ISR works self-hosted, but there's some more guidance needed when hosting with container-based setups (e.g. Kubernetes) and how the files are shared between different pods. This was based on community feedback. Please let me know if you'd like to see any additions here!
🙏 -
Alex Castle authored
This PR makes the following changes: * Always add the `height` and `width` prop to image with `raw` layout (previously only added to images without `sizes`) * Add a warning if a raw layout image is getting stretched (which can be caused by interaction of height and width prop with styles) * Remove automatic aspect-ratio style from `raw` images. This is no longer necessary if all `raw` images have height and width props. * Update tests and docs accordingly
-